Re: [PATCH 06/10] compositor-drm: Handle more than two output crtcs per card

2015-06-30 Thread Bryce Harrington
On Fri, Jun 26, 2015 at 01:34:42PM -0500, Derek Foreman wrote: > On 21/06/15 02:25 PM, Mario Kleiner wrote: > > Allow proper handling of output->pipe > 1 to support > > triple-head graphics cards etc. by using the "high-crtc" > > support introduced in Linux 2.6.39 and libdrm 2.4.25 > > around May 2

Re: [PATCH 06/10] compositor-drm: Handle more than two output crtcs per card

2015-06-30 Thread Bill Spitzak
On Mon, Jun 29, 2015 at 2:06 PM, Mario Kleiner wrote: > > The bits are not a bit mask where a specific bit position corresponds to a > specific pipe, but those bits encode a 5 bits wide pipe number between 0 > and (2^5)-1 ie. 0-31. The comment in the code snippet you show about bits > 1-6 is a bi

Re: [PATCH 06/10] compositor-drm: Handle more than two output crtcs per card

2015-06-29 Thread Mario Kleiner
On 06/29/2015 10:20 PM, Bill Spitzak wrote: On Fri, Jun 26, 2015 at 11:34 AM, Derek Foreman mailto:der...@osg.samsung.com>> wrote: > +static unsigned int drm_waitvblank_pipe(struct drm_output *output) > +{ > + if (output->pipe > 1) > + return (output->pipe <<

Re: [PATCH 06/10] compositor-drm: Handle more than two output crtcs per card

2015-06-29 Thread Derek Foreman
On 29/06/15 03:20 PM, Bill Spitzak wrote: > On Fri, Jun 26, 2015 at 11:34 AM, Derek Foreman > wrote: > > > > +static unsigned int drm_waitvblank_pipe(struct drm_output *output) > > +{ > > + if (output->pipe > 1) > > + return (output-

Re: [PATCH 06/10] compositor-drm: Handle more than two output crtcs per card

2015-06-29 Thread Bill Spitzak
On Fri, Jun 26, 2015 at 11:34 AM, Derek Foreman wrote: > > > +static unsigned int drm_waitvblank_pipe(struct drm_output *output) > > +{ > > + if (output->pipe > 1) > > + return (output->pipe << DRM_VBLANK_HIGH_CRTC_SHIFT) & > > + DRM_VBLANK_HIGH_CRTC_MA

Re: [PATCH 06/10] compositor-drm: Handle more than two output crtcs per card

2015-06-26 Thread Derek Foreman
On 21/06/15 02:25 PM, Mario Kleiner wrote: > Allow proper handling of output->pipe > 1 to support > triple-head graphics cards etc. by using the "high-crtc" > support introduced in Linux 2.6.39 and libdrm 2.4.25 > around May 2011. > > Signed-off-by: Mario Kleiner Looks good to me. Reviewed-By:

[PATCH 06/10] compositor-drm: Handle more than two output crtcs per card

2015-06-21 Thread Mario Kleiner
Allow proper handling of output->pipe > 1 to support triple-head graphics cards etc. by using the "high-crtc" support introduced in Linux 2.6.39 and libdrm 2.4.25 around May 2011. Signed-off-by: Mario Kleiner --- src/compositor-drm.c | 14 -- 1 file changed, 12 insertions(+), 2 delet