Re: [PATCH 02/11] Add libinput_device_has_key function

2014-11-07 Thread Peter Hutterer
On 8/11/2014 08:07 , Bill Spitzak wrote: Nevermind, it sounds like this is in *addition* to an api that lets you get the set of all keys on the device. So it is just a convenience for the (probably common) case where the caller is only testing for a particular key. if you're talking about libin

Re: [PATCH 02/11] Add libinput_device_has_key function

2014-11-07 Thread Bill Spitzak
Nevermind, it sounds like this is in *addition* to an api that lets you get the set of all keys on the device. So it is just a convenience for the (probably common) case where the caller is only testing for a particular key. ___ wayland-devel mailing

Re: [PATCH 02/11] Add libinput_device_has_key function

2014-11-06 Thread Peter Hutterer
On Thu, Nov 06, 2014 at 04:37:31PM +0100, Hans de Goede wrote: > In some cases the compositor will want to know which keys (buttons) a device > has. > > E.g. for scrolling we want the compositor to be able to set a button to change > a relative device (e.g. a trackball) into scroll mode, so that i

Re: [PATCH 02/11] Add libinput_device_has_key function

2014-11-06 Thread Peter Hutterer
On Thu, Nov 06, 2014 at 05:46:26PM -0800, Bill Spitzak wrote: > > > On 11/06/2014 05:17 PM, Peter Hutterer wrote: > >On Thu, Nov 06, 2014 at 11:41:20AM -0800, Bill Spitzak wrote: > >>It sure seems like an api that returned a list of all the keycodes the > >>device has would be better. It looks li

Re: [PATCH 02/11] Add libinput_device_has_key function

2014-11-06 Thread Bill Spitzak
On 11/06/2014 05:17 PM, Peter Hutterer wrote: On Thu, Nov 06, 2014 at 11:41:20AM -0800, Bill Spitzak wrote: It sure seems like an api that returned a list of all the keycodes the device has would be better. It looks like the client has to try every possible keycode to find out what exists with

Re: [PATCH 02/11] Add libinput_device_has_key function

2014-11-06 Thread Peter Hutterer
On Thu, Nov 06, 2014 at 11:41:20AM -0800, Bill Spitzak wrote: > It sure seems like an api that returned a list of all the keycodes the > device has would be better. It looks like the client has to try every > possible keycode to find out what exists with this. what is the caller (which is not a wl

Re: [PATCH 02/11] Add libinput_device_has_key function

2014-11-06 Thread Bill Spitzak
It sure seems like an api that returned a list of all the keycodes the device has would be better. It looks like the client has to try every possible keycode to find out what exists with this. Also there should be some unification between how these things and keyboards work. On 11/06/2014 07

[PATCH 02/11] Add libinput_device_has_key function

2014-11-06 Thread Hans de Goede
In some cases the compositor will want to know which keys (buttons) a device has. E.g. for scrolling we want the compositor to be able to set a button to change a relative device (e.g. a trackball) into scroll mode, so that it sends scroll-axis events instead of pointer motion events. In order fo