Re: [PATCH 0/3] Introduce shm pool helper functions

2012-08-09 Thread Kristian Høgsberg
On Tue, Aug 07, 2012 at 02:43:35PM +0300, Ander Conselvan de Oliveira wrote: > On 08/04/2012 04:22 PM, Andre Heider wrote: > >This set adds a couple of helper function to wayland-client to handle > >shm pools. > > > >Motivation: I noticed the amount of code duplication on client side. > >On top of

Re: [PATCH 0/3] Introduce shm pool helper functions

2012-08-07 Thread Andre Heider
On Tue, Aug 7, 2012 at 1:43 PM, Ander Conselvan de Oliveira wrote: > I think this could be called wl_shm_mapping and we get rid of the unmap > parameter to wl_shm_pool_helper_destroy(). In terms of a public API I think > it is bad idea to let the user leak the mapping. In simple-shm.c, > simple-to

Re: [PATCH 0/3] Introduce shm pool helper functions

2012-08-07 Thread Ander Conselvan de Oliveira
On 08/04/2012 04:22 PM, Andre Heider wrote: This set adds a couple of helper function to wayland-client to handle shm pools. Motivation: I noticed the amount of code duplication on client side. On top of that, wayland already maintains this platform independent. I'm not happy with the names of

[PATCH 0/3] Introduce shm pool helper functions

2012-08-04 Thread Andre Heider
This set adds a couple of helper function to wayland-client to handle shm pools. Motivation: I noticed the amount of code duplication on client side. On top of that, wayland already maintains this platform independent. I'm not happy with the names of the functions, and the API needs a few more th