Re: [PATCH] xdg-shell: update shsurf->output when maximizing

2014-09-10 Thread Pekka Paalanen
On Mon, 8 Sep 2014 12:34:20 +0200 Marek Chalupa wrote: > shsurf->output is the output that user expects the shell surface > is on. When maximizing, we don't have any explicit setting of the output > like in the case of fullscreening, so set the output to the one that > the surface is currently o

Re: [PATCH] xdg-shell: update shsurf->output when maximizing

2014-09-09 Thread Bill Spitzak
On 09/08/2014 11:15 PM, Marek Chalupa wrote: Each surface has assigned output it is currently mapped on (so it can be NULL). This surface->output is set by weston_surface_assign_output which is called by weston_view_assign_output (and that by weston_surface_update_transform) or by surface_unmap.

Re: [PATCH] xdg-shell: update shsurf->output when maximizing

2014-09-08 Thread Marek Chalupa
Hi, On 8 September 2014 20:08, Bill Spitzak wrote: > I'm probably being stupid, but I still can't figure out how it chooses the > output for a NON-maximized surface. I would think that should use exactly > the same algorithm as maximized does here? > > Each surface has assigned output it is curr

Re: [PATCH] xdg-shell: update shsurf->output when maximizing

2014-09-08 Thread Bill Spitzak
I'm probably being stupid, but I still can't figure out how it chooses the output for a NON-maximized surface. I would think that should use exactly the same algorithm as maximized does here? On 09/08/2014 03:34 AM, Marek Chalupa wrote: shsurf->output is the output that user expects the shell

[PATCH] xdg-shell: update shsurf->output when maximizing

2014-09-08 Thread Marek Chalupa
shsurf->output is the output that user expects the shell surface is on. When maximizing, we don't have any explicit setting of the output like in the case of fullscreening, so set the output to the one that the surface is currently on. In the case that the surface is not mapped yet, (if it ever hap