Re: [PATCH] xdg-shell: Align surface life-time rules with that of wl_shell

2014-08-27 Thread Pekka Paalanen
On Wed, 27 Aug 2014 13:43:13 +0200 Sjoerd Simons wrote: > On Sun, 2014-08-03 at 10:39 +0300, Pekka Paalanen wrote: > > As for wl_surface re-use after destroying a role, I have found that > > resetting a role to allow re-use is much easier and cleaner than > > not to, in Weston code. That's why I

Re: [PATCH] xdg-shell: Align surface life-time rules with that of wl_shell

2014-08-27 Thread Sjoerd Simons
On Sun, 2014-08-03 at 10:39 +0300, Pekka Paalanen wrote: > On Mon, 21 Jul 2014 13:23:23 -0700 > Jason Ekstrand wrote: > > > I think the way it's handled in subsurfaces allows you to create a > > subsurface from a surface, delete the surface, and then re-use the surface > > as something else. If

Re: [PATCH] xdg-shell: Align surface life-time rules with that of wl_shell

2014-08-03 Thread Pekka Paalanen
On Mon, 21 Jul 2014 13:23:23 -0700 Jason Ekstrand wrote: > I think the way it's handled in subsurfaces allows you to create a > subsurface from a surface, delete the surface, and then re-use the surface > as something else. If I recall correctly, weston allows a fair amount of > surface re-use r

Re: [PATCH] xdg-shell: Align surface life-time rules with that of wl_shell

2014-07-21 Thread Jason Ekstrand
I think the way it's handled in subsurfaces allows you to create a subsurface from a surface, delete the surface, and then re-use the surface as something else. If I recall correctly, weston allows a fair amount of surface re-use right now. That said, I'm not opposed to not allowing it for xdg su

Re: [PATCH] xdg-shell: Align surface life-time rules with that of wl_shell

2014-07-21 Thread Jasper St. Pierre
Note that I fixed GTK+ to always create a new wl_surface and never reuse it. I don't think it makes any sense to keep the wl_surface around in the background. I certainly don't think it ever makes sense to destroy the xdg_surface and then make it into an xdg_popup or similar. The semantics of "onc

Re: [PATCH] xdg-shell: Align surface life-time rules with that of wl_shell

2014-07-21 Thread Sjoerd Simons
On Mon, 2014-07-21 at 10:03 -0700, Jason Ekstrand wrote: > On Mon, Jul 21, 2014 at 1:47 AM, Sjoerd Simons < > sjoerd.sim...@collabora.co.uk> wrote: > > > Remove the explicit destroy method from xdg_surface and xdg_popup as > > neither of them can be re-created after being destroyed. As a results a

Re: [PATCH] xdg-shell: Align surface life-time rules with that of wl_shell

2014-07-21 Thread Jason Ekstrand
On Mon, Jul 21, 2014 at 1:47 AM, Sjoerd Simons < sjoerd.sim...@collabora.co.uk> wrote: > Remove the explicit destroy method from xdg_surface and xdg_popup as > neither of them can be re-created after being destroyed. As a results a > wl_surface gets into an odd sort of odd limbo state after a > xd

[PATCH] xdg-shell: Align surface life-time rules with that of wl_shell

2014-07-21 Thread Sjoerd Simons
Remove the explicit destroy method from xdg_surface and xdg_popup as neither of them can be re-created after being destroyed. As a results a wl_surface gets into an odd sort of odd limbo state after a xdg_{surface,popup}.destroy call where it not only no longer has an xdg_{surface,popup} associated