Re: [PATCH] wl_shell: Add surface state changed event

2013-05-19 Thread Pekka Paalanen
On Wed, 15 May 2013 11:37:19 -0700 Mikko Levonmaa wrote: > On Wed, May 15, 2013 at 12:12:43PM -0500, Jason Ekstrand wrote: > > On Wed, May 15, 2013 at 9:39 AM, Mikko Levonmaa > > wrote: > > > > This allows the shell to inform the surface that it has changed > > state, current supported

Re: [PATCH] wl_shell: Add surface state changed event

2013-05-15 Thread Mikko Levonmaa
On Wed, May 15, 2013 at 12:37:48PM -0700, Bill Spitzak wrote: > Mikko Levonmaa wrote: > > >+ > >+ > >+The compositor or the user has taken action that has resulted in > >+this surface to change state. > >+ > >+ > >+ > > > > "changed" is very misleading. If the

Re: [PATCH] wl_shell: Add surface state changed event

2013-05-15 Thread Mikko Levonmaa
On Wed, May 15, 2013 at 01:57:10PM -0500, Jason Ekstrand wrote: > On Wed, May 15, 2013 at 1:37 PM, Mikko Levonmaa > wrote: > > On Wed, May 15, 2013 at 12:12:43PM -0500, Jason Ekstrand wrote: > > On Wed, May 15, 2013 at 9:39 AM, Mikko Levonmaa > > > > wrote: > > > > T

Re: [PATCH] wl_shell: Add surface state changed event

2013-05-15 Thread Bill Spitzak
Mikko Levonmaa wrote: + + +The compositor or the user has taken action that has resulted in +this surface to change state. + + + "changed" is very misleading. If the client does not do anything, the state has not changed. This is a request from the shell

Re: [PATCH] wl_shell: Add surface state changed event

2013-05-15 Thread Bill Spitzak
Alexander Preisinger wrote: + + + + + Are these supposed to be flags? Like that it can send multiple states in one request? I think the client should keep track of the previous state itself and the compositor only sends the state he wants the c

Re: [PATCH] wl_shell: Add surface state changed event

2013-05-15 Thread Jason Ekstrand
On Wed, May 15, 2013 at 1:37 PM, Mikko Levonmaa wrote: > On Wed, May 15, 2013 at 12:12:43PM -0500, Jason Ekstrand wrote: > > On Wed, May 15, 2013 at 9:39 AM, Mikko Levonmaa < > mikko.levon...@gmail.com> > > wrote: > > > > This allows the shell to inform the surface that it has changed > >

Re: [PATCH] wl_shell: Add surface state changed event

2013-05-15 Thread Mikko Levonmaa
On Wed, May 15, 2013 at 12:12:43PM -0500, Jason Ekstrand wrote: > On Wed, May 15, 2013 at 9:39 AM, Mikko Levonmaa > wrote: > > This allows the shell to inform the surface that it has changed > state, current supported states are default, minimized, maximized > and fullscreen. The shel

Re: [PATCH] wl_shell: Add surface state changed event

2013-05-15 Thread Jason Ekstrand
On Wed, May 15, 2013 at 9:39 AM, Mikko Levonmaa wrote: > This allows the shell to inform the surface that it has changed > state, current supported states are default, minimized, maximized > and fullscreen. The shell implementation is free to interpret the > meaning for the state, i.e. the minimiz

Re: [PATCH] wl_shell: Add surface state changed event

2013-05-15 Thread Alexander Preisinger
Nice! 2013/5/15 Mikko Levonmaa > This allows the shell to inform the surface that it has changed > state, current supported states are default, minimized, maximized > and fullscreen. The shell implementation is free to interpret the > meaning for the state, i.e. the minimized might not always

[PATCH] wl_shell: Add surface state changed event

2013-05-15 Thread Mikko Levonmaa
This allows the shell to inform the surface that it has changed state, current supported states are default, minimized, maximized and fullscreen. The shell implementation is free to interpret the meaning for the state, i.e. the minimized might not always mean that the surface is fully hidden for ex