Re: [PATCH] wl_resource: Add version field and getter/setter

2013-05-24 Thread Alexander Larsson
On tor, 2013-05-23 at 15:54 -0500, Jason Ekstrand wrote: > > > wl_signal_get might be better here. It's more robust in (somewhat > odd) case the user code decides to manually put a listener at the > beginning. It's also more readable and almost just as fast (different > by an if). Yeah, sure,

Re: [PATCH] wl_resource: Add version field and getter/setter

2013-05-23 Thread Jason Ekstrand
Alex, Really, this looks like a pretty clean solution. I've spent a fair amount of time banging around trying to extend wl_resource and this is better than anything I ever came up with. I only have the one comment (already mentioned on IRC but repeated here for the sake of the list). On Thu, May

[PATCH] wl_resource: Add version field and getter/setter

2013-05-23 Thread alexl
From: Alexander Larsson We create a private structure for extra data and store it in a destroy notifier. In this way we can store the version in a backwards compatible way. This lets us track the actual version of a resource which is generally the min of what the client requested and what the se