Re: [PATCH] wayland-util: merge {client, server}_entries in wl_map into one variable

2013-09-09 Thread Bill Spitzak
Jason Ekstrand wrote: Chang, This patch is, unfortunately, incorrect. Yes, we have a side field that tells us which side the wl_map was allocated for. However, we use one wl_map to store both client-side and server-side IDs. The side field, together with the WL_SERVER_ID_START, allow us t

Re: [PATCH] wayland-util: merge {client, server}_entries in wl_map into one variable

2013-09-09 Thread Jason Ekstrand
Chang, This patch is, unfortunately, incorrect. Yes, we have a side field that tells us which side the wl_map was allocated for. However, we use one wl_map to store both client-side and server-side IDs. The side field, together with the WL_SERVER_ID_START, allow us to keep everything straight in

[PATCH] wayland-util: merge {client, server}_entries in wl_map into one variable

2013-09-07 Thread Chang Liu
Since a wl_map can be either client side or server side (but not both) and we have the side field to indicate this, we can merge client_entries and server_entries into one variable to reduce clutter. --- src/wayland-private.h | 3 +-- src/wayland-util.c| 43 +++