Re: [PATCH] version.h: Add version check macro

2013-10-02 Thread Marc Chalain
Hello, I agree with you Bill Otherwise it's impossible to update plugins when the API will change. Marc. 2013/9/30 Bill Spitzak > On 09/29/2013 02:56 PM, Kristian Høgsberg wrote: > > No, we don't guarantee plugin API compatiblity from 1.2 to 1.3. We >> may remove functions, structure fields,

Re: [PATCH] version.h: Add version check macro

2013-09-30 Thread Bill Spitzak
On 09/29/2013 02:56 PM, Kristian Høgsberg wrote: No, we don't guarantee plugin API compatiblity from 1.2 to 1.3. We may remove functions, structure fields, or change how existing functions work between 1.x versions. There is no guarantee your plugin will work or even compile with 1.3 even if i

Re: [PATCH] version.h: Add version check macro

2013-09-29 Thread Kristian Høgsberg
On Sun, Sep 29, 2013 at 11:57:12AM +0200, Pier Luigi wrote: > 2013/9/24 Bill Spitzak : > > > > > > Kristian Høgsberg wrote: > >> > >> On Tue, Sep 24, 2013 at 12:54 AM, Marc Chalain > >> wrote: > >> > >>> > >>> But the WESTON_VERSION_AT_LEAST macro is wrong. You can check only the > >>> minor > >>>

Re: [PATCH] version.h: Add version check macro

2013-09-29 Thread Pier Luigi
2013/9/24 Bill Spitzak : > > > Kristian Høgsberg wrote: >> >> On Tue, Sep 24, 2013 at 12:54 AM, Marc Chalain >> wrote: >> >>> >>> But the WESTON_VERSION_AT_LEAST macro is wrong. You can check only the >>> minor >>> and not the rest of the version. >>> >> >> >> No, we don't guarantee plugin API sta

Re: [PATCH] version.h: Add version check macro

2013-09-24 Thread Bill Spitzak
Kristian Høgsberg wrote: On Tue, Sep 24, 2013 at 12:54 AM, Marc Chalain wrote: But the WESTON_VERSION_AT_LEAST macro is wrong. You can check only the minor and not the rest of the version. No, we don't guarantee plugin API stability between x.y releases, only micro releases 1.2.x ma

Re: [PATCH] version.h: Add version check macro

2013-09-24 Thread Kristian Høgsberg
On Tue, Sep 24, 2013 at 12:54 AM, Marc Chalain wrote: > But the WESTON_VERSION_AT_LEAST macro is wrong. You can check only the minor > and not the rest of the version. No, we don't guarantee plugin API stability between x.y releases, only micro releases 1.2.x maintain that interface. Something d

Re: [PATCH] version.h: Add version check macro

2013-09-24 Thread Marc Chalain
But the WESTON_VERSION_AT_LEAST macro is wrong. You can check only the minor and not the rest of the version. 2013/9/23 Kristian Høgsberg > On Mon, Sep 23, 2013 at 10:39:08AM -0700, Kristian Høgsberg wrote: > > On Mon, Sep 23, 2013 at 07:26:03AM +0200, Pier Luigi Fiorini wrote: > > > Make it ea

Re: [PATCH] version.h: Add version check macro

2013-09-23 Thread Kristian Høgsberg
On Mon, Sep 23, 2013 at 07:26:03AM +0200, Pier Luigi Fiorini wrote: > Make it easier to check for a Weston version. Ah yup, I lost track of that one. Thanks, committed. Kristian > --- > src/version.h.in | 12 +++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/src/

Re: [PATCH] version.h: Add version check macro

2013-09-23 Thread Kristian Høgsberg
On Mon, Sep 23, 2013 at 10:39:08AM -0700, Kristian Høgsberg wrote: > On Mon, Sep 23, 2013 at 07:26:03AM +0200, Pier Luigi Fiorini wrote: > > Make it easier to check for a Weston version. > > Ah yup, I lost track of that one. Thanks, committed. > > Kristian > > > --- > > src/version.h.in | 12 +

Re: [PATCH] version.h: Add version check macro

2013-09-23 Thread Marc Chalain
sure this comment is wrong prefer +Can be used like #if (WESTON_VERSION_AT_LEAST(1, 2, 0)) And in this case you can not build the feature for weston 1.3.0 while you want to a version up of 1.3.0 I think you have to change completly your macro. Look at your WESTON_VERSION macro this one can he

Re: [PATCH] version.h: Add version check macro

2013-09-23 Thread Bill Spitzak
On 09/22/2013 10:26 PM, Pier Luigi Fiorini wrote: Make it easier to check for a Weston version. +/* +Can be used like #if (WESTON_VERSION >= WESTON_VERSION_AT_LEAST(1, 2, 0)) I think this comment is wrong. +*/ +#define WESTON_VERSION_AT_LEAST(major, minor, micro) \ +(WESTON_VER

[PATCH] version.h: Add version check macro

2013-09-22 Thread Pier Luigi Fiorini
Make it easier to check for a Weston version. --- src/version.h.in | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/version.h.in b/src/version.h.in index f573328..d45172c 100644 --- a/src/version.h.in +++ b/src/version.h.in @@ -26,6 +26,16 @@ #define WESTON_VER

Re: [PATCH] version.h: Add version check macro

2013-08-27 Thread Pier Luigi
2013/8/27 Kristian Høgsberg > On Wed, Aug 21, 2013 at 08:17:05AM +0200, Pier Luigi Fiorini wrote: > > Make it easier to check for a Weston version. > > --- > > src/version.h.in | 9 - > > 1 file changed, 8 insertions(+), 1 deletion(-) > > > > diff --git a/src/version.h.in b/src/version.h

Re: [PATCH] version.h: Add version check macro

2013-08-26 Thread Kristian Høgsberg
On Wed, Aug 21, 2013 at 08:17:05AM +0200, Pier Luigi Fiorini wrote: > Make it easier to check for a Weston version. > --- > src/version.h.in | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/src/version.h.in b/src/version.h.in > index f573328..12ad6e4 100644 > --- a

[PATCH] version.h: Add version check macro

2013-08-20 Thread Pier Luigi Fiorini
Make it easier to check for a Weston version. --- src/version.h.in | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/version.h.in b/src/version.h.in index f573328..12ad6e4 100644 --- a/src/version.h.in +++ b/src/version.h.in @@ -26,6 +26,13 @@ #define WESTON_VERSION_