Re: [PATCH] update protocol specification to match wire protocol

2014-09-05 Thread Pekka Paalanen
On Fri, 5 Sep 2014 19:18:44 -0500 Paul Sbarra wrote: > On Fri, Sep 5, 2014 at 7:51 AM, Pekka Paalanen wrote: > > > > I took a look at both of them, you are making an incompatible change to > > wayland.xml, and breaking the generator. > > > > Essentially you are breaking the unwritten specifica

Re: [PATCH] update protocol specification to match wire protocol

2014-09-05 Thread Paul Sbarra
On Fri, Sep 5, 2014 at 7:51 AM, Pekka Paalanen wrote: > I took a look at both of them, you are making an incompatible change to > wayland.xml, and breaking the generator. > > Essentially you are breaking the unwritten specification on how the XML > files are processed into wire format and langua

Re: [PATCH] update protocol specification to match wire protocol

2014-09-05 Thread Daniel Stone
Hi, On 5 September 2014 13:51, Pekka Paalanen wrote: > Essentially you are breaking the unwritten specification on how the XML > files are processed into wire format and language bindings. > Wayland-scanner is not the only generator, and wayland.xml is not the > only XML file in existence. > > [

Re: [PATCH] update protocol specification to match wire protocol

2014-09-05 Thread Pekka Paalanen
On Fri, 5 Sep 2014 07:05:55 -0500 Paul Sbarra wrote: > On Thu, Sep 4, 2014 at 10:33 PM, Boyan Ding wrote: > > > Hi, > > > > Actually it is not a hack, it is a very well-defined behavior (though > > not clearly documented at present). We'll update the documentation to > > reflect that. The mecha

Re: [PATCH] update protocol specification to match wire protocol

2014-09-05 Thread Paul Sbarra
On Thu, Sep 4, 2014 at 10:33 PM, Boyan Ding wrote: > Hi, > > Actually it is not a hack, it is a very well-defined behavior (though > not clearly documented at present). We'll update the documentation to > reflect that. The mechanic of creating objects undergoes some change as > Pekka mentioned [1

Re: [PATCH] update protocol specification to match wire protocol

2014-09-05 Thread Pekka Paalanen
On Thu, 4 Sep 2014 22:05:00 -0500 Paul Sbarra wrote: > I agree it's a hack, but it's also one that invalidates the protocol > specification. If the wire protocol requires four arguments then the > specification needs to reflect that. Currently if another tool or protocol > implementation (like

Re: [PATCH] update protocol specification to match wire protocol

2014-09-04 Thread Boyan Ding
Hi, Actually it is not a hack, it is a very well-defined behavior (though not clearly documented at present). We'll update the documentation to reflect that. The mechanic of creating objects undergoes some change as Pekka mentioned [1] and now it's been stable and won't change anymore (I have to i

[PATCH] update protocol specification to match wire protocol

2014-09-04 Thread Paul Sbarra
I agree it's a hack, but it's also one that invalidates the protocol specification. If the wire protocol requires four arguments then the specification needs to reflect that. Currently if another tool or protocol implementation (like the gowl example previously mentioned) attempts to generate cod