Re: [PATCH] shell: fix set_transient

2011-12-09 Thread Pekka Paalanen
> On Thu, 8 Dec 2011 13:05:42 -0500 > Kristian Høgsberg wrote: > > > On Thu, Dec 8, 2011 at 10:08 AM, Pekka Paalanen > > wrote: > > > On Thu, 08 Dec 2011 17:04:47 +0200 > > > Tiago Vignatti wrote: > ... > > >> but I thought you'd implement the explicit cast scheme.. meh. > > > > > > Sorry, not

Re: [PATCH] shell: fix set_transient

2011-12-08 Thread Pekka Paalanen
On Thu, 8 Dec 2011 13:05:42 -0500 Kristian Høgsberg wrote: > On Thu, Dec 8, 2011 at 10:08 AM, Pekka Paalanen > wrote: > > On Thu, 08 Dec 2011 17:04:47 +0200 > > Tiago Vignatti wrote: ... > >> but I thought you'd implement the explicit cast scheme.. meh. > > > > Sorry, not today :-D > > > > I'll

Re: [PATCH] shell: fix set_transient

2011-12-08 Thread Kristian Høgsberg
On Thu, Dec 8, 2011 at 10:08 AM, Pekka Paalanen wrote: > On Thu, 08 Dec 2011 17:04:47 +0200 > Tiago Vignatti wrote: > >> On 12/08/2011 04:42 PM, Pekka Paalanen wrote: >> > In the wl_shell_surface migration, I forgot to correct one cast in >> > shell_surface_set_transient(). 'parent_resource' is n

Re: [PATCH] shell: fix set_transient

2011-12-08 Thread Kristian Høgsberg
On Thu, Dec 8, 2011 at 9:42 AM, Pekka Paalanen wrote: > In the wl_shell_surface migration, I forgot to correct one cast in > shell_surface_set_transient(). 'parent_resource' is not a (struct > wlsc_surface *) but (struct shell_surface *). > > This bug corrupts a wlsc_surface::output field, which l

Re: [PATCH] shell: fix set_transient

2011-12-08 Thread Pekka Paalanen
On Thu, 08 Dec 2011 17:04:47 +0200 Tiago Vignatti wrote: > On 12/08/2011 04:42 PM, Pekka Paalanen wrote: > > In the wl_shell_surface migration, I forgot to correct one cast in > > shell_surface_set_transient(). 'parent_resource' is not a (struct > > wlsc_surface *) but (struct shell_surface *). >

Re: [PATCH] shell: fix set_transient

2011-12-08 Thread Tiago Vignatti
On 12/08/2011 04:42 PM, Pekka Paalanen wrote: In the wl_shell_surface migration, I forgot to correct one cast in shell_surface_set_transient(). 'parent_resource' is not a (struct wlsc_surface *) but (struct shell_surface *). This bug corrupts a wlsc_surface::output field, which later (in my expe

[PATCH] shell: fix set_transient

2011-12-08 Thread Pekka Paalanen
In the wl_shell_surface migration, I forgot to correct one cast in shell_surface_set_transient(). 'parent_resource' is not a (struct wlsc_surface *) but (struct shell_surface *). This bug corrupts a wlsc_surface::output field, which later (in my experiments) leads to a segmentation fault in surfac