Re: [PATCH] shell: Implement wl_shell_surface_set_notification

2013-01-04 Thread Pekka Paalanen
On Wed, 26 Dec 2012 19:00:25 +0100 Quentin Glidic wrote: > --- > src/shell.c | 141 > ++-- > weston.ini | 5 +++ > 2 files changed, 143 insertions(+), 3 deletions(-) Apart from some style issues, this patch looks a lot like what I expe

Re: [PATCH] shell: Implement wl_shell_surface_set_notification

2013-01-04 Thread Pekka Paalanen
On Sat, 29 Dec 2012 17:55:05 -0800 Bill Spitzak wrote: > Oh sh.. it is a "layer". > > > + struct weston_layer notification_layer; > > This is not good. Please figure out a way so that clients can control > the window stacking without having to copy every idea that a client > needs into the

Re: [PATCH] shell: Implement wl_shell_surface_set_notification

2012-12-30 Thread Bill Spitzak
Gregory Merchan wrote: This is also important for getting drag-and-drop working correctly. I tried the weston dnd demo recently and was saddened to see it does not work correctly (i.e. according to the expectations of most computer users): the ButtonDown immediately set focus and raised the wind

Re: [PATCH] shell: Implement wl_shell_surface_set_notification

2012-12-29 Thread Gregory Merchan
On Sat, Dec 29, 2012 at 7:55 PM, Bill Spitzak wrote: > Oh sh.. it is a "layer". > >> + struct weston_layer notification_layer; > > This is not good. Please figure out a way so that clients can control the > window stacking without having to copy every idea that a client needs into > the compos

Re: [PATCH] shell: Implement wl_shell_surface_set_notification

2012-12-29 Thread Bill Spitzak
Oh sh.. it is a "layer". > + struct weston_layer notification_layer; This is not good. Please figure out a way so that clients can control the window stacking without having to copy every idea that a client needs into the compositor. Recommendation: Each surface has a "parent", if it is no

[PATCH] shell: Implement wl_shell_surface_set_notification

2012-12-26 Thread Quentin Glidic
--- src/shell.c | 141 ++-- weston.ini | 5 +++ 2 files changed, 143 insertions(+), 3 deletions(-) diff --git a/src/shell.c b/src/shell.c index aa1c7c1..968843a 100644 --- a/src/shell.c +++ b/src/shell.c @@ -41,6 +41,8 @@ #define DEFAULT