Re: [PATCH] shell: Check more thoroughly for undefined surface resource

2015-09-15 Thread Daniel Stone
Hi, On 14 September 2015 at 20:31, Bryce Harrington wrote: > diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c > index ecc42c5..0b91ce6 100644 > --- a/desktop-shell/shell.c > +++ b/desktop-shell/shell.c > @@ -2148,7 +2148,7 @@ xdg_ping_timeout_handler(void *data) >

Re: [PATCH] shell: Check more thoroughly for undefined surface resource

2015-09-14 Thread Bryce Harrington
On Tue, Sep 15, 2015 at 08:31:56AM +0800, Jonas Ådahl wrote: > On Mon, Sep 14, 2015 at 01:15:47PM -0700, Bryce Harrington wrote: > > On Mon, Sep 14, 2015 at 12:31:10PM -0700, Bryce Harrington wrote: > > > The surface can have an undefined resource in certain situations (such > > > as with xwayland)

Re: [PATCH] shell: Check more thoroughly for undefined surface resource

2015-09-14 Thread Jonas Ådahl
On Mon, Sep 14, 2015 at 01:15:47PM -0700, Bryce Harrington wrote: > On Mon, Sep 14, 2015 at 12:31:10PM -0700, Bryce Harrington wrote: > > The surface can have an undefined resource in certain situations (such > > as with xwayland). So, since NULL is a valid state for this parameter, > > and since

Re: [PATCH] shell: Check more thoroughly for undefined surface resource

2015-09-14 Thread Bryce Harrington
On Mon, Sep 14, 2015 at 12:31:10PM -0700, Bryce Harrington wrote: > The surface can have an undefined resource in certain situations (such > as with xwayland). So, since NULL is a valid state for this parameter, > and since the wl_resource_*, etc. calls require their parameters to be > non-NULL, m

[PATCH] shell: Check more thoroughly for undefined surface resource

2015-09-14 Thread Bryce Harrington
The surface can have an undefined resource in certain situations (such as with xwayland). So, since NULL is a valid state for this parameter, and since the wl_resource_*, etc. calls require their parameters to be non-NULL, make a practice of always checking the surface resource before making wayla