Re: [PATCH] screenshooter: Properly handle multiple outputs.

2012-04-06 Thread Rob Bradford
Hi, > -       for (i = 0; i < buffer->height; i++) { > -               memcpy(d, s, stride); > -               d += stride; > -               s -= stride; > +       for (i = 0; i < output->current->height; i++) { > +               memcpy(d + output->x * 4, s, output_stride); > +               d +=

Re: [PATCH] screenshooter: Properly handle multiple outputs.

2012-04-05 Thread Andreas Ericsson
On 04/05/2012 12:08 PM, Jonas Ådahl wrote: > On Thu, Apr 5, 2012 at 11:42 AM, Andreas Ericsson wrote: >> On 04/04/2012 02:37 PM, Kristian Hoegsberg wrote: >>> On Wed, Apr 04, 2012 at 01:51:08AM -0600, Scott Moreau wrote: --- >>> -write_png(output_width, output_height, data); >>>

Re: [PATCH] screenshooter: Properly handle multiple outputs.

2012-04-05 Thread Jonas Ådahl
On Thu, Apr 5, 2012 at 11:42 AM, Andreas Ericsson wrote: > On 04/04/2012 02:37 PM, Kristian Hoegsberg wrote: >> On Wed, Apr 04, 2012 at 01:51:08AM -0600, Scott Moreau wrote: >>> --- >> >>> >>> -    write_png(output_width, output_height, data); >>> +    write_png(ss_area_width, ss_area_height, data

Re: [PATCH] screenshooter: Properly handle multiple outputs.

2012-04-05 Thread Andreas Ericsson
On 04/04/2012 02:37 PM, Kristian Hoegsberg wrote: > On Wed, Apr 04, 2012 at 01:51:08AM -0600, Scott Moreau wrote: >> --- > >> >> -write_png(output_width, output_height, data); >> +write_png(ss_area_width, ss_area_height, data); >> + >> +wl_list_for_each(ss_output,&output_list, link) {

Re: [PATCH] screenshooter: Properly handle multiple outputs.

2012-04-04 Thread Scott Moreau
> > > >> > } else if (strcmp(interface, "wl_shm") == 0) { >> > shm = wl_display_bind(display, id, &wl_shm_interface); >> > } else if (strcmp(interface, "screenshooter") == 0) { >> > @@ -144,6 +171,8 @@ int main(int argc, char *argv[]) >> > struct wl_display *display;

Re: [PATCH] screenshooter: Properly handle multiple outputs.

2012-04-04 Thread Scott Moreau
On Wed, Apr 4, 2012 at 6:37 AM, Kristian Hoegsberg wrote: > On Wed, Apr 04, 2012 at 01:51:08AM -0600, Scott Moreau wrote: > > --- > > Looks pretty good. There are a few small comments below, but the > overall approach is good. > > > Tested: Side-by-side and stacked output configurations, in x11 a

Re: [PATCH] screenshooter: Properly handle multiple outputs.

2012-04-04 Thread Kristian Hoegsberg
On Wed, Apr 04, 2012 at 01:51:08AM -0600, Scott Moreau wrote: > --- Looks pretty good. There are a few small comments below, but the overall approach is good. > Tested: Side-by-side and stacked output configurations, in x11 and drm. > Shooting under drm glitches sometimes and either or both outp

[PATCH] screenshooter: Properly handle multiple outputs.

2012-04-04 Thread Scott Moreau
--- Tested: Side-by-side and stacked output configurations, in x11 and drm. Shooting under drm glitches sometimes and either or both output data contains garbage. clients/screenshot.c | 69 -- src/compositor-drm.c | 14 + src/compos