Re: [PATCH] scanner: Close input resource when done to prevent leak

2015-07-01 Thread Marek Chalupa
To be up to good programming practices we should close the input even on the error paths on lines 1381, 1392 and 1400 (it can be stdin, but on exit it doesn't matter). Scanner is sooo leaky, that pedantically closing read-only input file on every error path may seem a little bit useless, but it is

[PATCH] scanner: Close input resource when done to prevent leak

2015-06-19 Thread Bryce Harrington
Addresses this error reported by Denis Denisov: [src/scanner.c:1415]: (error) Resource leak: input Signed-off-by: Bryce Harrington --- src/scanner.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/scanner.c b/src/scanner.c index 7d8cfb9..2843d85 100644 --- a/src/scanner.c +++ b/src/sc