Re: [PATCH] rpi: Support opaque regions

2013-12-02 Thread Bill Spitzak
Bryce W. Harrington wrote: + ret = rpir_surface_set_opaque_rect(surface, update); + if (ret < 0) Other code here is just checking "if (ret)". rpir_surface_set_opaque_rect() only appears to return 0 or -1, so might be more consistent with existing code to do the same. Or do you i

Re: [PATCH] rpi: Support opaque regions

2013-12-02 Thread Bryce W. Harrington
On Mon, Dec 02, 2013 at 05:18:58PM +0100, Tomeu Vizoso wrote: > This is needed for XWayland surfaces with alpha channel, as X will be > sending crap in there that should be discarded. > > This is currently done with a copy in the compositor, while we wait for > support in the VideoCore side. > ---

Re: [PATCH] rpi: Support opaque regions

2013-12-02 Thread Kristian Høgsberg
On Mon, Dec 02, 2013 at 05:18:58PM +0100, Tomeu Vizoso wrote: > This is needed for XWayland surfaces with alpha channel, as X will be > sending crap in there that should be discarded. > > This is currently done with a copy in the compositor, while we wait for > support in the VideoCore side. Look

[PATCH] rpi: Support opaque regions

2013-12-02 Thread Tomeu Vizoso
This is needed for XWayland surfaces with alpha channel, as X will be sending crap in there that should be discarded. This is currently done with a copy in the compositor, while we wait for support in the VideoCore side. --- src/compositor-rpi.c | 3 ++ src/compositor.c | 2 + src/rpi-bcm