Re: [PATCH] protocol: Change wl_surface.damage to be in buffer coordinates.

2014-05-02 Thread Jason Ekstrand
Bump. I also just added this to the bug-tracker: https://bugs.freedesktop.org/show_bug.cgi?id=78190 --Jason Ekstrand On Thu, Feb 27, 2014 at 12:37 AM, Pekka Paalanen wrote: > On Wed, 26 Feb 2014 21:13:16 -0600 > Jason Ekstrand wrote: > > > Technically, wl_surface.damage is supposed to be cal

Re: [PATCH] protocol: Change wl_surface.damage to be in buffer coordinates.

2014-02-26 Thread Pekka Paalanen
On Wed, 26 Feb 2014 21:13:16 -0600 Jason Ekstrand wrote: > Technically, wl_surface.damage is supposed to be called between > wl_surface.attach and wl_surface.commit. However, I think Weston is fairly > forgiving on this point and it might work. The order between damage, attach, etc. must be irr

Re: [PATCH] protocol: Change wl_surface.damage to be in buffer coordinates.

2014-02-26 Thread Jasper St. Pierre
For what it's worth, mutter treats wl_surface.damage coordinates as buffer coordinates right now. So we're broken for buffer transformations, but doing the intuitive correct thing. Having them be in buffer coordinates is the intuitive thing to do here, and I think it's what most implementers do ri

Re: [PATCH] protocol: Change wl_surface.damage to be in buffer coordinates.

2014-02-26 Thread Jason Ekstrand
Hi All, I talked to Kristian in IRC about this today. It turns out that damage isn't an issue in the case where we have an integer buffer_scale or a transform that's a multiple of 180 degress. This is because, in these cases, the buffer size is at least as large as the surface size and damaging b

Re: [PATCH] protocol: Change wl_surface.damage to be in buffer coordinates.

2014-02-25 Thread Kristian Høgsberg
On Tue, Feb 25, 2014 at 8:13 AM, Jason Ekstrand wrote: > And I forgot reply-all again. This is why I shouldn't respond from my > phone. > > > On Tue, Feb 25, 2014 at 8:07 AM, Pekka Paalanen wrote: >> >> On Tue, 25 Feb 2014 07:44:24 -0600 >> Jason Ekstrand wrote: >> >> > I'll do a full reply lat

Re: [PATCH] protocol: Change wl_surface.damage to be in buffer coordinates.

2014-02-25 Thread Jason Ekstrand
And I forgot reply-all again. This is why I shouldn't respond from my phone. On Tue, Feb 25, 2014 at 8:07 AM, Pekka Paalanen wrote: > On Tue, 25 Feb 2014 07:44:24 -0600 > Jason Ekstrand wrote: > > > I'll do a full reply later, just a quick one now. > > On Feb 25, 2014 2:31 AM, "Pekka Paalanen

Re: [PATCH] protocol: Change wl_surface.damage to be in buffer coordinates.

2014-02-25 Thread Pekka Paalanen
On Mon, 24 Feb 2014 22:32:05 -0600 Jason Ekstrand wrote: > When buffer_transform and buffer_scale were first introduced, added, we > specified surface damage to be in surface coordinates. However, this does Don't forget wl_viewport. > not and will never work properly with EGL. Because the buf

[PATCH] protocol: Change wl_surface.damage to be in buffer coordinates.

2014-02-24 Thread Jason Ekstrand
When buffer_transform and buffer_scale were first introduced, added, we specified surface damage to be in surface coordinates. However, this does not and will never work properly with EGL. Because the buffer transform and scale are handled directly by the client and not passed through EGL, the EG