Re: [PATCH] option-parser: Don't read off the end of string options without an '='

2014-08-21 Thread Pekka Paalanen
On Thu, 21 Aug 2014 09:11:22 +1200 Robert Ancell wrote: > Bill's patch looks a lot more comprehensive, I'd use that one. Ok, thank you. - pq > On 21 August 2014 00:37, Pekka Paalanen wrote: > > > On Fri, 20 Jun 2014 15:23:59 +1200 > > Robert Ancell wrote: > > > > > I'm not sure if the expec

Re: [PATCH] option-parser: Don't read off the end of string options without an '='

2014-08-20 Thread Robert Ancell
Bill's patch looks a lot more comprehensive, I'd use that one. Thanks, --Robert On 21 August 2014 00:37, Pekka Paalanen wrote: > On Fri, 20 Jun 2014 15:23:59 +1200 > Robert Ancell wrote: > > > I'm not sure if the expected behaviour is for: > > $ weston --shell foo.so > > to work, if so the pa

Re: [PATCH] option-parser: Don't read off the end of string options without an '='

2014-08-20 Thread Pekka Paalanen
On Fri, 20 Jun 2014 15:23:59 +1200 Robert Ancell wrote: > I'm not sure if the expected behaviour is for: > $ weston --shell foo.so > to work, if so the patch can be modified. Ah, sorry for not noticing this patch in time. What do you think of Bill's series here: http://lists.freedesktop.org/arch

Re: [PATCH] option-parser: Don't read off the end of string options without an '='

2014-08-08 Thread Bill Spitzak
I posted fixes for this as well. Never heard anything. Will post them again to see. On 06/19/2014 08:22 PM, Robert Ancell wrote: On my system: $ weston --shell would use the first environment variable as the argument to --shell and $ weston --shell foo.so Would use foo.so as the argument and th

Re: [PATCH] option-parser: Don't read off the end of string options without an '='

2014-08-08 Thread Robert Ancell
I'm not sure if the expected behaviour is for: $ weston --shell foo.so to work, if so the patch can be modified. On 20 June 2014 15:22, Robert Ancell wrote: > On my system: > $ weston --shell > would use the first environment variable as the argument to --shell > and > $ weston --shell foo.so >

[PATCH] option-parser: Don't read off the end of string options without an '='

2014-08-08 Thread Robert Ancell
On my system: $ weston --shell would use the first environment variable as the argument to --shell and $ weston --shell foo.so Would use foo.so as the argument and then parse foo.so as a new option. --- shared/option-parser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/shar