Re: [PATCH] libinput-device: Remove unnecessary function call

2016-02-26 Thread Pekka Paalanen
On Mon, 22 Feb 2016 16:14:56 -0800 Bryce Harrington wrote: > On Mon, Feb 22, 2016 at 08:47:24AM -0500, Chris Michael wrote: > > When we handle keyboard key events, we already retrieve the key state > > at the top of this function, so there is no real need to call the same > > libinput function ag

Re: [PATCH] libinput-device: Remove unnecessary function call

2016-02-22 Thread Bryce Harrington
On Mon, Feb 22, 2016 at 08:47:24AM -0500, Chris Michael wrote: > When we handle keyboard key events, we already retrieve the key state > at the top of this function, so there is no real need to call the same > libinput function again as we can just reuse the 'key_state' variable > that we have abov

[PATCH] libinput-device: Remove unnecessary function call

2016-02-22 Thread Chris Michael
When we handle keyboard key events, we already retrieve the key state at the top of this function, so there is no real need to call the same libinput function again as we can just reuse the 'key_state' variable that we have above. Signed-off-by: Chris Michael --- src/libinput-device.c | 3 +-- 1

Re: [PATCH] libinput-device: Remove unnecessary function call

2016-02-22 Thread Pekka Paalanen
On Mon, 22 Feb 2016 08:22:11 -0500 Chris Michael wrote: > When we handle keyboard key events, we already retrieve the key state > at the top of this function, so there is no real need to call the same > libinput function again as we can just reuse the 'key_state' variable > that we have above. >

[PATCH] libinput-device: Remove unnecessary function call

2016-02-22 Thread Chris Michael
When we handle keyboard key events, we already retrieve the key state at the top of this function, so there is no real need to call the same libinput function again as we can just reuse the 'key_state' variable that we have above. Signed-off-by: Chris Michael --- src/libinput-device.c | 3 +-- 1

Re: [PATCH] libinput-device: Remove unnecessary function call

2016-02-19 Thread Bryce Harrington
On Fri, Feb 19, 2016 at 11:07:00AM -0500, Chris Michael wrote: > When we handle pointer button events, we already retrieve the button > state at the top of this function, so there is no real need to call > the same function again as we can just reuse the 'button_state' > variable that we have above

Re: [PATCH] libinput-device: Remove unnecessary function call

2016-02-19 Thread Bryce Harrington
On Fri, Feb 19, 2016 at 11:07:00AM -0500, Chris Michael wrote: > When we handle pointer button events, we already retrieve the button > state at the top of this function, so there is no real need to call > the same function again as we can just reuse the 'button_state' > variable that we have above

[PATCH] libinput-device: Remove unnecessary function call

2016-02-19 Thread Chris Michael
When we handle pointer button events, we already retrieve the button state at the top of this function, so there is no real need to call the same function again as we can just reuse the 'button_state' variable that we have above. Signed-off-by: Chris Michael --- src/libinput-device.c | 3 ++- 1