Re: [PATCH] editor: react on Enter, Tab, and Up-Down arrow keys

2014-04-21 Thread Kristian Høgsberg
On Fri, Apr 18, 2014 at 12:52:03PM +0200, Manuel Bachmann wrote: > This fixes : > https://bugs.freedesktop.org/show_bug.cgi?id=77496 > Yup, the patch looks good, thanks Manuel. Kristian > Regards, > Manuel > > > 2014-04-18 12:50 GMT+02:00 Manuel Bachmann < > manuel.bachm...@open.eurogiciel.or

Re: [PATCH] editor: react on Enter, Tab, and Up-Down arrow keys

2014-04-21 Thread Manuel Bachmann
Hi Bill, > It looks like the text actually has the bytes "Enter" at the newlines, rather than, say, a '\n'? In fact, it is '\r' (carriage return) rather than '\n' (new line). In renders correctly with Pango, though, and would paste gracefully to other clients such as weston-terminal. The only pr

Re: [PATCH] editor: react on Enter, Tab, and Up-Down arrow keys

2014-04-21 Thread Bill Spitzak
It looks like the text actually has the bytes "Enter" at the newlines, rather than, say, a '\n'? On 04/18/2014 03:52 AM, Manuel Bachmann wrote: This fixes : https://bugs.freedesktop.org/show_bug.cgi?id=77496 Regards, Manuel 2014-04-18 12:50 GMT+02:00 Manuel Bachmann

Re: [PATCH] editor: react on Enter, Tab, and Up-Down arrow keys

2014-04-18 Thread Manuel Bachmann
This fixes : https://bugs.freedesktop.org/show_bug.cgi?id=77496 Regards, Manuel 2014-04-18 12:50 GMT+02:00 Manuel Bachmann < manuel.bachm...@open.eurogiciel.org>: > The editor will now insert new lines and tabulations when > pressing the corresponding keys on the virtual keyboard. > > The Up an

[PATCH] editor: react on Enter, Tab, and Up-Down arrow keys

2014-04-18 Thread Manuel Bachmann
The editor will now insert new lines and tabulations when pressing the corresponding keys on the virtual keyboard. The Up and Down arrows can be used to navigate through lines. Signed-off-by: Manuel Bachmann --- clients/editor.c | 97 -- 1 f