Re: [PATCH] desktop-shell: don't segfault on invalid icon path

2012-08-29 Thread Kristian Høgsberg
On Wed, Aug 29, 2012 at 10:53:36AM +0200, Philipp Brüschweiler wrote: > Instead draw a fallback icon and proceed as normal. > > https://bugs.freedesktop.org/show_bug.cgi?id=53860 > > v2: coding style fixes > v3: memory leak, draw icon instead of relying on external files Nice, committed. Kristi

Re: [PATCH] desktop-shell: don't segfault on invalid icon path

2012-08-29 Thread Pekka Paalanen
On Wed, 29 Aug 2012 10:53:36 +0200 Philipp Brüschweiler wrote: > Instead draw a fallback icon and proceed as normal. > > https://bugs.freedesktop.org/show_bug.cgi?id=53860 > > v2: coding style fixes > v3: memory leak, draw icon instead of relying on external files > --- > clients/desktop-shell

[PATCH] desktop-shell: don't segfault on invalid icon path

2012-08-29 Thread Philipp Brüschweiler
Instead draw a fallback icon and proceed as normal. https://bugs.freedesktop.org/show_bug.cgi?id=53860 v2: coding style fixes v3: memory leak, draw icon instead of relying on external files --- clients/desktop-shell.c | 36 +++- 1 Datei geändert, 35 Zeilen hinzuge

Re: [PATCH] desktop-shell: don't segfault on invalid icon path

2012-08-28 Thread Pekka Paalanen
On Tue, 28 Aug 2012 19:48:12 +0200 Philipp Brüschweiler wrote: > Instead load a fallback icon and proceed as normal. > > https://bugs.freedesktop.org/show_bug.cgi?id=53860 > > v2: coding style fixes > --- > clients/desktop-shell.c | 20 +++- > 1 Datei geändert, 19 Zeilen hinzug

[PATCH] desktop-shell: don't segfault on invalid icon path

2012-08-28 Thread Philipp Brüschweiler
Instead load a fallback icon and proceed as normal. https://bugs.freedesktop.org/show_bug.cgi?id=53860 v2: coding style fixes --- clients/desktop-shell.c | 20 +++- 1 Datei geändert, 19 Zeilen hinzugefügt(+), 1 Zeile entfernt(-) diff --git a/clients/desktop-shell.c b/clients/des

Re: [PATCH] desktop-shell: don't segfault on invalid icon path

2012-08-28 Thread Scott Moreau
Hi Philipp, I happened across your patch and wanted to comment about the styling. (see below) On Tue, Aug 28, 2012 at 11:10 AM, Philipp Brüschweiler wrote: > Instead load a fallback icon and proceed as normal. > > https://bugs.freedesktop.org/show_bug.cgi?id=53860 > --- > clients/desktop-shell.

[PATCH] desktop-shell: don't segfault on invalid icon path

2012-08-28 Thread Philipp Brüschweiler
Instead load a fallback icon and proceed as normal. https://bugs.freedesktop.org/show_bug.cgi?id=53860 --- clients/desktop-shell.c | 19 ++- 1 Datei geändert, 18 Zeilen hinzugefügt(+), 1 Zeile entfernt(-) diff --git a/clients/desktop-shell.c b/clients/desktop-shell.c index dc87e7