Re: [PATCH] desktop-shell: Replace magic constants with named ones

2014-08-27 Thread Pekka Paalanen
On Mon, 25 Aug 2014 10:47:24 +0200 "Nils Chr. Brause" wrote: > This looks much more readable to me. Unnamed magic numbers are always > confusing. > > Reviewed-by: Nils Chr. Brause > > > > On Thu, Aug 21, 2014 at 3:47 PM, Ondřej Majerech > wrote: > > > Signed-off-by: Ondřej Majerech > > --

Re: [PATCH] desktop-shell: Replace magic constants with named ones

2014-08-25 Thread Nils Chr. Brause
This looks much more readable to me. Unnamed magic numbers are always confusing. Reviewed-by: Nils Chr. Brause On Thu, Aug 21, 2014 at 3:47 PM, Ondřej Majerech wrote: > Signed-off-by: Ondřej Majerech > --- > desktop-shell/shell.c | 11 +-- > 1 file changed, 9 insertions(+), 2 delet

[PATCH] desktop-shell: Replace magic constants with named ones

2014-08-21 Thread Ondřej Majerech
Signed-off-by: Ondřej Majerech --- desktop-shell/shell.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index e3abaad..02e180d 100644 --- a/desktop-shell/shell.c +++ b/desktop-shell/shell.c @@ -1884,13 +1884,20 @@ surf