Re: [PATCH] config: use simpler regexp syntax to get dot version

2015-04-08 Thread Bill Spitzak
On 04/08/2015 12:15 AM, Pekka Paalanen wrote: + dot_version=`$DOT -V 2>&1|$GREP -o ['[0-9]*\.[0-9]*\.[0-9]*']` AS_VERSION_COMPARE([$dot_version], [2.26.0], [AC_MSG_RESULT([no]) AC_MSG_ERROR([Graphviz dot $dot_version too old.

Re: [PATCH] config: use simpler regexp syntax to get dot version

2015-04-08 Thread Pekka Paalanen
On Thu, 2 Apr 2015 19:20:00 -0700 Bill Spitzak wrote: > I wasted a lot of time before I figured out that I needed to add those > square brackets to get this to work. Sigh... > > --- > configure.ac |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure.ac b/confi

Re: [PATCH] config: use simpler regexp syntax to get dot version

2015-04-07 Thread Bryce Harrington
On Thu, Apr 02, 2015 at 07:37:07PM -0700, Bryce Harrington wrote: > On Thu, Apr 02, 2015 at 07:20:00PM -0700, Bill Spitzak wrote: > > I wasted a lot of time before I figured out that I needed to add those > > square brackets to get this to work. Sigh... > > Lots clearer too. > > Reviewed-by: Bryc

Re: [PATCH] config: use simpler regexp syntax to get dot version

2015-04-02 Thread Bryce Harrington
On Thu, Apr 02, 2015 at 07:20:00PM -0700, Bill Spitzak wrote: > I wasted a lot of time before I figured out that I needed to add those > square brackets to get this to work. Sigh... Lots clearer too. Reviewed-by: Bryce Harrington > --- > configure.ac |2 +- > 1 file changed, 1 insertion(+

[PATCH] config: use simpler regexp syntax to get dot version

2015-04-02 Thread Bill Spitzak
I wasted a lot of time before I figured out that I needed to add those square brackets to get this to work. Sigh... --- configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 6bbec59..271eec3 100644 --- a/configure.ac +++ b/configure.