Re: [PATCH] compositor-drm: fix z-order inversion in plane assignment

2017-12-05 Thread Daniel Stone
Hi Matt, On 5 September 2017 at 15:13, Matt Hoosier wrote: > On Tue, Sep 5, 2017 at 9:00 AM, Daniel Stone wrote: >> It can't be correct to raise it to the cursor plane either, since both >> cursor and overlay planes strictly stack above the scanout plane. I >> guess this would read a lot easier

Re: [PATCH] compositor-drm: fix z-order inversion in plane assignment

2017-09-05 Thread Matt Hoosier
On Tue, Sep 5, 2017 at 9:00 AM, Daniel Stone wrote: > It can't be correct to raise it to the cursor plane either, since both > cursor and overlay planes strictly stack above the scanout plane. I > guess this would read a lot easier with: > if (picked_scanout) > next_plane = primary; > at t

Re: [PATCH] compositor-drm: fix z-order inversion in plane assignment

2017-09-05 Thread Daniel Stone
Hi Matt, On 24 August 2017 at 15:24, Matt Hoosier wrote: > @@ -1545,10 +1548,22 @@ drm_assign_planes(struct weston_output *output_base, > void *repaint_data) > next_plane = primary; > if (next_plane == NULL) > next_plane = drm_outpu

Re: [PATCH] compositor-drm: fix z-order inversion in plane assignment

2017-08-29 Thread Matt Hoosier
On Thu, Aug 24, 2017 at 9:24 AM, Matt Hoosier wrote: > As discussed in the following thread: > > https://lists.freedesktop.org/archives/wayland-devel/2017-August/034755.html > > the existing plane assignment in the DRM backend is vulnerable to > accidental masking of the intended fullscreen surfac

[PATCH] compositor-drm: fix z-order inversion in plane assignment

2017-08-24 Thread Matt Hoosier
As discussed in the following thread: https://lists.freedesktop.org/archives/wayland-devel/2017-August/034755.html the existing plane assignment in the DRM backend is vulnerable to accidental masking of the intended fullscreen surface. This change adds a simple stateful memory to the plane assign