Re: [PATCH] compositor: Don't free an uninitialised pointer.

2014-09-11 Thread Pekka Paalanen
On Fri, 12 Sep 2014 03:08:40 +0900 Ryo Munakata wrote: > On Thu, 11 Sep 2014 15:53:15 +0200 > Ondřej Majerech wrote: > > > When backend_init returns NULL, we goto out_signals, which wants to > > free(modules), but in this particular code path, modules hasn't been > > initialised leading to a "D

Re: [PATCH] compositor: Don't free an uninitialised pointer.

2014-09-11 Thread Ryo Munakata
On Thu, 11 Sep 2014 15:53:15 +0200 Ondřej Majerech wrote: > When backend_init returns NULL, we goto out_signals, which wants to > free(modules), but in this particular code path, modules hasn't been > initialised leading to a "Double-free or corruption" error message. > Initialising modules to NU

[PATCH] compositor: Don't free an uninitialised pointer.

2014-09-11 Thread Ondřej Majerech
When backend_init returns NULL, we goto out_signals, which wants to free(modules), but in this particular code path, modules hasn't been initialised leading to a "Double-free or corruption" error message. Initialising modules to NULL makes the free a no-op in this scenario. Signed-off-by: Ondřej M