Re: [PATCH] compositor: Disallow negative geometries in backend output configs

2015-11-06 Thread Pekka Paalanen
On Fri, 6 Nov 2015 14:50:26 + Auke Booij wrote: > On 24 October 2015 at 08:23, Jasper St. Pierre wrote: > > I'm struggling to understand the motivation for this patch. > > > > krh has always said that you need to think of uint and int as two > > entirely separate types -- mixing both in math

Re: [PATCH] compositor: Disallow negative geometries in backend output configs

2015-11-06 Thread Auke Booij
On 24 October 2015 at 08:23, Jasper St. Pierre wrote: > I'm struggling to understand the motivation for this patch. > > krh has always said that you need to think of uint and int as two > entirely separate types -- mixing both in math will likely screw up. > You can see this in other places -- wid

Re: [PATCH] compositor: Disallow negative geometries in backend output configs

2015-11-06 Thread Pekka Paalanen
On Sat, 24 Oct 2015 00:23:05 -0700 "Jasper St. Pierre" wrote: > I'm struggling to understand the motivation for this patch. > > krh has always said that you need to think of uint and int as two > entirely separate types -- mixing both in math will likely screw up. > You can see this in other pla

Re: [PATCH] compositor: Disallow negative geometries in backend output configs

2015-10-29 Thread Bryce Harrington
On Sat, Oct 24, 2015 at 09:53:15AM +0300, Giulio Camuffo wrote: > 2015-10-24 1:29 GMT+03:00 Bryce Harrington : > > Signed-off-by: Bryce Harrington > > --- > > src/compositor.h | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/src/compositor.h b/src/compositor.h

Re: [PATCH] compositor: Disallow negative geometries in backend output configs

2015-10-24 Thread Jasper St. Pierre
I'm struggling to understand the motivation for this patch. krh has always said that you need to think of uint and int as two entirely separate types -- mixing both in math will likely screw up. You can see this in other places -- widths are often expressed as signed ints in the protocol, not unsi

Re: [PATCH] compositor: Disallow negative geometries in backend output configs

2015-10-23 Thread Giulio Camuffo
2015-10-24 1:29 GMT+03:00 Bryce Harrington : > Signed-off-by: Bryce Harrington > --- > src/compositor.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/compositor.h b/src/compositor.h > index 6bb6222..4443c72 100644 > --- a/src/compositor.h > +++ b/src/composito

[PATCH] compositor: Disallow negative geometries in backend output configs

2015-10-23 Thread Bryce Harrington
Signed-off-by: Bryce Harrington --- src/compositor.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/compositor.h b/src/compositor.h index 6bb6222..4443c72 100644 --- a/src/compositor.h +++ b/src/compositor.h @@ -619,9 +619,9 @@ enum weston_capability { */ struct