Re: [PATCH] clients: fix build on Linux

2016-01-15 Thread Olivier Fourdan
Hi Derek, - Original Message - > > stropts.h is not available on Linux. > Well, this is all fascinating. :) Yeah, sorry, my sentence was badly worded, I should have written "streams is not available on Linux upstream" instead (even though there've been 3rd party modules in the past). "

Re: [PATCH] clients: fix build on Linux

2016-01-14 Thread Derek Foreman
On 14/01/16 09:44 AM, Olivier Fourdan wrote: > stropts.h is not available on Linux. Well, this is all fascinating. :) I'm going to land the first simpler patch that just removes #include (with my Reviewed-by) linux/videodev2.h includes linux/ioctl.h right away, so I think we're all good. Than

[PATCH] clients: fix build on Linux

2016-01-14 Thread Olivier Fourdan
stropts.h is not available on Linux. Check for this header in the configure script and include it only if available to avoid a build failure on systems which do not have stropts.h. Signed-off-by: Olivier Fourdan --- clients/simple-dmabuf-v4l.c | 2 ++ configure.ac| 1 + 2 files

Re: [PATCH] clients: fix build on Linux

2016-01-14 Thread Olivier Fourdan
Hi Emmanuel, > POSIX.1-2008 (and likely prior versions), and thus Linux as well, > define ioctl() in this header, so it seems strange it doesn’t exist on > your system. I based my patch on a couple of information I found here: https://bugzilla.redhat.com/show_bug.cgi?id=439403 https://bugzilla.r

Re: [PATCH] clients: fix build on Linux

2016-01-14 Thread Emmanuel Gil Peyrot
On Thu, Jan 14, 2016 at 02:46:14PM +0100, Olivier Fourdan wrote: > Cannot find out why stropts.h is needed and Linux doesn't support > streams anyway, so there is no stropts.h. POSIX.1-2008 (and likely prior versions), and thus Linux as well, define ioctl() in this header, so it seems strange it d

[PATCH] clients: fix build on Linux

2016-01-14 Thread Olivier Fourdan
Cannot find out why stropts.h is needed and Linux doesn't support streams anyway, so there is no stropts.h. Signed-off-by: Olivier Fourdan --- clients/simple-dmabuf-v4l.c | 1 - 1 file changed, 1 deletion(-) diff --git a/clients/simple-dmabuf-v4l.c b/clients/simple-dmabuf-v4l.c index 2334e09..2