Hi Kristian,
Thanks a lot for your review !
You're totally right, I was leaking the mask (shame on me :-( ) and wasn't
totally consistent on the code style part.
I just submitted another patch, which should address most of our concerns :
http://lists.freedesktop.org/archives/wayland-devel/2014-Ap
On Sat, 5 Apr 2014 05:31:37 +0200
Manuel Bachmann wrote:
> When the alpha channel of a surface is changed and the surface
> refreshed, pixman renderer will now apply a mask corresponding
> to the alpha channel value.
A minor nitpick here. The term "alpha channel" refers to the per-pixel
alpha v
On Sat, Apr 05, 2014 at 05:31:37AM +0200, Manuel Bachmann wrote:
> When the alpha channel of a surface is changed and the surface
> refreshed, pixman renderer will now apply a mask corresponding
> to the alpha channel value.
>
> This allows visual effects like shell fade in, shell fade out,
> wind
When the alpha channel of a surface is changed and the surface
refreshed, pixman renderer will now apply a mask corresponding
to the alpha channel value.
This allows visual effects like shell fade in, shell fade out,
window switching, to work when using pixman renderer.
Signed-off-by: Manuel Bach
