Re: [PATCH] RDP compositor take 5

2013-04-01 Thread Hardening
On 30/03/2013 21:34, Jason Ekstrand wrote: [...] >> + cmd->codecID = peer->settings->RemoteFxCodecId; >> + cmd->width = width; >> + cmd->height = height; >> + >> + ptr = pixman_image_get_data(image) + damage->extents.x1 + >> + damage->extents.y1

Re: [PATCH] RDP compositor take 5

2013-03-31 Thread Alex Elsayed
Hardening wrote: > On 30/03/2013 21:34, Jason Ekstrand wrote: >> Hardening, >> >> I'm curious what your use-case is for passing an FD to an RDP server. >> Do you intend it to have an authentication daemon that then starts RDP >> weston? >> > In this case there's no listener. This could be used

Re: [PATCH] RDP compositor take 5

2013-03-31 Thread Hardening
On 30/03/2013 21:34, Jason Ekstrand wrote: > Hardening, > This is looking really good. I only have a couple comments on the > code below that should take all of 5 minutes to address. > [...] >> + } else { >> + /* get the socket from RDP_FD var */ >> + fd_str = get

Re: [PATCH] RDP compositor take 5

2013-03-30 Thread Hardening
On 30/03/2013 21:34, Jason Ekstrand wrote: > Hardening, > This is looking really good. I only have a couple comments on the > code below that should take all of 5 minutes to address. > > That said, It's segfaulting on me a lot. Most of them seem to have to > do with wl_seat. I really don't know

Re: [PATCH] RDP compositor take 5

2013-03-30 Thread Jason Ekstrand
Hardening, This is looking really good. I only have a couple comments on the code below that should take all of 5 minutes to address. That said, It's segfaulting on me a lot. Most of them seem to have to do with wl_seat. I really don't know why. Also, it works with freerdp, but doesn't work wi

[PATCH] RDP compositor take 5

2013-03-28 Thread Hardening
Sorry, my previous post was broken. This patch is the 5th version of the FreeRDP based compositor. Changes from last version: * dropped tiling for raw surfaces (not required) * corrected remoteFx encoding to have all rects of a damage event into a single remoteFx frame * added a mode to read