2013/5/1 Kristian Høgsberg :
> On Fri, Apr 19, 2013 at 04:11:01PM -0700, Bill Spitzak wrote:
>> >2013/4/16 Kristian Høgsberg :
>>
>> >>I know the current behavior is a bit problematic for some use cases.
>> >>However it works well for the case where you load a plugin in addition
>> >>to the shell,
On Fri, Apr 19, 2013 at 04:11:01PM -0700, Bill Spitzak wrote:
> >2013/4/16 Kristian Høgsberg :
>
> >>I know the current behavior is a bit problematic for some use cases.
> >>However it works well for the case where you load a plugin in addition
> >>to the shell, like xwayland. I'm not sure what t
2013/4/16 Kristian Høgsberg :
I know the current behavior is a bit problematic for some use cases.
However it works well for the case where you load a plugin in addition
to the shell, like xwayland. I'm not sure what the best way to make
both cases work is, except to make the shell plugin spec
2013/4/16 Kristian Høgsberg :
> On Sun, Apr 14, 2013 at 07:17:40PM +0200, Pier Luigi Fiorini wrote:
>> Let --modules override modules list and load desktop-shell.so as a
>> fallback if a modules list is not specified neither by passing
>> --modules nor with weston.ini.
>>
>> Signed-off-by: Pier Lui
On Sun, Apr 14, 2013 at 07:17:40PM +0200, Pier Luigi Fiorini wrote:
> Let --modules override modules list and load desktop-shell.so as a
> fallback if a modules list is not specified neither by passing
> --modules nor with weston.ini.
>
> Signed-off-by: Pier Luigi Fiorini
> ---
> man/weston.man
Looks good to me.
Regards,
Emilio
On 04/14/2013 07:17 PM, Pier Luigi Fiorini wrote:
> Let --modules override modules list and load desktop-shell.so as a
> fallback if a modules list is not specified neither by passing
> --modules nor with weston.ini.
>
> Signed-off-by: Pier Luigi Fiorini
> ---
Let --modules override modules list and load desktop-shell.so as a
fallback if a modules list is not specified neither by passing
--modules nor with weston.ini.
Signed-off-by: Pier Luigi Fiorini
---
man/weston.man | 5 +++--
src/compositor.c | 7 +++
2 files changed, 6 insertions(+), 6 del
On 04/01/2013 07:10 PM, Bill Spitzak wrote:
> Emilio Pozuelo Monfort wrote:
>
>> I would rather do something like this to simplify the code (at least it looks
>> clearer to me but YMMV):
>>
>> if (load_modules(ec, option_modules != NULL ? option_modules : modules,
>> &argc, argv, c
Emilio Pozuelo Monfort wrote:
I would rather do something like this to simplify the code (at least it looks
clearer to me but YMMV):
if (load_modules(ec, option_modules != NULL ? option_modules : modules,
&argc, argv, config_file) < 0)
goto out;
That's bett
Hi,
The patch looks good to me, but it should come with an update of the --help
output, which currently states:
--modules Load the comma-separated list of modules
This should state that it will override any modules listed in weston.ini.
And the manpage says:
--modules=module1.so,
How about this, which reduces duplicate code (note I assume modules is a
local variable, if it isn't and it needs to be preserved then a local
copy of it should be used):
if (option_modules) modules = option_modules;
if (load_modules(ec, modules, &argc, argv, config_file) < 0)
Oh thanks, i needed this. I can now stop modifying weston.ini back and
forth. :)
Looks good to me.
2013/4/1 Pier Luigi Fiorini
> Let --modules override modules list and load desktop-shell.so as a
> fallback if a modules list is not specified neither by passing
> --modules nor with weston.ini.
Let --modules override modules list and load desktop-shell.so as a
fallback if a modules list is not specified neither by passing
--modules nor with weston.ini.
---
src/compositor.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/src/compositor.c b/src/compositor.c
13 matches
Mail list logo
