Re: [PATCH] Make RDP backend supports arbitrary modes v2

2014-04-01 Thread Kristian Høgsberg
On Thu, Mar 20, 2014 at 10:34:30PM +0100, Hardening wrote: > This patch removes the extra modes parameter for the RDP compositor. And > make it support any mode that is requested (be aware that RDP client may not > support all possible modes, especially odd resolution). > > This new version fixes

Re: [PATCH] Make RDP backend supports arbitrary modes

2014-04-01 Thread Kristian Høgsberg
On Tue, Mar 18, 2014 at 06:15:54PM +0100, Hardening wrote: > This patch removes the extra modes parameter for the RDP compositor. And > make it support any mode that is requested (be aware that RDP client may not > support all possible modes, especially odd resolution). > This is definitely useful

[PATCH] Make RDP backend supports arbitrary modes v2

2014-03-20 Thread Hardening
This patch removes the extra modes parameter for the RDP compositor. And make it support any mode that is requested (be aware that RDP client may not support all possible modes, especially odd resolution). This new version fixes remarks done by Jason Ekstrand. It also fixes some missing spaces bet

Re: [PATCH] Make RDP backend supports arbitrary modes

2014-03-20 Thread Jason Ekstrand
Hardening, By and large, I think it looks good. I have a few nit-picking comments below that should take ~20 seconds to address. I was trying to test it on my machine and nothing seems to resize. Is this because the xfreerdp client doesn't support resizing or is it from some other reason? Thank

[PATCH] Make RDP backend supports arbitrary modes

2014-03-18 Thread Hardening
This patch removes the extra modes parameter for the RDP compositor. And make it support any mode that is requested (be aware that RDP client may not support all possible modes, especially odd resolution). This is definitely useful for the fullscreen shell. --- src/compositor-rdp.c | 105 +