Probably nitpicky as well, but you may also want to add:
- If argc is 3 then use the name as the input file but use stdout for
the output.
- A filename of "-" leaves it using stdin/out.
Neither of these are very important, just trying to match standard usage
of other tools.
On 03/02/2015 0
On Mon, Mar 2, 2015 at 9:52 AM, Pekka Paalanen wrote:
> in addition to the other review commments, I believe the
> standard way for changing the file association for stdout is to use
> freopen(). Is there a reason why you didn't use freopen()?
>
The main one is that I did not know freopen exist
On Thu, 26 Feb 2015 11:48:38 +0200
Jussi Pakkanen wrote:
> * Enhance wayland-scanner so it can use files for input and output
> to improve flexibility and testability.
>
> Signed-off-by: Jussi Pakkanen
>
> ---
> src/scanner.c | 34 +-
> 1 file cha
Hi,
A bunch of nitpicks follow, I'm afraid.
On 26 February 2015 at 09:48, Jussi Pakkanen wrote:
> * Enhance wayland-scanner so it can use files for input and output
> to improve flexibility and testability.
>
> Signed-off-by: Jussi Pakkanen
For future, please drop the leading aste
On Thu, Feb 26, 2015 at 11:48:38AM +0200, Jussi Pakkanen wrote:
> * Enhance wayland-scanner so it can use files for input and output
> to improve flexibility and testability.
>
> Signed-off-by: Jussi Pakkanen
Command line option handling is getting a bit stretched; if any more
opti
* Enhance wayland-scanner so it can use files for input and output
to improve flexibility and testability.
Signed-off-by: Jussi Pakkanen
---
src/scanner.c | 34 +-
1 file changed, 29 insertions(+), 5 deletions(-)
diff --git a/src/scanner.c b/src/sc
