Re: [PATCH] Declare enumeration wl_output.transform as bitfield.

2015-11-15 Thread Nils Chr. Brause
On Sun, Nov 15, 2015 at 9:48 PM, Auke Booij wrote: > On 9 November 2015 at 18:17, Bill Spitzak wrote: >> Making the transform into a bitfield allows bitfield tests for useful facts: >> it can see if it is a mirror image by testing the flip bit, and check for >> transposition of the axes by checki

Re: [PATCH] Declare enumeration wl_output.transform as bitfield.

2015-11-15 Thread Auke Booij
On 9 November 2015 at 18:17, Bill Spitzak wrote: > Making the transform into a bitfield allows bitfield tests for useful facts: > it can see if it is a mirror image by testing the flip bit, and check for > transposition of the axes by checking the 90 degree bit. I believe this is > the reason behi

Re: [PATCH] Declare enumeration wl_output.transform as bitfield.

2015-11-09 Thread Bill Spitzak
Making the transform into a bitfield allows bitfield tests for useful facts: it can see if it is a mirror image by testing the flip bit, and check for transposition of the axes by checking the 90 degree bit. I believe this is the reason behind the desire to declare it a bitfield and I agree this is

Re: [PATCH] Declare enumeration wl_output.transform as bitfield.

2015-11-09 Thread Nils Chr. Brause
Hi, On Mon, Nov 9, 2015 at 4:35 PM, Pekka Paalanen wrote: > On Mon, 9 Nov 2015 15:38:22 +0100 > "Nils Chr. Brause" wrote: > >> Hi, >> >> On Mon, Nov 9, 2015 at 2:49 PM, Pekka Paalanen wrote: >> > On Mon, 9 Nov 2015 12:54:00 +0100 >> > "Nils Chr. Brause" wrote: >> > >> >> Hi, >> >> >> >> On Mon

Re: [PATCH] Declare enumeration wl_output.transform as bitfield.

2015-11-09 Thread Pekka Paalanen
On Mon, 9 Nov 2015 15:38:22 +0100 "Nils Chr. Brause" wrote: > Hi, > > On Mon, Nov 9, 2015 at 2:49 PM, Pekka Paalanen wrote: > > On Mon, 9 Nov 2015 12:54:00 +0100 > > "Nils Chr. Brause" wrote: > > > >> Hi, > >> > >> On Mon, Nov 9, 2015 at 12:04 PM, Pekka Paalanen > >> wrote: > >> > On Fri, 6

Re: [PATCH] Declare enumeration wl_output.transform as bitfield.

2015-11-09 Thread Nils Chr. Brause
Hi, On Mon, Nov 9, 2015 at 3:39 PM, Auke Booij wrote: > On 9 November 2015 at 11:54, Nils Chr. Brause wrote: >> Hi, >> >> On Mon, Nov 9, 2015 at 12:04 PM, Pekka Paalanen wrote: >>> On Fri, 6 Nov 2015 16:05:10 +0100 >>> "Nils Chr. Brause" wrote: >>> Hi, On Fri, Nov 6, 2015 at 3:4

Re: [PATCH] Declare enumeration wl_output.transform as bitfield.

2015-11-09 Thread Auke Booij
On 9 November 2015 at 14:39, Auke Booij wrote: > and it was a mistake Sorry, let me retract this - that was maybe a bit harsh, since I don't know the exact history. ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesk

Re: [PATCH] Declare enumeration wl_output.transform as bitfield.

2015-11-09 Thread Auke Booij
On 9 November 2015 at 11:54, Nils Chr. Brause wrote: > Hi, > > On Mon, Nov 9, 2015 at 12:04 PM, Pekka Paalanen wrote: >> On Fri, 6 Nov 2015 16:05:10 +0100 >> "Nils Chr. Brause" wrote: >> >>> Hi, >>> >>> On Fri, Nov 6, 2015 at 3:48 PM, Auke Booij wrote: >>> > On 6 November 2015 at 13:03, Nils Ch

Re: [PATCH] Declare enumeration wl_output.transform as bitfield.

2015-11-09 Thread Nils Chr. Brause
Hi, On Mon, Nov 9, 2015 at 2:49 PM, Pekka Paalanen wrote: > On Mon, 9 Nov 2015 12:54:00 +0100 > "Nils Chr. Brause" wrote: > >> Hi, >> >> On Mon, Nov 9, 2015 at 12:04 PM, Pekka Paalanen wrote: >> > On Fri, 6 Nov 2015 16:05:10 +0100 >> > "Nils Chr. Brause" wrote: >> > >> >> Hi, >> >> >> >> On Fr

Re: [PATCH] Declare enumeration wl_output.transform as bitfield.

2015-11-09 Thread Pekka Paalanen
On Mon, 9 Nov 2015 12:54:00 +0100 "Nils Chr. Brause" wrote: > Hi, > > On Mon, Nov 9, 2015 at 12:04 PM, Pekka Paalanen wrote: > > On Fri, 6 Nov 2015 16:05:10 +0100 > > "Nils Chr. Brause" wrote: > > > >> Hi, > >> > >> On Fri, Nov 6, 2015 at 3:48 PM, Auke Booij wrote: > >> > On 6 November 2015 a

Re: [PATCH] Declare enumeration wl_output.transform as bitfield.

2015-11-09 Thread Nils Chr. Brause
Hi, On Mon, Nov 9, 2015 at 12:04 PM, Pekka Paalanen wrote: > On Fri, 6 Nov 2015 16:05:10 +0100 > "Nils Chr. Brause" wrote: > >> Hi, >> >> On Fri, Nov 6, 2015 at 3:48 PM, Auke Booij wrote: >> > On 6 November 2015 at 13:03, Nils Christopher Brause >> > wrote: >> >> The enumeration wl_output.tran

Re: [PATCH] Declare enumeration wl_output.transform as bitfield.

2015-11-09 Thread Pekka Paalanen
On Fri, 6 Nov 2015 16:05:10 +0100 "Nils Chr. Brause" wrote: > Hi, > > On Fri, Nov 6, 2015 at 3:48 PM, Auke Booij wrote: > > On 6 November 2015 at 13:03, Nils Christopher Brause > > wrote: > >> The enumeration wl_output.transform is clearly a bitfield. > >> The definition of a bitfield is that

Re: [PATCH] Declare enumeration wl_output.transform as bitfield.

2015-11-06 Thread Nils Chr. Brause
Hi, On Fri, Nov 6, 2015 at 3:48 PM, Auke Booij wrote: > On 6 November 2015 at 13:03, Nils Christopher Brause > wrote: >> The enumeration wl_output.transform is clearly a bitfield. >> The definition of a bitfield is that each bit has a distinct >> meaning. This is clearly the case in the enumerat

Re: [PATCH] Declare enumeration wl_output.transform as bitfield.

2015-11-06 Thread Auke Booij
On 6 November 2015 at 13:03, Nils Christopher Brause wrote: > The enumeration wl_output.transform is clearly a bitfield. > The definition of a bitfield is that each bit has a distinct > meaning. This is clearly the case in the enumeration > wl_output.transform: > > - bit 0: rotate by 90 degree > -

[PATCH] Declare enumeration wl_output.transform as bitfield.

2015-11-06 Thread Nils Christopher Brause
The enumeration wl_output.transform is clearly a bitfield. The definition of a bitfield is that each bit has a distinct meaning. This is clearly the case in the enumeration wl_output.transform: - bit 0: rotate by 90 degree - bit 1: rotate by 180 degree - bit 2: flip around vertical axis Every oth