Re: [PATCH] Check malloc result

On Fri, Apr 11, 2014 at 09:06:58AM +0200, Hardening wrote: > This patch checks malloc was successfull and release resources if it > wasn't. Commmitted, thanks. Kristian > --- > src/screen-share.c | 17 +++-- > 1 file changed, 15 insertions(+), 2 deletions(-) > > diff --git a/src/sc

Re: [PATCH] Check malloc result

Much better error checking. In the out_pixman_error finalizer should it also destroy the zalloc'd sb object, since we're going to return NULL in this case? Also see one more comment below. But these are just nit picks; LGTM even without those changes. Reviewed-by: Bryce Harrington On Fri, Apr

[PATCH] Check malloc result

This patch checks malloc was successfull and release resources if it wasn't. --- src/screen-share.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/src/screen-share.c b/src/screen-share.c index 5de20be..d3e3f05 100644 --- a/src/screen-share.c +++ b/src/screen