RE: [PATCH] Bug fix client apps because of output change

2014-03-11 Thread Wang, Quanxian
ect: Re: [PATCH] Bug fix client apps because of output change > >On Tue, 11 Mar 2014 01:48:49 + >"Wang, Quanxian" wrote: > >> Thanks. >> >> Quanxian >> >> >> >binds with version 2 regardless of what the compositor advertised. >> &g

Re: [PATCH] Bug fix client apps because of output change

2014-03-11 Thread Pekka Paalanen
aalanen [mailto:ppaala...@gmail.com] > >> >Sent: Monday, March 10, 2014 5:58 PM > >> >To: Wang, Quanxian > >> >Cc: wayland-devel@lists.freedesktop.org > >> >Subject: Re: [PATCH] Bug fix client apps because of output change > >> > > >

Re: [PATCH] Bug fix client apps because of output change

2014-03-11 Thread Pekka Paalanen
On Tue, 11 Mar 2014 01:48:49 + "Wang, Quanxian" wrote: > Thanks. > > Quanxian > > >> >binds with version 2 regardless of what the compositor advertised. > >> > > >> >You can compare to the "desktop_shell" global handling which seems > >> >correct. > >> [Wang, Quanxian] I will check and upda

RE: [PATCH] Bug fix client apps because of output change

2014-03-10 Thread Wang, Quanxian
Thanks. Quanxian >> >binds with version 2 regardless of what the compositor advertised. >> > >> >You can compare to the "desktop_shell" global handling which seems >> >correct. >> [Wang, Quanxian] I will check and update that. The change will be >> like that 1293 output->output = >> 1294

RE: [PATCH] Bug fix client apps because of output change

2014-03-10 Thread Wang, Quanxian
>-Original Message- >From: Pekka Paalanen [mailto:ppaala...@gmail.com] >Sent: Monday, March 10, 2014 7:05 PM >To: Wang, Quanxian >Cc: wayland-devel@lists.freedesktop.org >Subject: Re: [PATCH] Bug fix client apps because of output change > >On Mon, 10 Mar 20

Re: [PATCH] Bug fix client apps because of output change

2014-03-10 Thread Pekka Paalanen
On Mon, 10 Mar 2014 10:58:00 + "Wang, Quanxian" wrote: > > > >-Original Message- > >From: Pekka Paalanen [mailto:ppaala...@gmail.com] > >Sent: Monday, March 10, 2014 5:58 PM > >To: Wang, Quanxian > >Cc: wayland-devel@lists.freedesktop.o

RE: [PATCH] Bug fix client apps because of output change

2014-03-10 Thread Wang, Quanxian
>-Original Message- >From: Pekka Paalanen [mailto:ppaala...@gmail.com] >Sent: Monday, March 10, 2014 5:58 PM >To: Wang, Quanxian >Cc: wayland-devel@lists.freedesktop.org >Subject: Re: [PATCH] Bug fix client apps because of output change > >On Mon, 10 Mar 20

Re: [PATCH] Bug fix client apps because of output change

2014-03-10 Thread Pekka Paalanen
On Mon, 10 Mar 2014 08:23:45 + "Wang, Quanxian" wrote: > Thanks Pq. Comments below. ... > >> @@ -1145,6 +1154,45 @@ desktop_destroy_outputs(struct desktop > >> *desktop) } > >> > >> static void > >> +update_output(struct output *output) > >> +{ > >> + struct panel *panel = output->panel; >

RE: [PATCH] Bug fix client apps because of output change

2014-03-10 Thread Wang, Quanxian
edesktop.org >Subject: Re: [PATCH] Bug fix client apps because of output change > >Hi, > >overall this looks fine now, but I still haven't tested it. I'm moving on to >nitpick on >the minor details. ;-) > >The patch title (topic line) is usually prefixed wi

RE: [PATCH] Bug fix client apps because of output change

2014-03-10 Thread Wang, Quanxian
: [PATCH] Bug fix client apps because of output change > >Hi, > >overall this looks fine now, but I still haven't tested it. I'm moving on to >nitpick on >the minor details. ;-) [Wang, Quanxian] that is fine. > >The patch title (topic line) is usually prefixed wi

Re: [PATCH] Bug fix client apps because of output change

2014-03-10 Thread Pekka Paalanen
Hi, overall this looks fine now, but I still haven't tested it. I'm moving on to nitpick on the minor details. ;-) The patch title (topic line) is usually prefixed with the component the patch is affecting. Looking at the clients/desktop-shell.c history, the appropriate prefix would be "desktop-s

RE: [PATCH] Bug fix client apps because of output change

2014-03-06 Thread Wang, Quanxian
To: wayland-devel@lists.freedesktop.org >Cc: ppaala...@gmail.com >Subject: RE: [PATCH] Bug fix client apps because of output change > >Ignore this, I have found a bug. After bug fixing, I will resend the patch. >Sorry >about that. > >I have two monitors. >VGA1(left) + HDMI3(right) > >

RE: [PATCH] Bug fix client apps because of output change

2014-03-06 Thread Wang, Quanxian
will have some issue. Sorry about that. Regards Quanxian Wang >-Original Message- >From: Wang, Quanxian >Sent: Thursday, March 06, 2014 6:31 PM >To: wayland-devel@lists.freedesktop.org >Cc: ppaala...@gmail.com; Wang, Quanxian >Subject: [PATCH] Bug fix client apps becaus

[PATCH] Bug fix client apps because of output change

2014-03-06 Thread Quanxian Wang
1) Width and height of Panel and Background depend on output's, therefore they should be bound with output changes including mode, transform and scale. 2) Update the min_allocation before resize the panel and background window. Add window_set_min_allocation function because it is invisible outside

RE: [PATCH] Bug fix client apps because of output change

2014-03-06 Thread Wang, Quanxian
Hi, Pq >> >>Is there a reason why the background window does not need the >>min_allocation changed? >[Wang, Quanxian] With testing, this doesn't make error. Let me double check >that. [Wang, Quanxian] According to the logic, we need set the min_allocation because of background should overwrite

RE: [PATCH] Bug fix client apps because of output change

2014-03-06 Thread Wang, Quanxian
>-Original Message- >From: Pekka Paalanen [mailto:ppaala...@gmail.com] >Sent: Thursday, March 06, 2014 4:42 PM >To: Wang, Quanxian >Cc: wayland-devel@lists.freedesktop.org >Subject: Re: [PATCH] Bug fix client apps because of output change > >On Thu, 6 Mar 2014

Re: [PATCH] Bug fix client apps because of output change

2014-03-06 Thread Pekka Paalanen
On Thu, 6 Mar 2014 16:25:42 +0800 Quanxian Wang wrote: > 1) > Width and height of Panel and Background depend > on output's, therefore they should be bound > with output changes including mode, transform and scale. > > 2) > Update the min_allocation before resize the panel and > background wind

[PATCH] Bug fix client apps because of output change

2014-03-06 Thread Quanxian Wang
1) Width and height of Panel and Background depend on output's, therefore they should be bound with output changes including mode, transform and scale. 2) Update the min_allocation before resize the panel and background window. Add window_set_min_allocation function because it is invisible outside