Re: [PATCH] Allow null surface arguments in wl_pointer.leave and wl_keyboard.leave

2013-07-08 Thread Bill Spitzak
Jason Ekstrand wrote: The other option here is to specify that the client does not get the leave event if the surface is destroyed. I greatly prefer this solution to this sort of problem. ___ wayland-devel mailing list wayland-devel@lists.freedeskto

Re: [PATCH] Allow null surface arguments in wl_pointer.leave and wl_keyboard.leave

2013-07-08 Thread Kristian Høgsberg
On Mon, Jul 08, 2013 at 01:51:34PM -0400, Kristian Høgsberg wrote: > On Mon, Jul 08, 2013 at 12:10:54PM +0100, Rob Bradford wrote: > > *bump* > > > > This is a fix for: > > https://bugs.freedesktop.org/show_bug.cgi?id=65726&list_id=320167 > > > > Although it might be much better if we could emit

Re: [PATCH] Allow null surface arguments in wl_pointer.leave and wl_keyboard.leave

2013-07-08 Thread Kristian Høgsberg
On Mon, Jul 08, 2013 at 12:10:54PM +0100, Rob Bradford wrote: > *bump* > > This is a fix for: > https://bugs.freedesktop.org/show_bug.cgi?id=65726&list_id=320167 > > Although it might be much better if we could emit the event > (especially the leave) before we destroy the surface - that being sai

Re: [PATCH] Allow null surface arguments in wl_pointer.leave and wl_keyboard.leave

2013-07-08 Thread Jason Ekstrand
On Mon, Jul 8, 2013 at 11:32 AM, Rob Bradford wrote: > On 8 July 2013 17:25, Jason Ekstrand wrote: > > > That's exactly what weston *was* doing. However, thanks to the destroyed > > proxies, the clients were getting NULL anyway. We could to go through a > > bunch of trouble to keep the resource

Re: [PATCH] Allow null surface arguments in wl_pointer.leave and wl_keyboard.leave

2013-07-08 Thread Rob Bradford
On 8 July 2013 17:25, Jason Ekstrand wrote: > That's exactly what weston *was* doing. However, thanks to the destroyed > proxies, the clients were getting NULL anyway. We could to go through a > bunch of trouble to keep the resource valid and call wl_pointer.leave on a > valid resource. Howeve

Re: [PATCH] Allow null surface arguments in wl_pointer.leave and wl_keyboard.leave

2013-07-08 Thread Jason Ekstrand
On Mon, Jul 8, 2013 at 6:10 AM, Rob Bradford wrote: > *bump* > > This is a fix for: > https://bugs.freedesktop.org/show_bug.cgi?id=65726&list_id=320167 > > Although it might be much better if we could emit the event > (especially the leave) before we destroy the surface - that being said > the des

Re: [PATCH] Allow null surface arguments in wl_pointer.leave and wl_keyboard.leave

2013-07-08 Thread Rob Bradford
*bump* This is a fix for: https://bugs.freedesktop.org/show_bug.cgi?id=65726&list_id=320167 Although it might be much better if we could emit the event (especially the leave) before we destroy the surface - that being said the destruction of the object will also result in the proxy being removed

[PATCH] Allow null surface arguments in wl_pointer.leave and wl_keyboard.leave

2013-06-17 Thread Jason Ekstrand
The current specified behavior does not allow a null surface in either of these events. However, if the client calls wl_surface.destroy while the surface has focus then the leave handler will get a null surface anyway because the proxy corresponding to the wl_surface no longer exists. This change