Re: [PATCH] Add new config parser

2013-04-01 Thread Kristian Høgsberg
On Mon, Apr 01, 2013 at 07:29:08PM +0200, Giulio Camuffo wrote: > Sorry, i was a bit too rushing. I made a couple of comments below. > > > 2013/4/1 Kristian Høgsberg > > > The current config parser, parses the ini file and pulls out the values > > specified by the struct config_section passed t

Re: [PATCH] Add new config parser

2013-04-01 Thread Emilio Pozuelo Monfort
Hi, On 04/01/2013 06:42 PM, Kristian Høgsberg wrote: > The current config parser, parses the ini file and pulls out the values > specified by the struct config_section passed to parse_config_file() and > then throw the rest away. This means that every place we want to get > info out of the ini fi

Re: [PATCH] Add new config parser

2013-04-01 Thread Giulio Camuffo
Sorry, i was a bit too rushing. I made a couple of comments below. 2013/4/1 Kristian Høgsberg > The current config parser, parses the ini file and pulls out the values > specified by the struct config_section passed to parse_config_file() and > then throw the rest away. This means that every p

Re: [PATCH] Add new config parser

2013-04-01 Thread Giulio Camuffo
Seems good to me! But shouldn't weston_config_get_section() and all the weston_config_section_get_*() be WL_EXPORT? 2013/4/1 Kristian Høgsberg > The current config parser, parses the ini file and pulls out the values > specified by the struct config_section passed to parse_config_file() and > t

[PATCH] Add new config parser

2013-04-01 Thread Kristian Høgsberg
The current config parser, parses the ini file and pulls out the values specified by the struct config_section passed to parse_config_file() and then throw the rest away. This means that every place we want to get info out of the ini file, we have to parse the whole thing again. It's not a big ov