Re: [PATCH] Add initial color management framework code

2013-05-10 Thread Richard Hughes
On 10 May 2013 18:05, Kristian Høgsberg wrote: > With a few changes... there were a few crashers in here, some of which > I triggered because I happen to have both eDP1 and LVDS output > sections in my weston.ini. Right, I didn't hit this as I only had: [output] name=LVDS1 icc_profile=/usr/share

Re: [PATCH] Add initial color management framework code

2013-05-10 Thread Kristian Høgsberg
On Fri, May 10, 2013 at 11:03:30AM -0400, Kristian Høgsberg wrote: > On Thu, May 09, 2013 at 08:31:09PM +0100, Richard Hughes wrote: > > ICC profiles can now be specified in weston.ini for each output, or a CMS > > implementation can optionally loaded from a pluggable module. > > --- > > Excellent

Re: [PATCH] Add initial color management framework code

2013-05-10 Thread Kristian Høgsberg
On Thu, May 09, 2013 at 08:31:09PM +0100, Richard Hughes wrote: > ICC profiles can now be specified in weston.ini for each output, or a CMS > implementation can optionally loaded from a pluggable module. > --- Excellent, thanks for revising. Committed and pushed. Kristian > configure.ac

[PATCH] Add initial color management framework code

2013-05-09 Thread Richard Hughes
ICC profiles can now be specified in weston.ini for each output, or a CMS implementation can optionally loaded from a pluggable module. --- configure.ac | 7 ++ src/Makefile.am | 12 +++ src/cms-helper.c | 134 src/cms-helper.h | 70 +++

Re: [PATCH] Add initial color management framework code

2013-05-03 Thread Richard Hughes
On 3 May 2013 11:53, Pekka Paalanen wrote: >> + o->set_gamma(o, size, red, red, red); > Three times red? :-) Good catch, thanks. >> + p = calloc(sizeof(struct weston_color_profile), 1); > Calloc arguments are swapped. All fixed. >> + weston_cms_destroy_profile(output->color_profile

Re: [PATCH] Add initial color management framework code

2013-05-03 Thread Pekka Paalanen
On Thu, 2 May 2013 15:16:09 +0100 Richard Hughes wrote: > ICC profiles can now be specified in weston.ini for each output, or a CMS > implementation can optionally loaded from a pluggable module. > --- > configure.ac | 7 ++ > src/Makefile.am | 13 +++- > src/cms-static.c |

[PATCH] Add initial color management framework code

2013-05-02 Thread Richard Hughes
ICC profiles can now be specified in weston.ini for each output, or a CMS implementation can optionally loaded from a pluggable module. --- configure.ac | 7 ++ src/Makefile.am | 13 +++- src/cms-static.c | 211 +++ src/cms.c