Re: [PATCH] Add a missing NULL check for device->grab.

2011-01-13 Thread Tiago Vignatti
On Tue, Jan 11, 2011 at 12:40:38PM -0800, ext Dima Ryazanov wrote: > [second attempt] > > Wayland compositor sometimes crashes if you start a client, move the client's > window, then right-click and drag the empty space. > Not sure if that's the correct solution, but it fixes the crash. > > Sign

[PATCH] Add a missing NULL check for device->grab.

2011-01-11 Thread Dima Ryazanov
[second attempt] Wayland compositor sometimes crashes if you start a client, move the client's window, then right-click and drag the empty space. Not sure if that's the correct solution, but it fixes the crash. Signed-off-by: Dima Ryazanov --- compositor/compositor.c |8 +--- 1 files c

Re: [PATCH] Add a missing NULL check for device->grab.

2011-01-11 Thread Dima Ryazanov
> > I don't know how you generated the patch but it didn't apply okay for me. I > guess due the following line wrap that happened for some reason (your email > client?): > >> + device->grab->interface->button(device->grab, time, > button, >> state); > > Have you used git forma

Re: [PATCH] Add a missing NULL check for device->grab.

2011-01-11 Thread Tiago Vignatti
Hi Dima; comments below. On Sat, Jan 08, 2011 at 04:48:09PM -0800, ext Dima Ryazanov wrote: > > This is my first attempt at fixing a Wayland bug, as well as my first time > using Git. Hopefully, I'm doing it right :) I don't know how you generated the patch but it didn't apply okay for me. I gue

[PATCH] Add a missing NULL check for device->grab.

2011-01-08 Thread Dima Ryazanov
Hi everyone, This is my first attempt at fixing a Wayland bug, as well as my first time using Git. Hopefully, I'm doing it right :) Wayland compositor sometimes crashes if you start a client, move the client's window, then right-click and drag the empty space. Not sure if that's the correct solut