Re: [PATCH][weston] terminal: allow copy-paste when selection is scrolled out

2015-09-22 Thread Bryce Harrington
On Wed, Sep 23, 2015 at 03:31:04AM +0200, Manuel Bachmann wrote: > Hi Bryce, and thanks a lot for the review ! > > Of course I have tested it :) ; the steps are the following : > Copy some text in weston-terminal, scroll it out (by pressing [Enter] > repeatedly e.g.), try to paste. > It does work

Re: [PATCH][weston] terminal: allow copy-paste when selection is scrolled out

2015-09-22 Thread Manuel Bachmann
Hi Bryce, and thanks a lot for the review ! Of course I have tested it :) ; the steps are the following : Copy some text in weston-terminal, scroll it out (by pressing [Enter] repeatedly e.g.), try to paste. It does work with the patch only. 2015-09-23 2:10 GMT+02:00 Bryce Harrington : > On Sat

Re: [PATCH][weston] terminal: allow copy-paste when selection is scrolled out

2015-09-22 Thread Bryce Harrington
On Sat, Sep 19, 2015 at 01:51:05PM +0200, Manuel Bachmann wrote: > We could not paste text when its source went outside the > visible part of the buffer ; this is because we were > incorrectly assuming that our iterator should start at > row 0, while it could very well be negative. > > Signed-off-

[PATCH][weston] terminal: allow copy-paste when selection is scrolled out

2015-09-19 Thread Manuel Bachmann
We could not paste text when its source went outside the visible part of the buffer ; this is because we were incorrectly assuming that our iterator should start at row 0, while it could very well be negative. Signed-off-by: Manuel Bachmann --- clients/terminal.c | 2 +- 1 file changed, 1 insert