On Wed, Sep 23, 2015 at 11:05:31PM +0200, John-John Tedro wrote:
> On Tue, Sep 22, 2015 at 06:18:44PM -0700, Bryce Harrington wrote:
> > ivi_layout_transition_fade_layer() checks for null before making the
> > call, but this also needs done in create_visibility_transition(),
> > ivi_layout_transiti
On Tue, Sep 22, 2015 at 06:18:44PM -0700, Bryce Harrington wrote:
> ivi_layout_transition_fade_layer() checks for null before making the
> call, but this also needs done in create_visibility_transition(),
> ivi_layout_transition_move_resize_view(), and
> ivi_layout_transition_move_layer(). Or alte
I'm currently investigating.
I see two easy solutions, so please advice since I'm unfamiliar with
the requirements on IVI-based solutions.
1) Bail, easy and safe, but might not be desirable.
2) Immediately transition into the desired state on errors.
Slightly harder, but doable.
Examples for
On Tue, Sep 22, 2015 at 05:28:32PM -0700, Bryce Harrington wrote:
> On Sun, Sep 20, 2015 at 02:47:37AM +0200, John-John Tedro wrote:
> > create_layout_transition does not initialize is_transition_func.
> >
> > This patch initializes it to NULL.
> >
> > Signed-off-by: John-John Tedro
>
> Reviewe
On Tue, Sep 22, 2015 at 02:13:37AM +0200, John-John Tedro wrote:
> On Mon, Sep 21, 2015 at 09:33:29AM -0700, Bill Spitzak wrote:
> >=20
> > Maybe this should be using xzalloc, that seems to be the standard method =
> in
> > Weston
>
> Yikes.
>
> It looks like create_move_resize_view_transition (a
On Mon, Sep 21, 2015 at 09:33:29AM -0700, Bill Spitzak wrote:
> On Sat, Sep 19, 2015 at 5:47 PM, John-John Tedro
> wrote:
>
> > create_layout_transition does not initialize is_transition_func.
> >
> > This patch initializes it to NULL.
> >
> > Signed-off-by: John-John Tedro
> > ---
> > ivi-shel
On Sun, Sep 20, 2015 at 02:47:37AM +0200, John-John Tedro wrote:
> create_layout_transition does not initialize is_transition_func.
>
> This patch initializes it to NULL.
>
> Signed-off-by: John-John Tedro
Reviewed-by: Bryce Harrington
Btw, since this function sets nearly all the parameters t
On Mon, Sep 21, 2015 at 09:33:29AM -0700, Bill Spitzak wrote:
>=20
> Maybe this should be using xzalloc, that seems to be the standard method =
in
> Weston
Yikes.
It looks like create_move_resize_view_transition (and others?) returns
NULL on allocation failures, which is fed unchecked into
layout
On Sat, Sep 19, 2015 at 5:47 PM, John-John Tedro
wrote:
> create_layout_transition does not initialize is_transition_func.
>
> This patch initializes it to NULL.
>
> Signed-off-by: John-John Tedro
> ---
> ivi-shell/ivi-layout-transition.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a
create_layout_transition does not initialize is_transition_func.
This patch initializes it to NULL.
Signed-off-by: John-John Tedro
---
ivi-shell/ivi-layout-transition.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/ivi-shell/ivi-layout-transition.c
b/ivi-shell/ivi-layout-transition.c
ind
10 matches
Mail list logo
