Re: [PATCH]: mtdev could be disabled at configuration

2013-06-11 Thread Pekka Paalanen
On Tue, 11 Jun 2013 15:53:42 +0200 Marc Chalain wrote: > OK I used macro instead inline function. It's the same for the compiler (in > this case). > evdev: add --disable-mtdev option to configure and bypass the mtdev > functions when the library is not available. > > --- > configure.ac | 17 +

Re: [PATCH]: mtdev could be disabled at configuration

2013-06-11 Thread Marc Chalain
OK I used macro instead inline function. It's the same for the compiler (in this case). evdev: add --disable-mtdev option to configure and bypass the mtdev functions when the library is not available. --- configure.ac | 17 ++--- src/evdev.c |9 - 2 files changed, 22 in

Re: [PATCH]: mtdev could be disabled at configuration

2013-06-11 Thread Pekka Paalanen
On Tue, 11 Jun 2013 14:41:18 +0200 Marc Chalain wrote: > Hello > The detection of the library is automatically done during the > configuration. The option is not useful. > > And the use #ifdef HAVE_MTDEV seems to be simpler, if in the future this > feature will disappear. > > What I do ? I send

Re: [PATCH]: mtdev could be disabled at configuration

2013-06-11 Thread Marc Chalain
Hello The detection of the library is automatically done during the configuration. The option is not useful. And the use #ifdef HAVE_MTDEV seems to be simpler, if in the future this feature will disappear. What I do ? I send again or I increase the complexity. Marc. 2013/6/11 Benjamin Tissoires

Re: [PATCH]: mtdev could be disabled at configuration

2013-06-11 Thread Benjamin Tissoires
On Tue, Jun 11, 2013 at 12:40 PM, Pekka Paalanen wrote: > On Tue, 11 Jun 2013 12:10:05 +0200 > Benjamin Tissoires wrote: > >> On Tue, Jun 11, 2013 at 9:41 AM, Pekka Paalanen wrote: >> > On Tue, 11 Jun 2013 09:01:48 +0200 >> > Benjamin Tissoires wrote: >> > >> >> On Mon, Jun 10, 2013 at 8:42 AM,

Re: [PATCH]: mtdev could be disabled at configuration

2013-06-11 Thread Pekka Paalanen
On Tue, 11 Jun 2013 12:10:05 +0200 Benjamin Tissoires wrote: > On Tue, Jun 11, 2013 at 9:41 AM, Pekka Paalanen wrote: > > On Tue, 11 Jun 2013 09:01:48 +0200 > > Benjamin Tissoires wrote: > > > >> On Mon, Jun 10, 2013 at 8:42 AM, Pekka Paalanen > >> wrote: > >> > On Fri, 7 Jun 2013 12:11:14 +0

Re: [PATCH]: mtdev could be disabled at configuration

2013-06-11 Thread Benjamin Tissoires
On Tue, Jun 11, 2013 at 9:41 AM, Pekka Paalanen wrote: > On Tue, 11 Jun 2013 09:01:48 +0200 > Benjamin Tissoires wrote: > >> On Mon, Jun 10, 2013 at 8:42 AM, Pekka Paalanen wrote: >> > On Fri, 7 Jun 2013 12:11:14 +0200 >> > Marc Chalain wrote: >> > >> >> mtdev is not necessary on some device (d

Re: [PATCH]: mtdev could be disabled at configuration

2013-06-11 Thread Pekka Paalanen
On Tue, 11 Jun 2013 09:01:48 +0200 Benjamin Tissoires wrote: > On Mon, Jun 10, 2013 at 8:42 AM, Pekka Paalanen wrote: > > On Fri, 7 Jun 2013 12:11:14 +0200 > > Marc Chalain wrote: > > > >> mtdev is not necessary on some device (desktop or set-top-box). For > >> embedded solution the minimum of

Re: [PATCH]: mtdev could be disabled at configuration

2013-06-11 Thread Benjamin Tissoires
On Mon, Jun 10, 2013 at 8:42 AM, Pekka Paalanen wrote: > On Fri, 7 Jun 2013 12:11:14 +0200 > Marc Chalain wrote: > >> mtdev is not necessary on some device (desktop or set-top-box). For >> embedded solution the minimum of dependencies is required. "configure" >> accepts the --disable-mtdev option

Re: [PATCH]: mtdev could be disabled at configuration

2013-06-10 Thread Pekka Paalanen
On Mon, 10 Jun 2013 12:18:57 +0200 Marc Chalain wrote: > Linux kernel uses a lot of function pointers. And I'm looking this solution. Please, do not use function pointers here, that would be just an additional layer of indirection for no benefit, I believe. Also, reply after the quote, please.

Re: [PATCH]: mtdev could be disabled at configuration

2013-06-10 Thread Marc Chalain
Linux kernel uses a lot of function pointers. And I'm looking this solution. 2013/6/10 Pekka Paalanen > On Mon, 10 Jun 2013 09:47:32 +0200 > Marc Chalain wrote: > > > Hi Pekka, > > I agree with --disable-multitouch. > > For the comparison between the use of ifdef and no-op functions. I think >

Re: [PATCH]: mtdev could be disabled at configuration

2013-06-10 Thread Pekka Paalanen
On Mon, 10 Jun 2013 09:47:32 +0200 Marc Chalain wrote: > Hi Pekka, > I agree with --disable-multitouch. > For the comparison between the use of ifdef and no-op functions. I think > the second solution is ambiguous, we disable the feature in one side and we > use the API in the other side. > I loo

Re: [PATCH]: mtdev could be disabled at configuration

2013-06-10 Thread Marc Chalain
Hi Pekka, I agree with --disable-multitouch. For the comparison between the use of ifdef and no-op functions. I think the second solution is ambiguous, we disable the feature in one side and we use the API in the other side. I look if it's possible to have a third solution which satisfies every bod

Re: [PATCH]: mtdev could be disabled at configuration

2013-06-09 Thread Pekka Paalanen
On Fri, 7 Jun 2013 12:11:14 +0200 Marc Chalain wrote: > mtdev is not necessary on some device (desktop or set-top-box). For > embedded solution the minimum of dependencies is required. "configure" > accepts the --disable-mtdev option. Hi Marc, with this patch, if weston is compiled with --disab

[PATCH]: mtdev could be disabled at configuration

2013-06-07 Thread Marc Chalain
mtdev is not necessary on some device (desktop or set-top-box). For embedded solution the minimum of dependencies is required. "configure" accepts the --disable-mtdev option. weston-mtdev-disabled.patch Description: Binary data ___ wayland-devel mailing