Hello,
After a quick reading of your DevHelp case, I think the issue belong
devhelp and your app that using it. DevHelp have to provide an API to
be embeded in another application and Wayland protocol should not be
involved. Maybe d-bus can be used as pipe between DevHelp and others
applications.
Hello,
Maybe you are interrested in [1], but I do not maintain it for the
moment. It' Xnest for wayland, it's mostly based on Xwayland code, but
provide a root window.
Best regards.
[1] https://github.com/gschwind/xwlnest
Le vendredi 21 juillet 2017 à 10:30 +0300, Pekka Paalanen a éc
may already help.
That's an excellent idea! Could you recommend some, so I don't pick a
random "oh, but they're doing it wrong" video?
Thanks,
pq
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.fre
color data with the compositor and the topic about
how a software can perform calibration and profiling, even if I agree
that both are needed to have color-managed-monitors, both topic are
mostly orthogonal, imo.
my suggestion of title: "Enable color managed cli
Hello,
It's very difficult to contribute to this discussion, but here is my
delta contribution.
I agree with the following proposal with comment bellow.
On 19/12/2016 09:27, Carsten Haitzler (The Rasterman) wrote:
On Mon, 19 Dec 2016 17:01:50 +1100 Graeme Gill said:
at this point i'm
On 13/01/2017 15:17, Pekka Paalanen wrote:
the calibrating or monitor profiling process (are these the same thing?)
As far as I know, no they are different, calibrating a monitor is the
attempt to set cLUT and monitor setting to be close to a given target,
often a given color space with a
etry is not required.
"MUST" have a strong meaning within specification.
Another thing is "Resizing is initiated by the compositor only" is just
useless, the compositor is free to ignore move/resize request from clients.
Taken all comment above you get :
A "tiled" st
though (telling
> clients whether to draw the maximize icon or not).
>
>>
>> To me, these should be compositor-specific actions, rather than something
>> clients are aware of. IMO, tiling is also “the compositor knows better”, and
>> thus the client should not initiate
: Benoit Gschwind
---
libweston/compositor-x11.c | 27 +--
1 file changed, 13 insertions(+), 14 deletions(-)
diff --git a/libweston/compositor-x11.c b/libweston/compositor-x11.c
index b6acccd..5d063b5 100644
--- a/libweston/compositor-x11.c
+++ b/libweston/compositor-x11.c
The "state" variable in x11_backend_deliver_button_event is basically the
same as (event->response_type == XCB_BUTTON_PRESS), thus update the code
to use the last one.
Signed-off-by: Benoit Gschwind
---
libweston/compositor-x11.c | 21 ++---
1 file changed, 10 inse
v3:
- change the patch log of patch 3
v2:
- fix assert to comply weston coding style.
v1:
- add some sanity checking,
- remove redundant viarable,
- use a better X11 passive grab
Benoit Gschwind (3):
compositor-x11: add assert to avoid misuse of
x11_backend_deliver_button_event
The x11_backend_deliver_button_event can be called with any
xcb_generic_event. The assert check if the call is done with the
expected events.
Signed-off-by: Benoit Gschwind
---
libweston/compositor-x11.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/libweston/compositor-x11.c b
n get case where my mouse event are just ignored in the
x11-backend. I the point of view of the user the backend is frozen.
I will update the patch log.
Best regard
On 23/06/2016 09:55, Daniel Stone wrote:
> Hi,
>
> On 19 May 2016 at 05:32, Benoit Gschwind wrote:
>> In current co
doesn't matter.
Tested-by: Benoit Gschwind
Ack-by: Benoit Gschwind
Best regards.
On 22/06/2016 14:28, Quentin Glidic wrote:
> On 22/06/2016 13:44, Pekka Paalanen wrote:
>> On Thu, 9 Jun 2016 15:20:35 +0300
>> Pekka Paalanen wrote:
>>
>>> From: Pekka Paalan
Hello,
The reply from Pekka is about compositor using a client to make the
rendering, but I not sure this is what you asking for.
Are you talking about building a compositor ? It look like you are
making a wayland client that try to delegate the drawing to a thread. Is
it what you want to do ?
B
>
> -
> -
> +
>
>
>
> @@ -724,7 +953,7 @@
> button press, key press, or touch down event. The serial number of the
> event should be passed as 'serial'.
>
> - The parent of a grabbing popup must
stroyed automatically by clients. Thus yes in both case the
client can grab mouse pointer indefinitely if the compositor doesn't
provide a "force cancel grab" mechanism like a bind to ESC key.
The draft is simple to explain and simple to implement.
Best regards.
--
Benoit Gschwi
Hello Jonas,
Fine for me.
Reviewed-by: Benoit Gschwind
Best regards
On 26/05/2016 06:32, Jonas Ådahl wrote:
> The reason for using wl_surface before was that xdg_popup and
> xdg_surface (now xdg_toplevel) had no common interface other than
> wl_surface, but since xdg_surface is now
Hello Jonas,
This one do what it tell.
Reviewed-by: Benoit Gschwind
Best regards.
On 26/05/2016 06:32, Jonas Ådahl wrote:
> The long lines stood out, break them by putting the summary on its own
> line.
>
> Signed-off-by: Jonas Ådahl
> Reviewed-by: Yong Bakos
>
configure the state of the surface but doesn't
> + have any information about any previous or expected dimension.
> +
> + The states listed in the event specify how the width/height
> + arguments should be interpreted, and possibly how it should be
Hello Jonas,
On 08/06/2016 03:18, Jonas Ådahl wrote:
> On Wed, Jun 08, 2016 at 12:37:01AM +0200, Benoit Gschwind wrote:
>> Hello,
>>
>> This proposal look good, few optional comments following.
>>
>> On 26/05/2016 06:32, Jonas Ådahl wrote:
>>> Split ou
nts are in window geometry coordinates.
> - See set_window_geometry.
> + See xdg_surface.set_window_geometry.
>
> Values set in this way are double-buffered. They will get applied
> on the next commit.
> @@ -488,7 +543,7 @@
> not try to config
semantic state to be a /semantic
state/: see activated state above.
>> I think we should think about window state once more :D
>
> I reckon the current states as defined in xdg-shell are commonly understood,
> established and accepted betwee
eate a new list, it's better isn't it ?"
This is my opinion.
Best regards.
On 07/06/2016 10:59, Jonas Ådahl wrote:
> On Tue, Jun 07, 2016 at 10:47:13AM +0200, Benoit Gschwind wrote:
>> Hello Olivier
>>
>> On 07/06/2016 10:30, Olivier Fourdan wrote:
cult to draw a line between draw states and "behaviors"
states, they are linked.
I think we should think about window state once more :D
> Cheers,
> Olivier
> ___
> wayland-devel mailing list
> wayland-de
Hello Matthias,
I agree the two reply from Jonas, and Olivier.
I just add to Olivier comment, that even we tried to remove MWM hints
(i.e. they do not belong any up-to-date standards), they are still used
by up-to-date software and implemented by popular WMs. This use case
show that (1) those hin
sprintf can overflow the fixed length title which is char[32]. This
patch change title to dynamically allocated char array using asprintf or
strdup. If one of them fail we leave returning NULL to indicate the
failure.
Signed-of-by: Benoit Gschwind
---
v3:
- fix xcb_destroy_window arguments
v2
sprintf can overflow the fixed length title which is char[32]. This
patch change title to dynamically allocated char array using asprintf or
strdup. If one of them fail we leave returning NULL to indicate the
failure.
Signed-of-by: Benoit Gschwind
---
src/compositor-x11.c | 28
Hello Yong,
Thanks for the review.
On 05/06/2016 17:47, Yong Bakos wrote:
> Hi Benoit,
> Other than the comments inline below, this patch is
> Reviewed-by: Yong Bakos
> Tested-by: Yong Bakos
>
> On Jun 4, 2016, at 9:08 AM, Benoit Gschwind wrote:
>>
>> ---
>
---
src/compositor-x11.c | 29 -
1 file changed, 20 insertions(+), 9 deletions(-)
diff --git a/src/compositor-x11.c b/src/compositor-x11.c
index 629b5f3..a518820 100644
--- a/src/compositor-x11.c
+++ b/src/compositor-x11.c
@@ -782,7 +782,7 @@ x11_backend_create_output(
Hello,
For reference this discussion was split from [1]. Note also I did this
comment in the thread [2].
And I reiterate that we are making :
- _NET_SUPPORTED [3],
- _NET_WM_ALLOWED_ACTIONS [4]
- and _NET_WM_STATE [5].
So why not drafting from the existing and improve it ?
[1]
https://list
Hello Jonas,
The things I see for maximized vs. tilling:
- tilling window does not need a unmaximize button, because they are
not maximized;
- tilling window may want to switch maximized and draw the
corresponding button;
- tilling window may not need close button to be drawn.
We will quickly
mean separating them does not improve the situation.
Keeping them together just avoid long discussion on which side they must
go state or drawing state?
On 31/05/2016 23:04, Derek Foreman wrote:
> On 31/05/16 02:31 PM, Benoit Gschwind wrote:
>> Hello mike,
>>
>> Thank for yo
Hello mike,
Thank for your clarification, I try to summarize the issue/need:
A compositor may want to draw a client without the shadow. In particular
if the window is integrated to a GUI component, I can imagine tilling.
Taking your issue, the drawing state look very similar to the state
flags.
ill prefer the EWMH
> approach to the MWM hints ^_~
>
> Back to the topic...
>
> - Original Message -
>> On Tue, May 31, 2016 at 10:31:28AM +0200, Benoit Gschwind wrote:
>>> Hello Jonas, Mike and Olivier,
>>>
>>> [...]
>>>> I s
On 31/05/2016 10:53, Jonas Ådahl wrote:
> On Tue, May 31, 2016 at 10:31:28AM +0200, Benoit Gschwind wrote:
>> Hello Jonas, Mike and Olivier,
>>
>> On 30/05/2016 15:09, Olivier Fourdan wrote:
>>> Hi Jonas,
>>>
>>> - Original Message -
>&g
for surfaces placed next to the edge of a monitor in a
> multi-monitor setup for example (so we don't have shadows crossing monitors
> for example) - Maybe it's just overkill, dunno.
>
> We could also consider "no border", again, per edge as well. Or not.
>
This last comments look to overlap with some already existing feature
within the protocol, I think about the input shape.
Also, because the issue is not well described the discussion overflow to
severals other issues.
> Cheers,
> Olivier
>
>
> ___
> wayland-devel mailing list
> wayland-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/wayland-devel
>
Best regards
--
Benoit Gschwind
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel
Hello Mike and Jonas,
I wonder why ?
I do not saying you proposal is useless, but any proposal should solve
an issue or add a feature to be discussed. In both case, I think a
proposal must provide an explanation of why this proposal.
This may be obvious for you but it might be not so obvious. An
Hello Olivier,
You should keep an eye on libweston :)
Best regards
Le 20/05/2016 10:33, Olivier Fourdan a écrit :
> Hi,
>
> On 12 May 2016 at 00:35, ade low wrote:
>> [...]
>> It is important that it is a standard, cross-compositor protocol. For
>> example, if I am using my app on "xfwm-wayla
Hello Giulio,
With this patch, and mine to fix MODULEDIR of patch #2, this patch does
not build due to incomplete type:
src/screenshooter.c:46:24: error: field 'process' has incomplete type
struct weston_process process;
The patch look fine, if I ignore this building error, I also saw a lot
of
t; + *
> + * The above copyright notice and this permission notice (including the
> + * next paragraph) shall be included in all copies or substantial
> + * portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> + * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS
> + * BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
> + * ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
> + * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
> + * SOFTWARE.
> + */
> +
> +#ifndef WESTON_H
> +#define WESTON_H
> +
> +#ifdef __cplusplus
> +extern "C" {
> +#endif
> +
> +void *
> +load_weston_module(const char *name, const char *entrypoint);
> +
> +#ifdef __cplusplus
> +}
> +#endif
> +
> +#endif
> diff --git a/src/weston.pc.in b/src/weston.pc.in
> index c560eb3..f2ffc9e 100644
> --- a/src/weston.pc.in
> +++ b/src/weston.pc.in
> @@ -9,4 +9,4 @@ Name: Weston Plugin API
> Description: Header files for Weston plugin development
> Version: @WESTON_VERSION@
> Requires.private: wayland-server pixman-1 xkbcommon
> -Cflags: -I${includedir}
> +Cflags: -I${includedir}/weston
> -I{includedir}/libweston-@LIBWESTON_ABI_VERSION@
>
Best regard
--
Benoit Gschwind
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel
Hello Giulio,
The patch do what it describe.
Reviewed-by: Benoit Gschwind
On 24/05/2016 18:59, Giulio Camuffo wrote:
> ---
> src/input.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/input.c b/src/input.c
> index 8fe898c..c6cdedd 100644
&
The x11_backend_deliver_button_event can be called with any
xcb_generic_event. The assert check if the call is done with the
expected events.
Signed-off-by: Benoit Gschwind
---
src/compositor-x11.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/compositor-x11.c b/src/compositor-x11
automatically grab buttons as soon as they occur. The passive grab
include an automatic ungrab when all mouse button are released.
This probably fix some mysterious bugs.
Signed-off-by: Benoit Gschwind
---
src/compositor-x11.c | 27 +--
1 file changed, 13 insertions(+), 14 deletions
The "state" variable in x11_backend_deliver_button_event is basically the
same as (event->response_type == XCB_BUTTON_PRESS), thus update the code
to use the last one.
Signed-off-by: Benoit Gschwind
---
src/compositor-x11.c | 21 ++---
1 file changed, 10 inse
v2:
- fix assert to comply weston coding style.
v1:
- add some sanity checking,
- remove redundant viarable,
- use a better X11 passive grab
Benoit Gschwind (3):
compositor-x11: add assert to avoid misuse of
x11_backend_deliver_button_event
compositor-x11: remove redundant state arg
being
> passed to another client.
>
>
> On Fri, May 13, 2016 at 4:34 AM, Benoit Gschwind <mailto:gschw...@gnu-log.net>> wrote:
>
> In current compositor-x11, the mouse buttons are grabbed and ungrabbed
> manually that may produce weird cases like starting a grab
Hello Pekka,
Look sane.
Reviewed-by: Benoit Gschwind
On 13/05/2016 13:38, Pekka Paalanen wrote:
> From: Pekka Paalanen
>
> I was confused why timestamp was printed negative. This fixes it, and
> others while at it.
>
> Signed-off-by: Pekka Paalanen
> ---
>
v1:
- add some sanity checking,
- remove redundant viarable,
- use a better X11 passive grab
Benoit Gschwind (3):
compositor-x11: add assert to avoid misuse of
x11_backend_deliver_button_event
compositor-x11: remove redundant state arg of
x11_backend_deliver_button_event
automatically grab buttons as soon as they occur. The passive grab
include an automatic ungrab when all mouse button are released.
This probably fix some mysterious bugs.
Signed-off-by: Benoit Gschwind
---
src/compositor-x11.c | 27 +--
1 file changed, 13 insertions(+), 14 deletions
The "state" variable in x11_backend_deliver_button_event is basically the
same as (event->response_type == XCB_BUTTON_PRESS), thus update the code
to use the last one.
Signed-off-by: Benoit Gschwind
---
src/compositor-x11.c | 21 ++---
1 file changed, 10 inse
The x11_backend_deliver_button_event can be called with any
xcb_generic_event. The assert check if the call is done with the
expected events.
Signed-off-by: Benoit Gschwind
---
src/compositor-x11.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/compositor-x11.c b/src/compositor-x11.c
Hello Pekka,
Reviewed-by: Benoit Gschwind
Tested-by: Benoit Gschwind
just in case, If you apply my suggestion for the previous patch, this
patch may be useless.
Best regards,
Benoit Gschwind
On 10/05/2016 16:11, Pekka Paalanen wrote:
> From: Pekka Paalanen
>
> Zero-initialize t
Hello Pekka,
Reviewed-by: Benoit Gschwind
Tested-by: Benoit Gschwind
That surprising that the log_axis was not used here :)
Best regards,
Benoit Gschwind
On 10/05/2016 16:11, Pekka Paalanen wrote:
> From: Pekka Paalanen
>
> Signed-off-by: Pekka Paalanen
> ---
> clients/
Hello Pekka,
as-is you get my:
Reviewed-by: Benoit Gschwind
Tested-by: Benoit Gschwind
But I have comments that may be worth to read :)
On 10/05/2016 16:11, Pekka Paalanen wrote:
> From: Pekka Paalanen
>
> Print pointer frames only if any pointer related events are printe
ibweston implementation
detail to weston-0.
Outside this comments the patch is working and is making what he claim.
I did not already tested to create a compositor from the library. But
it's probably something we can tackle later.
Tested-by: Benoit Gschwind
Best regards.
[1] https://pe
variables as suggested by Pekka
Benoit Gschwind (14):
compositor-wayland: fix spacing and lines wraping
compositor-wayland: fix too long lines
compositor-wayland: rename wayland_output_init_from_config
compositor-wayland: rename misleading output arg of
weston_wayland_output_config_init
Rename new_config to config to follow legacy naming scheme.
Signed-off-by: Benoit Gschwind
---
src/main.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/main.c b/src/main.c
index 285a10d..d0a962f 100644
--- a/src/main.c
+++ b/src/main.c
@@ -1104,18 +1104,18
Rename new_config to config to follow legacy naming scheme.
Signed-off-by: Benoit Gschwind
---
src/main.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/main.c b/src/main.c
index e28a576..285a10d 100644
--- a/src/main.c
+++ b/src/main.c
@@ -1086,16 +1086,16
Signed-off-by: Benoit Gschwind
---
src/compositor-wayland.c | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c
index d0d1082..9351687 100644
--- a/src/compositor-wayland.c
+++ b/src/compositor-wayland.c
Rename the out_config arg of load_wayland_backend_config to follow
legacy naming convention.
Signed-off-by: Benoit Gschwind
---
src/main.c | 42 +-
1 file changed, 21 insertions(+), 21 deletions(-)
diff --git a/src/main.c b/src/main.c
index e03bde7
Remove the unseless intermediate variable new_config in the function
load_wayland_backend_config, replacing it by the existing variable
out_config.
Signed-off-by: Benoit Gschwind
---
src/main.c | 44
1 file changed, 20 insertions(+), 24 deletions
Rename wayland_output_init_from_config to weston_wayland_output_config_init
to prepare the following patch :
"compositor-wayland: move configuration parsing to weston"
Signed-off-by: Benoit Gschwind
---
src/compositor-wayland.c | 16 ++--
1 file changed, 10 insert
Signed-off-by: Benoit Gschwind
---
src/main.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/src/main.c b/src/main.c
index d0a962f..06baae3 100644
--- a/src/main.c
+++ b/src/main.c
@@ -1170,7 +1170,7 @@ load_wayland_backend_config(struct weston_compositor
Rename the misleading output argument to output_config in the
weston_wayland_output_config_init function.
Signed-off-by: Benoit Gschwind
---
src/compositor-wayland.c | 38 +++---
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/src/compositor
The patch use temporary code that prepare the patch:
"compositor-wayland: move configuration parsing to weston main.c"
Signed-off-by: Benoit Gschwind
---
src/compositor-wayland.c | 29 ++---
src/compositor-wayland.h | 3 +++
2 files changed, 29 insert
Rename the wayland_backend_config_release function to
weston_wayland_backend_config_release to follow legacy naming scheme.
Signed-off-by: Benoit Gschwind
---
src/main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/main.c b/src/main.c
index 28e7e1d..e03bde7
Rename the load_wayland_backend_config arg "config" to use this name for
another variable in the following patch. It also follow the legacy
naming scheme.
Signed-off-by: Benoit Gschwind
---
src/main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/ma
-off-by: Benoit Gschwind
---
src/compositor-wayland.c | 224 -
src/main.c | 232 +++
2 files changed, 232 insertions(+), 224 deletions(-)
diff --git a/src/compositor-wayland.c b/src/compositor
Rename wayland_backend_config_add_new_output to
weston_wayland_backend_config_add_new_output to follow the legacy naming
scheme.
Signed-off-by: Benoit Gschwind
---
src/main.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/main.c b/src/main.c
index 231f1b9
Signed-off-by: Benoit Gschwind
---
src/compositor-wayland.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c
index 9351687..4799f90 100644
--- a/src/compositor-wayland.c
+++ b/src/compositor-wayland.c
@@ -2347,9 +2347,10
Hello Bryce,
Ok I can live with this patches ;)
Reviewed-by: Benoit Gschwind
On 05/05/2016 00:24, Bryce Harrington wrote:
> On Sat, Apr 30, 2016 at 11:41:15AM +0200, Benoit Gschwind wrote:
>> Hello Bryce,
>>
>> I think my comments on previous patch apply here, while y
Hello Pekka,
I submitted a patches set (v3) to address all comments.
Best regards.
On 04/05/2016 15:41, Pekka Paalanen wrote:
> On Thu, 28 Apr 2016 20:33:16 +0200
> Benoit Gschwind wrote:
>
>> Move all parsing functions from the wayland backend and put
>> them into th
v3:
- rebase to master
- heavy patches spliting to help review as suggested by Pekka
- fix typo.
- rename functions and variables as suggested by Pekka
Benoit Gschwind (17):
compositor-wayland: fix misc. typo
compositor-wayland: add versionning to config structure
compositor-wayland
Rename compositor to c in load_wayland_backend function.
Signed-off-by: Benoit Gschwind
---
src/main.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/main.c b/src/main.c
index 92b7ac2..a84bdeb 100644
--- a/src/main.c
+++ b/src/main.c
@@ -1040,7 +1040,7
functions. Update the code to
properly load the backend as others backends.
Signed-off-by: Benoit Gschwind
---
src/compositor-wayland.c | 215 -
src/main.c | 223 ++-
2 files changed, 221 insertions
Rename config to wc in load_wayland_backend function.
Signed-off-by: Benoit Gschwind
---
src/main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/main.c b/src/main.c
index a84bdeb..2ff8cd7 100644
--- a/src/main.c
+++ b/src/main.c
@@ -1041,7 +1041,7
Rename new_config to config in wayland_backend_create function.
Signed-off-by: Benoit Gschwind
---
src/compositor-wayland.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c
index 140b11d..133bd37 100644
--- a/src
Signed-off-by: Benoit Gschwind
---
src/compositor-wayland.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c
index d0d1082..83f31de 100644
--- a/src/compositor-wayland.c
+++ b/src/compositor-wayland.c
@@ -2328,6 +2328,7
Rename wayland_backend_config_release to weston_wayland_backend_config_release.
Signed-off-by: Benoit Gschwind
---
src/main.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/main.c b/src/main.c
index 5b8eb80..adaebf7 100644
--- a/src/main.c
+++ b/src/main.c
Rename wayland_backend_config_add_new_output to
weston_wayland_backend_config_add_new_output.
Signed-off-by: Benoit Gschwind
---
src/main.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/main.c b/src/main.c
index 55ecc08..2e5c743 100644
--- a/src/main.c
+++ b
Rename the missleading output to output_config.
Signed-off-by: Benoit Gschwind
---
src/compositor-wayland.c | 38 +++---
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c
index 2822a09..53f855d
Rename unused variable config to wc in backend_init function.
Signed-off-by: Benoit Gschwind
---
src/compositor-wayland.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c
index 133bd37..67d20d0 100644
--- a/src/compositor
Rename new_config to config in backend_init function.
Signed-off-by: Benoit Gschwind
---
src/compositor-wayland.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c
index 67d20d0..335b70e 100644
--- a
Signed-off-by: Benoit Gschwind
---
src/compositor-wayland.c | 27 ---
src/compositor-wayland.h | 3 +++
2 files changed, 27 insertions(+), 3 deletions(-)
diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c
index 83f31de..b51467d 100644
--- a/src/compositor
Rename wayland_output_config_init to weston_wayland_output_config_init.
Signed-off-by: Benoit Gschwind
---
src/main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/main.c b/src/main.c
index adaebf7..55ecc08 100644
--- a/src/main.c
+++ b/src/main.c
@@ -957,7 +957,7
Rename new_config to config in wayland_backend_config_add_new_output
function.
Signed-off-by: Benoit Gschwind
---
src/main.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/main.c b/src/main.c
index 8d42ec5..3d643f1 100644
--- a/src/main.c
+++ b/src/main.c
Rename variable new_config to config in load_wayland_backend function.
Signed-off-by: Benoit Gschwind
---
src/main.c | 54 +++---
1 file changed, 27 insertions(+), 27 deletions(-)
diff --git a/src/main.c b/src/main.c
index 2ff8cd7..8d42ec5 100644
Rename new_config to config in wayland_backend_config_release function.
Signed-off-by: Benoit Gschwind
---
src/main.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/main.c b/src/main.c
index 3d643f1..5b8eb80 100644
--- a/src/main.c
+++ b/src/main.c
Remove argv, argc and weston_config from wayland_backend_create
function.
Signed-off-by: Benoit Gschwind
---
src/compositor-wayland.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c
index fe8b082..140b11d 100644
--- a
Rename wayland_output_init_from_config to wayland_output_config_init.
Signed-off-by: Benoit Gschwind
---
src/compositor-wayland.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c
index b51467d..2822a09 100644
--- a/src
Hello Yong,
Thanks, I will fix this in next version after few more review :)
Best regards.
Le 29/04/2016 03:38, Yong Bakos a écrit :
> On Apr 28, 2016, at 1:33 PM, Benoit Gschwind wrote:
>>
>> Extract configuration parsing from init_backend function. The new
>> init_backen
Hello Bryce,
I think my comments on previous patch apply here, while you did some
useful update here.
Best regards.
Le 30/04/2016 00:40, Bryce Harrington a écrit :
> The drm backend was copying most everything out of the config object
> already, but now also copy the use_current_mode parameter a
Hello Bryce,
I have some comments after a trivial rebase.
Le 30/04/2016 00:40, Bryce Harrington a écrit :
> From: Giulio Camuffo
>
> Signed-off-by: Bryce Harrington
> Reviewed-by: Quentin Glidic
> Acked-by: Pekka Paalanen
> Tested-by: Benoit Gschwind
>
> Signed-
Hello Bryce,
It's look the you use space within Makefile.am instead of tabulation.
Le 30/04/2016 10:30, Benoit Gschwind a écrit :
> Hello Bryce,
>
> It look good after trivial rebase to master.
>
> Reviewed-by: Benoit Gschwind
> Tested-by: Benoit Gschwind
>
&g
Hello Bryce,
It look good after trivial rebase to master.
Reviewed-by: Benoit Gschwind
Tested-by: Benoit Gschwind
Le 30/04/2016 00:40, Bryce Harrington a écrit :
> From: Benoit Gschwind
>
> Use a "well" defined structure to configure x11-backend and move configuration
&g
Signed-off-by: Benoit Gschwind
---
v1:
- fix missing file
- update Makefile.am
Makefile.am | 3 +++
src/compositor-rpi.c | 42 --
src/compositor-rpi.h | 49 +
src/main.c | 40
Signed-off-by: Benoit Gschwind
---
v1:
- fix warning for freeing a const
- fix typo
src/main.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/src/main.c b/src/main.c
index f034dda..404e5fc 100644
--- a/src/main.c
+++ b/src/main.c
@@ -692,7 +692,7
Signed-off-by: Benoit Gschwind
---
NOTE: The patch is theorical and wasn't tested on rasbery-pi
src/compositor-rpi.c | 42 --
src/main.c | 40 ++--
2 files changed, 54 insertions(+), 28 deletions(-)
Signed-off-by: Benoit Gschwind
---
src/main.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/src/main.c b/src/main.c
index f034dda..9c15b71 100644
--- a/src/main.c
+++ b/src/main.c
@@ -692,7 +692,7 @@ load_headless_backend(struct weston_compositor *c, char
const
1 - 100 of 159 matches
Mail list logo
