al seat name that this output should be associated with. If this
Reviewed-by: Yong Bakos
Cheers,
yong
> is set then the seat's input will be confined to the output that has the seat
> set on it. The expectation is that this functionality will be used in a
> multiheaded en
gt; Making it easier to read and track.
>
> Signed-off-by: Emil Velikov
This is the only other lingering type dependency in wayland-cursor.c coming
from wayland-client.h et al. So, similar to the wl_shm forward
declaration, this new declaration indeed makes the header self-contained.
dding the axis motion direction, we can have toolkits swap the scroll
> direction for applicable widgets, getting the right behavior on all widgets.
>
> Signed-off-by: Peter Hutterer
Other than two minor nits noted below. This is:
Reviewed-by: Yong Bakos
But others will certainl
Hi Jonas,
Regarding renaming,
> On May 24, 2017, at 2:35 AM, Jonas Ådahl wrote:
>
> Hi,
>
> I think it is time to take the next step regarding xdg_shell: declaring it
> stable. The current unstable version (xdg_shell unstable v6) has been
> implemented in multiple code bases, used by multiple d
these methods, and
while I did spend some time with each, someone else should probably
chime in to verify.
There are just a few minor nits, inline below, at:
- wl_event_source_fd_update
- wl_event_source_check
- wl_event_loop_create
Reviewed-by: Yong Bakos
Regards,
yong
> ---
> d
the warning by making the comment less elaborate.
>
> Signed-off-by: Daniel Stone
This mere comment change seems innocuous enough.
(Should the standard `__attribute__ ((fallthrough))` be used instead?)
Reviewed-by: Yong Bakos
yong
> ---
> src/scanner.c | 4 +---
> 1 file changed,
hey can be used internally. Otherwise we'll
> end up with link errors.
>
> v2: Rebase.
>
> Signed-off-by: Emil Velikov
While others will certainly have to chime in and approve
patches 2 - 4, the remainder of this series is
Reviewed-by: Yong Bakos
Tested-by: Yo
Hi Pekka,
One misspelling and some minor writing nits noted inline below.
> On Jan 30, 2017, at 6:55 AM, Pekka Paalanen wrote:
>
> From: Pekka Paalanen
>
> This is a rough intro to what Xwayland is and does, with just one
> implementation detail so far (Window identification).
>
> I paid no
FAQ has raised some questions with
> lawyers, too. It's just misleading.
>
> While at it, make it more clear which MIT license we refer to.
>
> Signed-off-by: Pekka Paalanen
Reviewed-by: Yong Bakos
yong
> ---
> faq.html | 4 ++--
> 1 file changed, 2 insertions(+
and
> expect an object from it.
>
> https://bugs.freedesktop.org/show_bug.cgi?id=99899
>
> Signed-off-by: Carlos Garnacho
Reviewed-by: Yong Bakos
Thank you!
yong
> ---
> tests/connection-test.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git
From: Yong Bakos
Signed-off-by: Yong Bakos
---
src/dtddata.S | 35 +++
1 file changed, 19 insertions(+), 16 deletions(-)
diff --git a/src/dtddata.S b/src/dtddata.S
index ce51133..2405066 100644
--- a/src/dtddata.S
+++ b/src/dtddata.S
@@ -1,23 +1,26
Hi Pekka,
> On Jan 25, 2017, at 4:32 AM, Pekka Paalanen wrote:
>
> From: Pekka Paalanen
>
> Fix this set of warnings appearing three times during a build:
>
> /home/pq/git/wayland/src/wayland-server.c:1868: warning: class
> `wl_priv_signal' for related function `wl_priv_signal_init' is not
>
e other functions did not
> appear there.
>
> Signed-off-by: Pekka Paalanen
Forgot to add:
Reviewed-by: Yong Bakos
yong
> ---
> src/wayland-server.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/src/wayland-server.c b/src/wayland-ser
From: Yong Bakos
Signed-off-by: Yong Bakos
---
unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml | 38 ++
1 file changed, 18 insertions(+), 20 deletions(-)
diff --git a/unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml
b/unstable/linux-dmabuf/linux-dmabuf-unstable-v1
From: Yong Bakos
Signed-off-by: Yong Bakos
---
v2: Add commit message prefix.
src/dtddata.S | 35 +++
1 file changed, 19 insertions(+), 16 deletions(-)
diff --git a/src/dtddata.S b/src/dtddata.S
index ce51133..2405066 100644
--- a/src/dtddata.S
+++ b/src
From: Yong Bakos
A handful of source files were not using the MIT Expat text in
COPYING. Update these files to bring them inline with the rest,
standardizing on the MIT Expat text.
Signed-off-by: Yong Bakos
---
v2: Add commit message prefix.
clients/simple-dmabuf-intel.c | 35
From: Yong Bakos
A handful of source files were not using the MIT Expat text in
COPYING. Update these files to bring them inline with the rest,
standardizing on the MIT Expat text.
Signed-off-by: Yong Bakos
---
clients/simple-dmabuf-intel.c | 35
From: Yong Bakos
Signed-off-by: Yong Bakos
---
src/dtddata.S | 35 +++
1 file changed, 19 insertions(+), 16 deletions(-)
diff --git a/src/dtddata.S b/src/dtddata.S
index ce51133..2405066 100644
--- a/src/dtddata.S
+++ b/src/dtddata.S
@@ -1,23 +1,26
Hi Pekka,
> On Jan 23, 2017, at 12:42 AM, Pekka Paalanen wrote:
>
> On Fri, 20 Jan 2017 06:51:16 -0800
> Yong Bakos wrote:
>
>>> +
>>> +
>>> +
>>> +Copyright © 2017 Drew DeVault
>>> +
>>> +Permission to u
ibc, which breaks the build.
>
> Add the missing header.
>
> Signed-off-by: "Yann E. MORIN"
Seems harmless enough.
Reviewed-by: Yong Bakos
yong
> ---
> tests/string-test.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/string-test.c b/tests/s
Hi Drew,
Some nits and errors indicated inline below.
Across the board, would be nice to have summary attributes where they
are missing.
> On Jan 7, 2017, at 11:27 AM, Drew DeVault wrote:
>
> Signed-off-by: Drew DeVault
> ---
> Changes based on the (minimal) discussion this patch has recieved
-by: Peter Hutterer
This indeed removes the temporary, contrived `since` attribute and uses the
newly-existing since attribute of the wheel_tilt enum entry as the output
under test.
Reviewed-by: Yong Bakos
Tested-by: Yong Bakos
yong
> ---
> Changes to v1:
> - new in this series
&
Signed-off-by: Peter Hutterer
> Reviewed-by: Jonas Ådahl
> Acked-by: Daniel Stone
> ---
This protocol wheel tilt axis source addition, with since attribute, is:
Reviewed-by: Yong Bakos
yong
> Changes to v1:
> - more commit message goodness
> - sync the test-scanner
atter for the output, it's just warnings, hence why they're
> skipped here.
>
> Signed-off-by: Peter Hutterer
This addition of the struct entry `since` member, with corresponding generation
and testing are:
Reviewed-by: Yong Bakos
Tested-by: Yong Bakos
yong
> -
Peter,
> On Jan 11, 2017, at 4:13 PM, Peter Hutterer wrote:
>
> Same code we already had, just moved into a helper function
>
> Signed-off-by: Peter Hutterer
> Reviewed-by: Yong Bakos
No change from v1 here and so remains
Reviewed-by: Yong Bakos
Tested-by: Yong Bakos
ion
>
> and a few other, smaller ones.
>
> Signed-off-by: Peter Hutterer
This brings the test xml files up to date for consistency, and is:
Reviewed-by: Yong Bakos
Tested-by: Yong Bakos
yong
PS. How did you notice this?
> ---
> Changes to v1:
> - new in this series
rmat' event from zwp_linux_dmabuf_v1
> version 1.
>
> bump zwp_linux_dmabuf_v1, zwp_linux_buffer_params_v1 interface
> versions to 3.
>
> v2: specify request name in event description for clarity (Yong Bakos)
> v3: grammar fixup (Yong Bakos)
> v4: add deprecation warning a
Hi Rohith,
> On Jan 17, 2017, at 11:41 AM, Rohith Mukku wrote:
>
> Signed-off-by: Rohith Mukku
These spelling and grammar changes in comment blocks are
Reviewed-by: Yong Bakos
yong
> ---
> src/libinput.h | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
Hi Peter,
> On Jan 9, 2017, at 7:27 PM, Peter Hutterer wrote:
>
> This was already in the DTD but not supported by the scanner.
>
> The request/event parsing have an additional check that "since" cannot be <
> interface version. This is missing here. For requests/events we can rely on
> the xml
| 4 ++--
> xwayland/window-manager.c | 2 +-
> 18 files changed, 25 insertions(+), 25 deletions(-)
>
> --
> 1.9.1
This entire series correctly fixes spelling and grammar in
numerous comment blocks and log/error message string values.
Reviewed-by: Y
> abort with a cryptic message.
>
> Instead the client will now be disconnected as it is when the compositor
> tries to send a null for a non-nullable object, and a log message
> will be printed by the compositor.
>
> Signed-off-by: Derek Foreman
Reviewed-by: Yong Bakos
yong
Hi Derek,
> On Dec 8, 2016, at 11:36 AM, Derek Foreman wrote:
>
> Check that all the objects in an event belong to the same client as
> the resource posting it. This prevents a compositor from accidentally
> mixing client objects and posting an event that causes a client to
> kill itself.
>
>
From: Yong Bakos
Despite their clear names, wl_array and wl_list members are undocumented,
resulting in doxygen warnings[1] when building documentation.
Document these members, suppressing the warnings.
[1] Warnings are visible when EXTRACT_ALL = NO.
Signed-off-by: Yong Bakos
---
src
Hi Carlos,
> On Nov 23, 2016, at 9:32 AM, Carlos Garnacho wrote:
>
> The leave events in the respective device interfaces has been further
> documented so those can convey the necessary info when input is being
> redirected out of their currently focused surface.
>
> Only wl_touch is missing so
Hi David,
> On Dec 2, 2016, at 7:48 PM, David Piper wrote:
>
> Hi all,
>
> I'm jumping back into the Wayland loop after more than a year. My first port
> of call is once again building Wayland and Weston and getting some of the
> sample clients running. About all I've done so far is install W
Hi Pekka,
> On Dec 1, 2016, at 3:54 AM, Pekka Paalanen wrote:
>
> From: Pekka Paalanen
>
> We should probably have a change log in the tree to list the changes
> that end users (of weston, libweston, libweston-desktop, the apps, etc.)
> might be interested in. Particularly we can list changes
Hi,
> On Dec 1, 2016, at 3:07 AM, Olivier Fourdan wrote:
>
> Hey,
>
> - Original Message -
>> On 30 August 2016 at 14:05, Olivier Fourdan wrote:
Xwayland should probably use a private protocol, like EGL, ideally
completely hidden and pid-restricted.
>>>
>>> That's the point,
Hi Peter,
> On Nov 30, 2016, at 5:37 PM, Peter Hutterer wrote:
>
> Not that it really matters, but given we're already setting it anyway...
>
> Signed-off-by: Peter Hutterer
This series is just a basic config and license header change, and is
Reviewed-by: Yong Bakos
s the new
usage string if an option is amiss, and assigns the contents of the file
to editor.entry if all else is well. LGTM.
Reviewed-by: Yong Bakos
yong
> ---
> clients/editor.c | 67 +++-
> 1 file changed, 62 insertions(+), 5 deleti
or
around an excess arg count. It reflects the same option-parsing idiom found
elsewhere in the weston codebase.
While the `char *text_buffer` declaration in main belongs in 2/2 of this patch,
this one is:
Reviewed-by: Yong Bakos
yong
> ---
> cli
From: Yong Bakos
Documentation generation via doxygen includes wayland-util.c in its file
list. Although functions are documented in wayland-util.h, doxygen is
not automatically using the same documentation for functions in
wayland-util.c. In addition, everything listed in the doxygen page for
Ah,
> On Nov 25, 2016, at 8:12 AM, Yong Bakos wrote:
>
> Hi Frank,
>
>> On Nov 25, 2016, at 3:24 AM, Frank Jozsa wrote:
>>
>> Signed-off-by: Frank Jozsa
>
> Can you please explain the issue here and how this resolves it?
I see the issue raised on IRC
Hi Frank,
> On Nov 25, 2016, at 3:24 AM, Frank Jozsa wrote:
>
> Signed-off-by: Frank Jozsa
Can you please explain the issue here and how this resolves it?
I applied your patch but couldn't quickly discern the difference in
the doxygen output. Was it to remove the "Functions" sections at the en
From: Yong Bakos
connection-test.c did not cover wl_argument_from_va_list, so add one
test that specifically tests this method.
Signed-off-by: Yong Bakos
---
tests/connection-test.c | 35 +++
1 file changed, 35 insertions(+)
diff --git a/tests/connection
From: Yong Bakos
Doxygen truncates a WL_PRINTF function attribute, and there does not
seem to be any workaround[1]. When using the attribute like this:
typedef void (*wl_log_func_t)(const char *, va_list) WL_PRINTF(1, 0);
Doxygen generates something that looks like this:
typedef void
>
> v2: no need for scanner-test.sh to depend on the test data
>
> Task: https://phabricator.freedesktop.org/T3313
> Cc: Emilio Pozuelo Monfort
> Cc: Yong Bakos
> Signed-off-by: Pekka Paalanen
This is an awesome addition to the tests for scanner. I modified different
aspect
Hi Daniel,
> On Nov 21, 2016, at 9:14 AM, Daniel Stone wrote:
>
> Hi Yong,
>
> On 21 November 2016 at 13:44, Yong Bakos wrote:
>> - * A dispatcher takes five arguments: The first is the dispatcher-specific
>> - * implementation data associated with the target
Verified that the intent of the return type of wl_dispatcher_func_t is
for an error code. I'm including a response from J Ekstrand, author
of wl_dispatcher_func_t inline below, for the record.
> On Nov 17, 2016, at 8:28 AM, Yong Bakos wrote:
>
> On Nov 17, 2016, at 8:23 AM, Yon
From: Yong Bakos
Adjust the brief, clarify the behavior and arguments, correct a grammar
error, document the parameters, and document the return type.
Signed-off-by: Yong Bakos
Reviewed-by: Bryce Harrington
---
v2: Document intent of return type.
src/wayland-util.h | 27
Please disregard, need to annotate the v2. Apologies for the noise.
y
> On Nov 21, 2016, at 5:40 AM, Yong Bakos wrote:
>
> From: Yong Bakos
>
> Adjust the brief, clarify the behavior and arguments, correct a grammar
> error, document the parameters, and document the return
From: Yong Bakos
Adjust the brief, clarify the behavior and arguments, correct a grammar
error, document the parameters, and document the return type.
Signed-off-by: Yong Bakos
Reviewed-by: Bryce Harrington
---
src/wayland-util.h | 27 +--
1 file changed, 17
From: Yong Bakos
Use declarative voice, remove the unnecessary doxygen \enum tag, and add
two see-also's. This keeps the output the same but makes the comment
voice consistent, a little more readable, and refers to documented
functions that use this enum type.
Signed-off-by: Yong
From: Yong Bakos
Add a doxygen comment for wl_log_func_t.
Signed-off-by: Yong Bakos
---
src/wayland-util.h | 24
1 file changed, 24 insertions(+)
diff --git a/src/wayland-util.h b/src/wayland-util.h
index 8b02ff0..724dbb2 100644
--- a/src/wayland-util.h
+++ b/src
3.
>
> v2: specify request name in event description for clarity (Yong Bakos)
>
> Signed-off-by: Varad Gautam
One minor nit below but this is:
Reviewed-by: Yong Bakos
> ---
> unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml | 25 +++---
> 1 file changed,
s' requests.
>
> Suggested-by: Yong Bakos
> Signed-off-by: Varad Gautam
One minor nit below but this is:
Reviewed-by: Yong Bakos
> ---
> unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a
On Nov 17, 2016, at 7:49 PM, Peter Hutterer wrote:
>
> 8 spaces changed to one tab
>
> Signed-off-by: Peter Hutterer
> Acked-by: Bryce Harrington
Reviewed-by: Yong Bakos
Cheers,
yong
> ---
> Changes to v1:
> - Rebased on top of aa51a83
>
&
On Nov 17, 2016, at 8:23 AM, Yong Bakos wrote:
>
> From: Yong Bakos
>
> Adjust the brief, clarify the behavior and arguments, correct a grammar
> error, and document the parameters.
>
> Signed-off-by: Yong Bakos
Eh - what is the int return value for?
connection.
From: Yong Bakos
Adjust the brief, clarify the behavior and arguments, correct a grammar
error, and document the parameters.
Signed-off-by: Yong Bakos
---
src/wayland-util.h | 25 +++--
1 file changed, 15 insertions(+), 10 deletions(-)
diff --git a/src/wayland-util.h b
ur description of the problem, this protocol change seems to make
sense, and adds specificity to the constraining behavior. I can't think
of any drawbacks to adding this.
Reviewed-by: Yong Bakos
yong
> ---
> unstable/xdg-shell/xdg-shell-unstable-v6.xml | 6 --
> 1 file ch
Hi Varad,
> On Nov 17, 2016, at 3:55 AM, Varad Gautam wrote:
>
> From: Varad Gautam
>
> advertise the supported fourcc format modifiers along with supported
> formats to the client.
>
> bump zwp_linux_dmabuf_v1, zwp_linux_buffer_params_v1 interface
> versions to 3.
>
> Signed-off-by: Varad G
From: Yong Bakos
Hello,
My ongoing routine of documenting objects and checking for related test coverage
has recently led me to notice that wl_argument_from_va_list does not have a
specific test in connection-test.c. The 1/1 patch in this RFC describes a rough
draft at the testing approach
From: Yong Bakos
connection-test.c did not cover wl_argument_from_va_list, so add one
test that specifically tests this method.
Signed-off-by: Yong Bakos
---
tests/connection-test.c | 21 +
1 file changed, 21 insertions(+)
diff --git a/tests/connection-test.c b/tests
From: Yong Bakos
Standardize the doxygen comment format, add clarity to the writing, decouple
the description from specifics of usage, add see-also's, and massage the union
member type comments.
Signed-off-by: Yong Bakos
---
v3: Correct spelling of marhsalling.
v2: Match union member
On Nov 12, 2016, at 10:02 AM, Yong Bakos wrote:
>
> From: Yong Bakos
>
> Standardize the doxygen comment format, add clarity to the writing,
> decouple the description from specifics of usage, add see-also's, and
> massage the union member type comments.
>
&
From: Yong Bakos
Standardize the doxygen comment format, add clarity to the writing, decouple
the description from specifics of usage, add see-also's, and massage the union
member type comments.
Signed-off-by: Yong Bakos
---
src/wayland-util.h | 29 -
1
Disregard this one, v2 is en route.
yong
> On Nov 12, 2016, at 9:53 AM, Yong Bakos wrote:
>
> From: Yong Bakos
>
> Standardize the doxygen comment format, add clarity to the writing, decouple
> the description from specifics of usage, add see-also's, and massage
From: Yong Bakos
Standardize the doxygen comment format, add clarity to the writing,
decouple the description from specifics of usage, add see-also's, and
massage the union member type comments.
Signed-off-by: Yong Bakos
---
v2: Match union member type names to actual protocol-defined
and the
> touch device support this type of information. The client is
> responsible for making a reasonable assumption about the
> touch shape if no shape is reported.
>
> Signed-off-by: Dennis Kempin
This v6 patch reflects the version bump, per daniels, and other changes
from
From: Yong Bakos
Add doxygen comments for wl_fixed_t and its methods.
Although wl_fixed_t can be thought of as an opaque struct, it is a typedef. As
such, doxygen does not provide an elegant means of documenting it as both a
'class' with members and as a typedef. In other words, docu
From: Yong Bakos
Array argument symbols in a wl_message may be nullable, but the test for
wl_message_count_arrays did not test this. Add one more wl_message with
nullable array arguments.
Signed-off-by: Yong Bakos
---
tests/message-test.c | 6 --
1 file changed, 4 insertions(+), 2
Hi Moritz,
> On Nov 6, 2016, at 9:35 AM, Moritz Kiefer
> wrote:
>
> Signed-off-by: Moritz Kiefer
Reviewed-by: Yong Bakos
yong
> ---
> doc/publican/sources/Client.xml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/doc/publican/source
From: Yong Bakos
wl_fixed_to_double had a stray space before the parameter list.
Remove this space.
Signed-off-by: Yong Bakos
---
src/wayland-util.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/wayland-util.h b/src/wayland-util.h
index 7b280d1..e0eb126 100644
--- a
From: Yong Bakos
The test suite did not cover wl_interface_equal, so add one test that
specifically tests this method. Add the new test to Makefile.am.
Signed-off-by: Yong Bakos
---
v2: Remove unnecessary server header inclusion
Makefile.am| 3 +++
tests/interface-test.c | 48
From: Yong Bakos
The test suite did not cover wl_interface_equal, so add one test that
specifically tests this method. Add the new test to Makefile.am.
Signed-off-by: Yong Bakos
---
Makefile.am| 3 +++
tests/interface-test.c | 49
From: Yong Bakos
Add doxygen comments for wl_interface.
Signed-off-by: Yong Bakos
---
src/wayland-util.h | 52
1 file changed, 52 insertions(+)
diff --git a/src/wayland-util.h b/src/wayland-util.h
index 7b280d1..606cb6f 100644
--- a/src
device support this type of information. The client is
> responsible for making a reasonable assumption about the
> touch shape if no shape is reported.
>
> Signed-off-by: Dennis Kempin
Reviewed-by: Yong Bakos
Cheers,
yong
> ---
> protocol/wayland.xml | 80 +++
Hi Dennis,
> On Nov 3, 2016, at 3:52 PM, Dennis Kempin wrote:
>
> This CL updates the wl_touch interface with a shape and
> orientation event.
> The shape/orientation of a touch point is not relevant for most UI
> applications, but allows a better experience in some cases
> such as drawing apps.
already sequentially numbered with a make-pretend
> fancy name.
>
> Signed-off-by: Peter Hutterer
Reviewed-by: Yong Bakos
(Although I defer the versioning choice to those wiser than me.)
yong
> ---
> This is something Carlos and I discussed at XDC, TLDR: it doesn't make muc
From: Yong Bakos
message-test.c did not cover wl_message_count_arrays, so add one test that
specifically tests this method. Note that this exposes wl_message_count_arrays
in a private header (wayland-private.h), and removes the `static` modifier of
the implementation.
Signed-off-by: Yong Bakos
Hi Dennis,
On Nov 2, 2016, at 12:37 PM, Dennis Kempin wrote:
>
> This CL updates the wl_touch interface with a shape and
> orientation event.
> The shape/orientation of a touch point is not relevant for most UI
> applications, but allows a better experience in some cases
> such as drawing apps.
main concern (hence the RFC)
is about ABI compatibility. I /think/ removing static is ok here,
but I am not 100% confident.
yong
> 2016-10-27 17:58 GMT+02:00 Yong Bakos :
>> From: Yong Bakos
>>
>> message-test.c did not cover wl_message_count_arrays, so add one test that
yland-client headers using the type.
>
> Move it to be before all our other includes, so we actually make use of
> it.
>
> Signed-off-by: Daniel Stone
This reordering seems harmless, and squelches the deprecation warning during
compilation.
Reviewed-by: Yong Bakos
T
From: Yong Bakos
Enum entries and message arguments are sometimes preceded by a blank line, but
often aren't.
Standardize the format of the protocol specification by removing blank lines
preceding a list of message arguments and enum entries.
Signed-off-by: Yong Bakos
---
pro
From: Yong Bakos
I know, "not another crazy line break patch!"
Authors have been using line breaks before enum entries and argument elements
inconsistently; this patch, and a separate one for wayland-protocols, removes
the line breaks, making all declarations consistent.
This patch
From: Yong Bakos
I know, "not another crazy line break patch!"
Authors have been using line breaks before enum entries and argument elements
inconsistently; this patch, and a separate one for wayland.xml itself, removes
the line breaks, making all declarations consistent.
This patch
From: Yong Bakos
Enum entries and message arguments are sometimes preceded by a blank line, but
often aren't.
Standardize the format of the protocol specification by removing blank lines
preceding a list of message arguments and enum entries.
Signed-off-by: Yong Bakos
---
stable/present
From: Yong Bakos
message-test.c did not cover wl_message_count_arrays, so add one test that
specifically tests this method. Note that this exposes wl_message_count_arrays
in a private header (wayland-private.h), and removes the `static` modifier of
the implementation.
Signed-off-by: Yong Bakos
From: Yong Bakos
Signed-off-by: Yong Bakos
---
src/wayland-util.h | 68 ++
1 file changed, 68 insertions(+)
diff --git a/src/wayland-util.h b/src/wayland-util.h
index 7b280d1..4dba1ed 100644
--- a/src/wayland-util.h
+++ b/src/wayland-util.h
>
> Signed-off-by: Olivier Fourdan
This v is a simple split and rebase, and is
Reviewed-by: Yong Bakos
yong
> ---
> v3: split out as its own commit
> v4: Rebase against current git master
>
> src/wayland-server-core.h | 6 ++
> src/wayland-server.c | 12 +++
On Oct 18, 2016, at 7:23 AM, Olivier Fourdan wrote:
>
> Test if the global filter is effectively filtering out the global when
> the filter returns false.
>
> Signed-off-by: Olivier Fourdan
> Reviewed-by: Yong Bakos
> ---
This v remains
Reviewed-by: Yong Bakos
yong
fferent interfaces for their special-purpose clients, the client
> expecting the different interface would probably never see it
> advertised.
>
> Signed-off-by: Olivier Fourdan
> Reviewed-by: Jonas Ådahl
> Reviewed-by: Yong Bakos
> Acked-by: Pekka Paalanen
This v remains
7, sizeof arr) before wl_array_init() would
> be much better.
>
> Yong, do you mind if I add the memset there on top of your patch?
Go for it. Thanks Pekka.
yong
>
>
> Thanks,
> pq
>
>> On Tue, Sep 27, 2016 at 8:03 PM, Yong Bakos wrote:
>>
>>> F
From: Yong Bakos
The protocol describes wl_shm as a "global singleton" rather than
"singleton global," which is the order used throughout other protocol
object descriptions.
Re-order the terms for consistency.
Signed-off-by: Yong Bakos
---
protocol/wayland.xml | 2 +
From: Yong Bakos
Other singleton objects in the protocol are described as such.
Add a singleton adjective to the wl_registry description, making it
similar to other descriptions.
Signed-off-by: Yong Bakos
---
protocol/wayland.xml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
From: Yong Bakos
array-test.c did not cover wl_array_release, so add one test that specifically
tests this method.
Signed-off-by: Yong Bakos
---
v2: Use wl_array_add instead of calloc (pq)
tests/array-test.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/tests/array-test.c
From: Yong Bakos
Explicitly set the data member to an invalid memory address during
wl_array_release, such that re-using a freed wl_array without re-initializing
causes a crash. In addition, this pointer assignment makes wl_array_release
testable.
Define a constant for the invalid memory
From: Yong Bakos
This series adds documentation to wl_array and its methods.
There is one implementation change: defining an invalid pointer address, and
setting the `data` pointer to the invalid pointer address after free, in
wl_array_release. I did not set `size` and `alloc` to 0, in order to
From: Yong Bakos
Include wayland-util.h in addition to wayland-private.h, to be more explicit
about where wl_array is defined.
Remove the useless repeated testing of wl_array_init, because if it fails once
out of thousands of iterations we're all doomed anyway.
Signed-off-by: Yong
From: Yong Bakos
Add doxygen comments for wl_array and its methods.
Signed-off-by: Yong Bakos
Reviewed-by: Eric Engestrom
---
v2: Add description paragraph to wl_array (pq)
Fix s/list/array (pq)
Add note about pos type for wl_array_for_each (pq)
src/wayland-util.h | 73
On Sep 23, 2016, at 8:40 PM, Kylie McClain wrote:
>
> On musl, int32_t is defined in stdint.h.
>
> Signed-off-by: Kylie McClain
Reviewed-by: Yong Bakos
yong
> ---
> shared/string-helpers.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/shared/strin
1 - 100 of 411 matches
Mail list logo
