Re: [PATCH weston 5/5] gl-renderer: use correct pixel shader for NV12 format uploaded to RG texture

2017-12-05 Thread Vincent ABRIOU
> with R/G textures. This just seemed the logical fix after reading the > pixel shaders code. > > I'll mention this in the commit message. > Your patch looks good. I had no way to test has_gl_texture_rg when I submit 00a03d2f724 ("gl-renderer: add support of WL_SHM

Re: [PATCH weston 4/5] gl-renderer: fix pixel format used in texture uploads when using R/RG textures

2017-12-05 Thread Vincent ABRIOU
Hi Arnaud, Reviewed-by: Vincent Abriou BR Vincent On 12/04/2017 05:56 PM, Emil Velikov wrote: > On 29 November 2017 at 14:25, Arnaud Vrac wrote: >> From: Arnaud Vrac >> >> In glTexImage2D / glTexSubImage2D calls, the only pixel formats allowed >> for the GL_R8 and

Re: [PATCH weston] gl-renderer: Set pitch correctly for subsampled textures

2017-10-09 Thread Vincent ABRIOU
I resent it (issue in the mailing list address) Hi Daniel, Your patch is good to me. On 10/09/2017 09:15 AM, Pekka Paalanen wrote: > Hi Nicolas and Daniel, > > excellent comments, I think we just need a summary of them in the > commit message and we could land the original patch. If you want t

Re: [weston v2] linux-dmabuf: align DMABUF exposed formats with EGL supported formats

2017-03-20 Thread Vincent ABRIOU
Hi Daniel, Any feedback on this patch? Thanks Vincent On 02/10/2017 03:30 PM, Vincent Abriou wrote: > Expose to the DMABUF protocol the pixel formats already explicitly > supported as fallback by gl-renderer in import_yuv_dmabuf function plus > the standard RGB formats that all GPU

Re: weston-simple-egl fullscreen broken?

2017-03-10 Thread Vincent ABRIOU
On 03/09/2017 04:41 PM, Pekka Paalanen wrote: > On Thu, 9 Mar 2017 15:01:03 + > Vincent ABRIOU wrote: > >> On 03/09/2017 02:48 PM, Pekka Paalanen wrote: >>> On Thu, 9 Mar 2017 12:53:35 + >>> Vincent ABRIOU wrote: >>> >>>> Hi Pekka,

Re: weston-simple-egl fullscreen broken?

2017-03-09 Thread Vincent ABRIOU
On 03/09/2017 02:48 PM, Pekka Paalanen wrote: > On Thu, 9 Mar 2017 12:53:35 + > Vincent ABRIOU wrote: > >> Hi Pekka, >> >> On 03/09/2017 11:32 AM, Pekka Paalanen wrote: >>> On Wed, 8 Mar 2017 17:16:31 + >>> Vincent ABRIOU wrote: >>

Re: weston-simple-egl fullscreen broken?

2017-03-09 Thread Vincent ABRIOU
Hi Pekka, On 03/09/2017 11:32 AM, Pekka Paalanen wrote: > On Wed, 8 Mar 2017 17:16:31 + > Vincent ABRIOU wrote: > >> Hi, >> >> I have investigate deeper the issue and it comes from the Mali400 >> wayland library (at least in the r6p1-01rel0 version). &g

Re: weston-simple-egl fullscreen broken?

2017-03-08 Thread Vincent ABRIOU
Hi, I have investigate deeper the issue and it comes from the Mali400 wayland library (at least in the r6p1-01rel0 version). Actually, the Mali400 wayland library is creating very early the output surface taking into account the 250x250 default size because fullscreen information is not yet av

[weston v2] linux-dmabuf: align DMABUF exposed formats with EGL supported formats

2017-02-10 Thread Vincent Abriou
Expose to the DMABUF protocol the pixel formats already explicitly supported as fallback by gl-renderer in import_yuv_dmabuf function plus the standard RGB formats that all GPU supports: ARGB, XRGB, RGB565, YUYV, NV12, YUV420 and YUV444. Signed-off-by: Vincent Abriou --- v2: - Remove

Re: [weston] linux-dmabuf: align DMABUF exposed formats with EGL supported formats

2016-11-22 Thread Vincent ABRIOU
Hi Daniel, This was not my understanding of the EGL extension. In that case I agree it still make sense. I will then propose a new implementation to take into account your comment. Vincent On 11/22/2016 10:07 AM, Daniel Stone wrote: > Hi Vincent, > > On 22 November 2016 at 08:54, Vince

Re: [weston] linux-dmabuf: align DMABUF exposed formats with EGL supported formats

2016-11-22 Thread Vincent ABRIOU
> Hi Vincent, > > On 7 October 2016 at 16:08, Vincent Abriou wrote: >> @@ -72,6 +72,9 @@ install-libweston_moduleLTLIBRARIES >> install-moduleLTLIBRARIES: install-libLTLIBR >> lib_LTLIBRARIES = libweston-@LIBWESTON_MAJOR@.la >> libweston_@LIBWESTON_MAJOR@_la

[weston v2] gl-renderer: conditionally call query_buffer while gl_renderer_attach

2016-11-03 Thread Vincent Abriou
ge-Id: I5b5995fec67351cc8e4746f932d7ace838fa73be Signed-off-by: Vincent Abriou --- libweston/gl-renderer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libweston/gl-renderer.c b/libweston/gl-renderer.c index 9747de5..3e8e5ab 100644 --- a/libweston/gl-renderer.c +++ b/libweston/gl-rende

[weston v2] gl-renderer: add support of WL_SHM_FORMAT_YUYV

2016-10-20 Thread Vincent Abriou
This patch allow gl-renderer to accept WL_SHM_FORMAT_YUYV buffers. This is the pixel format supported by most of the USB webcams. v2: - fix hsub Vs vsub inversion Signed-off-by: Vincent Abriou Reviewed-by: Eric Engestrom --- libweston/gl-renderer.c | 56

[weston] gl-renderer: add support of WL_SHM_FORMAT_YUYV

2016-10-20 Thread Vincent Abriou
This patch allow gl-renderer to accept WL_SHM_FORMAT_YUYV buffers. This is the pixel format supported by most of the USB webcams. Signed-off-by: Vincent Abriou --- libweston/gl-renderer.c | 56 + 1 file changed, 38 insertions(+), 18 deletions

[PATCH 1/1] libweston: fix building issue when EGL support is not enabled

2016-10-11 Thread Vincent Abriou
to build. Signed-off-by: Vincent Abriou Cc: Daniel Stone --- libweston/weston-egl-ext.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libweston/weston-egl-ext.h b/libweston/weston-egl-ext.h index 6e36996..70556fd 100644 --- a/libweston/weston-egl-ext.h +++ b/libweston/weston-egl

[weston] gl-renderer: conditionally call query_buffer while gl_renderer_attach

2016-10-07 Thread Vincent Abriou
While gl_renderer_attach, query_buffer should be call only if the query_buffer function exists. Signed-off-by: Vincent Abriou --- libweston/gl-renderer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libweston/gl-renderer.c b/libweston/gl-renderer.c index 6276188

[weston] linux-dmabuf: align DMABUF exposed formats with EGL supported formats

2016-10-07 Thread Vincent Abriou
supports: ARGB, XRGB, RGB565, YUYV, NV12, YUV420 and YUV444. Signed-off-by: Vincent Abriou --- Makefile.am | 3 +++ libweston/linux-dmabuf.c | 18 +++--- 2 files changed, 18 insertions(+), 3 deletions(-) diff --git a/Makefile.am b/Makefile.am index c94c211..6366c6f

Re: [PATCH weston v2 1/3] compositor-drm: refactor destroy drm_fb function

2016-10-06 Thread Vincent ABRIOU
Looks good to me. Reviewed-by: Vincent Abriou On 10/03/2016 07:28 PM, Derek Foreman wrote: > On 30/09/16 04:28 AM, Tomohito Esaki wrote: >> The drm_fb destroy callback to mostly the same thing regardless of >> whether the buffer is a dumb buffer or gbm buffer. This patch refactor

Re: [weston v2 0/2] gl-renderer: add support of I420 and NV12 SHM pixel

2016-10-06 Thread Vincent ABRIOU
Hi Daniel, Sorry for the indentation, it disappears when I merge the patch on top of the master. I will now check twice :) BR Vincent On 10/05/2016 07:16 PM, Daniel Stone wrote: > Hi Vincent, > > On 5 October 2016 at 13:54, Vincent Abriou wrote: >> This serie of patches add

[weston] libweston: include weston-egl-ext.h in drm, x11 and wayland compositor

2016-10-05 Thread Vincent Abriou
As to what is done for gl-renderer.c, weston-egl-ext.h should be include in compositor-drm.c, compositor-x11.c and compositor-wayland.c. This fix building issue with GPU that does not have EGL_PLATFORM_xxx_KHR in their extension header file eglext.h. Signed-off-by: Vincent Abriou --- libweston

[weston v2 2/2] gl-renderer: add support of WL_SHM_FORMAT_NV12

2016-10-05 Thread Vincent Abriou
This patch allow gl-renderer to accept WL_SHM_FORMAT_NV12 buffers. Signed-off-by: Vincent Abriou --- libweston/gl-renderer.c | 64 ++--- 1 file changed, 45 insertions(+), 19 deletions(-) diff --git a/libweston/gl-renderer.c b/libweston/gl-renderer.c

[weston v2 0/2] gl-renderer: add support of I420 and NV12 SHM pixel

2016-10-05 Thread Vincent Abriou
This serie of patches add the support of the most common SHM YUV pixel formats used by gstreamer software plugins. v2: - rebase on git master - wrap to 80 characters the long lines - use GL_R8_EXT/GL_RG8_EXT when GL_EXT_texture_rg extension is supported Vincent Abriou (2): gl-renderer: add

[weston v2 1/2] gl-renderer: add support of WL_SHM_FORMAT_YUV420

2016-10-05 Thread Vincent Abriou
WL_SHM_FORMAT_YUV420. Signed-off-by: Vincent Abriou --- libweston/gl-renderer.c | 81 - 1 file changed, 67 insertions(+), 14 deletions(-) diff --git a/libweston/gl-renderer.c b/libweston/gl-renderer.c index 031576b..9e6109e 100644 --- a/libweston/gl-renderer.c

[weston 2/2] gl-renderer: add support of WL_SHM_FORMAT_NV12

2016-08-05 Thread Vincent Abriou
This patch allow weston to accept WL_SHM_FORMAT_NV12 buffers. It has been tested on top of weston-1.11 Signed-off-by: Vincent Abriou --- libweston/gl-renderer.c | 49 + 1 file changed, 33 insertions(+), 16 deletions(-) diff --git a/libweston/gl

[weston 1/2] gl-renderer: add support of WL_SHM_FORMAT_YUV420

2016-08-05 Thread Vincent Abriou
WL_SHM_FORMAT_YUV420. It has been tested on top of weston-1.11 Signed-off-by: Vincent Abriou --- libweston/gl-renderer.c | 56 - 1 file changed, 42 insertions(+), 14 deletions(-) diff --git a/libweston/gl-renderer.c b/libweston/gl-renderer.c index ed44c6d..12b763e

[weston 0/2] gl-renderer: add support of I420 and NV12 SHM pixel

2016-08-05 Thread Vincent Abriou
This serie of patches add the support of the most common SHM YUV pixel formats used by gstreamer software plugins. Vincent Abriou (2): gl-renderer: add support of WL_SHM_FORMAT_YUV420 gl-renderer: add support of WL_SHM_FORMAT_NV12 libweston/gl-renderer.c | 93

Re: [weston] gl-renderer: add support of WL_SHM_FORMAT_YUV420

2016-08-05 Thread Vincent ABRIOU
abandon this patch since the new series will come very soon. Thanks Vincent On 08/04/2016 06:03 PM, Vincent Abriou wrote: > Hi Daniel, > > On 08/04/2016 04:32 PM, Daniel Stone wrote: >> Hi Vincent, >> >> On 4 August 2016 at 14:35, Vincent Abriou wrote: >>&g

Re: [weston] gl-renderer: add support of WL_SHM_FORMAT_YUV420

2016-08-04 Thread Vincent ABRIOU
Hi Daniel, On 08/04/2016 04:32 PM, Daniel Stone wrote: > Hi Vincent, > > On 4 August 2016 at 14:35, Vincent Abriou wrote: >> This patch allow weston to accept WL_SHM_FORMAT_YUV420 buffers. >> >> In a gstreamer pipeline, the support of the WL_SHM_FORMAT_YUV420 by >&

[weston] gl-renderer: add support of WL_SHM_FORMAT_YUV420

2016-08-04 Thread Vincent Abriou
WL_SHM_FORMAT_YUV420. It has been tested on top of weston-1.11 Change-Id: I672c68606e4e9c10550174f5ef8402eaf3512ea5 Signed-off-by: Vincent Abriou --- libweston/gl-renderer.c | 70 +++-- 1 file changed, 56 insertions(+), 14 deletions(-) diff --git a/libweston/gl