Re: [PATCH libinput] evdev: check model flags for actual booleans

2016-06-08 Thread Vasily Khoruzhick
stence, check whether the property is actually > set to something resembling a boolean. > > Signed-off-by: Peter Hutterer Tested-by: Vasily Khoruzhick > --- > src/evdev.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/src/evdev.c b/src/ev

Re: [PATCH libinput v5] evdev: use a different filter for low resolution touchpad on the Lenovo X230

2015-04-26 Thread Vasily Khoruzhick
Hi Benjamin, This one works well on my x230. Have my: Tested-by: Vasily Khoruzhick Regards, Vasily On Thu, Apr 23, 2015 at 9:32 PM, Benjamin Tissoires wrote: > Those touchpads presents an actual lower resolution that what is > advertised. > > We see some jumps from the cursor du

Re: [PATCH libinput v4 0/2] Fix Lenovo X230 series touchpad

2015-04-23 Thread Vasily Khoruzhick
On Thu, Apr 23, 2015 at 1:53 PM, Vasily Khoruzhick wrote: > Hi Benjamin, > > v4 is completely unusable. With slow motion cursor is _too_ slow, with > faster it's too fast. First version was _much_ better. Even more: I'd say non-patched libinput behaves better than v4. Pl

Re: [PATCH libinput v4 0/2] Fix Lenovo X230 series touchpad

2015-04-23 Thread Vasily Khoruzhick
Hi Benjamin, v4 is completely unusable. With slow motion cursor is _too_ slow, with faster it's too fast. First version was _much_ better. Regards, Vasily On Mon, Apr 20, 2015 at 9:29 PM, Benjamin Tissoires wrote: > Hi, > > This is a new attempt to fix the X230 series. > > This time, I tried to

Re: [PATCH v3 0/4] Fix Lenovo X230 series touchpad

2015-04-17 Thread Vasily Khoruzhick
On Fri, Apr 17, 2015 at 4:55 PM, Benjamin Tissoires wrote: > Hi Vasily, Hi Benjamin, > So maybe the X230t has a slightly different touchpad. I don't recall > having any difficulties with the new patch series. > I think I'll just revert to the v1 settings. But if you can try to > tune the paramet

Re: [PATCH v3 0/4] Fix Lenovo X230 series touchpad

2015-04-16 Thread Vasily Khoruzhick
Hi Benjamin, On Thu, Apr 16, 2015 at 9:41 PM, Benjamin Tissoires wrote: > So here is a v2 (well v3 to keep things incrementing) of the x230 touchpad > series. > > The touchpad seems almost as fast as any other by multiplying again the > incline parameter by TP_MAGIC_LOW_RES_FACTOR. I am sure ther

Re: [PATCH v3 2/4] evdev: use a different filter for low resolution touchpad on the Lenovo X230

2015-04-16 Thread Vasily Khoruzhick
On Thu, Apr 16, 2015 at 9:41 PM, Benjamin Tissoires wrote: > Those touchpads presents an actual lower resolution that what is > advertised. > > We see some jumps from the cursor due to the big steps in X and Y > when we are receiving data. > > For instance, we receive: > > E: 13.471932 0003 1

Re: [PATCH libinput 0/3] Fix Lenovo X230 series touchpad

2015-04-13 Thread Vasily Khoruzhick
Hi Benjamin, On Mon, Apr 13, 2015 at 11:10 PM, Benjamin Tissoires wrote: > > Feel free to send the various parameters you set, and we will see if > we can include them (after comparison with other touchpads :-P). Is it possible to speedup two finger scroll somehow? Cursor movement with your para

Re: [PATCH libinput 0/3] Fix Lenovo X230 series touchpad

2015-04-09 Thread Vasily Khoruzhick
Hi Benjamin, On Thu, Apr 9, 2015 at 8:30 PM, Benjamin Tissoires wrote: > > Hi, > > Here is a series to try making the touchpad found on the Lenovo > X230 working. This touchpad has a very bad hardware resolution and by > default, libinput jumps the cursor for 10 pixels at least whenever the > use

[PATCH] pixman renderer: respect output position

2013-01-29 Thread Vasily Khoruzhick
Signed-off-by: Vasily Khoruzhick --- src/pixman-renderer.c | 44 1 file changed, 28 insertions(+), 16 deletions(-) diff --git a/src/pixman-renderer.c b/src/pixman-renderer.c index 908824c..9571f6f 100644 --- a/src/pixman-renderer.c +++ b/src/pixman

[PATCH 2/2] pixman-renderer: handle surface transform matrix properly

2013-01-28 Thread Vasily Khoruzhick
Signed-off-by: Vasily Khoruzhick --- src/pixman-renderer.c | 107 ++ 1 file changed, 90 insertions(+), 17 deletions(-) diff --git a/src/pixman-renderer.c b/src/pixman-renderer.c index 8d95197..908824c 100644 --- a/src/pixman-renderer.c +++ b/src

[PATCH 1/2] matrix: track transform type

2013-01-28 Thread Vasily Khoruzhick
Introduce several matrix transform types and track type for matrix. Could be usefull for activating some fastpath that depends on some transform type. Signed-off-by: Vasily Khoruzhick --- shared/matrix.c | 23 --- shared/matrix.h | 10 ++ src/compositor.c | 3

Re: [PATCH weston 2/7] pixman-renderer: Move shadow buffer into renderer

2013-01-23 Thread Vasily Khoruzhick
On Wed, Jan 23, 2013 at 12:02 PM, Ander Conselvan de Oliveira wrote: > On 01/23/2013 09:25 AM, Vasily Khoruzhick wrote: >> >> On Tue, Jan 22, 2013 at 7:07 PM, Ander Conselvan de Oliveira >> wrote: >>> >>> The X11 backend uses a shadow buffer to be able to s

Re: [PATCH weston 2/7] pixman-renderer: Move shadow buffer into renderer

2013-01-22 Thread Vasily Khoruzhick
On Tue, Jan 22, 2013 at 7:07 PM, Ander Conselvan de Oliveira wrote: > The X11 backend uses a shadow buffer to be able to support transformed > outputs. However, this belongs in the renderer, since otherwise this > code would have to be copied into every backend that uses the pixman > renderer and

Re: [PATCH 1/3] Add missing pixman-renderer.h to Makefile.am

2013-01-18 Thread Vasily Khoruzhick
On Sat, Jan 19, 2013 at 5:10 AM, nerdopolis wrote: > Hi. > > I played around in Weston with the Pixman renderer enabled, and it seems > that using the Weston window rotate feature seems to result in some > interesting glitches (as well as the Weston zoom animation). > > This is a screenshot of an

Re: [PATCH] fbdev: Add an fbdev compositor backend using pixman and evdev

2013-01-16 Thread Vasily Khoruzhick
On Wed, Jan 16, 2013 at 11:22 PM, David Herrmann wrote: > Hi Philip > > I like the simple design of this. I don't think we need to share much > of the code as it's pretty simple. > > I haven't checked all of it, but some comments below. > > Thanks > David > > On Tue, Jan 15, 2013 at 3:08 PM, Phili

Re: [PATCH] fbdev: Add an fbdev compositor backend using pixman and evdev

2013-01-15 Thread Vasily Khoruzhick
On Tue, Jan 15, 2013 at 5:08 PM, Philip Withnall wrote: > This is an initial version of an fbdev backend for Weston. I don't > consider it polished; I'm just looking for rough feedback at the > moment. The work is also available as a gitorious branch if anyone > prefers that: > https://gitorious.o

[PATCH] gl-renderer: make EGL typedefs similar to EGL/egl.h when building without EGL support

2013-01-11 Thread Vasily Khoruzhick
Signed-off-by: Vasily Khoruzhick --- src/gl-renderer.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gl-renderer.h b/src/gl-renderer.h index 81735e6..a2e8690 100644 --- a/src/gl-renderer.h +++ b/src/gl-renderer.h @@ -53,10 +53,10

Re: [PATCH 3/3] Make EGL/GLESv2 dependencies optional

2013-01-11 Thread Vasily Khoruzhick
On Fri, Jan 11, 2013 at 11:19 AM, David Herrmann wrote: > Hi > > On Fri, Jan 11, 2013 at 7:44 AM, Vasily Khoruzhick wrote: >> On Fri, Jan 11, 2013 at 1:33 AM, David Herrmann >> wrote: >>> Hi >>> >>> On Wed, Jan 9, 2013 at 10:44 AM, Vasily Khoruz

Re: [PATCH 3/3] Make EGL/GLESv2 dependencies optional

2013-01-10 Thread Vasily Khoruzhick
On Fri, Jan 11, 2013 at 1:33 AM, David Herrmann wrote: > Hi > > On Wed, Jan 9, 2013 at 10:44 AM, Vasily Khoruzhick wrote: >> On Wed, Jan 9, 2013 at 12:03 AM, Vasily Khoruzhick >> wrote: >>> On Wed, Jan 9, 2013 at 12:01 AM, John Kåre Alsaker >>&

Re: [PATCH 3/3] Make EGL/GLESv2 dependencies optional

2013-01-09 Thread Vasily Khoruzhick
On Wed, Jan 9, 2013 at 12:03 AM, Vasily Khoruzhick wrote: > On Wed, Jan 9, 2013 at 12:01 AM, John Kåre Alsaker > wrote: >> EGLDisplay, EGLSurface, EGLNativeDisplayType and EGLNativeWindowType >> should all be void *. With that change you can get rid of the ugly >> typ

Re: [PATCH 3/3] Make EGL/GLESv2 dependencies optional

2013-01-08 Thread Vasily Khoruzhick
n Tue, Jan 8, 2013 at 5:09 PM, Vasily Khoruzhick wrote: >> >> +typedef int EGLDisplay; >> +typedef int EGLSurface; >> +typedef long int EGLNativeDisplayType; >> +typedef long int EGLNativeWindowType; ___ wayland-devel mailin

Re: [PATCH 2/3] renderer: introduce destroy callback

2013-01-08 Thread Vasily Khoruzhick
On Tue, Jan 8, 2013 at 10:50 PM, John Kåre Alsaker wrote: Hi John, > I'd like for output_create, output_destroy, renderer_destroy, > set_border and repaint_output to be virtual functions as part of a new > abstraction which is responsible for handling buffers and renderers > for the backends. Th

[PATCH 3/3] Make EGL/GLESv2 dependencies optional

2013-01-08 Thread Vasily Khoruzhick
Introduce --disable-egl switch for configure to disable EGL/GLESv2 support. Signed-off-by: Vasily Khoruzhick --- configure.ac | 40 ++- src/Makefile.am | 6 +- src/compositor-x11.c | 4 ++-- src/gl-renderer.h| 59

[PATCH 2/3] renderer: introduce destroy callback

2013-01-08 Thread Vasily Khoruzhick
Signed-off-by: Vasily Khoruzhick --- src/compositor-android.c | 6 +++--- src/compositor-drm.c | 4 ++-- src/compositor-headless.c | 2 +- src/compositor-rpi.c | 4 ++-- src/compositor-wayland.c | 4 ++-- src/compositor-x11.c | 10 ++ src/compositor.h | 3

[PATCH 1/3] Add missing pixman-renderer.h to Makefile.am

2013-01-08 Thread Vasily Khoruzhick
Signed-off-by: Vasily Khoruzhick --- src/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Makefile.am b/src/Makefile.am index 14e283e..e4bb862 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -37,6 +37,7 @@ weston_SOURCES = \ gl

[PATCH] compositor-x11: rename use-shm to use-pixman

2013-01-07 Thread Vasily Khoruzhick
So it could be reused with other backends and not be easily confused with wl_shm Signed-off-by: Vasily Khoruzhick --- src/compositor-x11.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/src/compositor-x11.c b/src/compositor-x11.c index a994a97

Re: [PATCH v2 2/2] x11 backend: add option to use pixman renderer

2013-01-07 Thread Vasily Khoruzhick
On Mon, Jan 7, 2013 at 9:49 PM, Kristian Høgsberg wrote: > On Mon, Jan 07, 2013 at 08:39:50PM +0300, Vasily Khoruzhick wrote: >> When --use-shm is passed to weston and x11 backend is active, >> it will use SHM surfaces with pixman renderer instead of EGL >> >> Signe

[PATCH v2 2/2] x11 backend: add option to use pixman renderer

2013-01-07 Thread Vasily Khoruzhick
When --use-shm is passed to weston and x11 backend is active, it will use SHM surfaces with pixman renderer instead of EGL Signed-off-by: Vasily Khoruzhick --- v2: - handle missing MIT-SHM extension gracefully (tested with Xnest) - follow libc convention of error handling - get rid of

[PATCH v2 1/2] Implement pixman renderer

2013-01-07 Thread Vasily Khoruzhick
This renderer could be used when there's no graphic accelerator available, for example in (future) KMS and fbdev backends. Signed-off-by: Vasily Khoruzhick --- v2: - follow libc convention of error handling - improve commit message src/Makefile.am | 1 + src/pixman-renderer.c

Re: [PATCH RFC 4/4] x11 backend: add option to use pixman renderer

2013-01-06 Thread Vasily Khoruzhick
On Sun, Jan 6, 2013 at 1:39 PM, Uli Schlachter wrote: > Hi, > > On 06.01.2013 10:12, Vasily Khoruzhick wrote: >> + /* Check if SHM is available */ >> + version = xcb_shm_query_version_reply(c->conn, >> xcb_shm_query_version(c->conn), 0); >> + i

[PATCH RFC 4/4] x11 backend: add option to use pixman renderer

2013-01-06 Thread Vasily Khoruzhick
When --use-shm is passed to weston and x11 backend is active, it will use SHM surfaces with pixman renderer instead of EGL Signed-off-by: Vasily Khoruzhick --- configure.ac | 2 +- src/compositor-x11.c | 308 +-- 2 files changed, 299

[PATCH RFC 3/4] Implement pixman renderer

2013-01-06 Thread Vasily Khoruzhick
Signed-off-by: Vasily Khoruzhick --- src/Makefile.am | 1 + src/pixman-renderer.c | 378 ++ src/pixman-renderer.h | 39 ++ 3 files changed, 418 insertions(+) create mode 100644 src/pixman-renderer.c create mode 100644 src/pixman

[PATCH RFC 2/4] screenshoter: add cases for x8r8g8b8 and x8b8g8r8 formats

2013-01-06 Thread Vasily Khoruzhick
These formats are used by pixman renderer for framebuffer surface, without this patch screenshoter produces empty image. Signed-off-by: Vasily Khoruzhick --- src/screenshooter.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/screenshooter.c b/src/screenshooter.c index 662aad4

[PATCH RFC 1/4] screenshoter: don't use hardcoded bpp value

2013-01-06 Thread Vasily Khoruzhick
Signed-off-by: Vasily Khoruzhick --- src/screenshooter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/screenshooter.c b/src/screenshooter.c index 840dfb8..662aad4 100644 --- a/src/screenshooter.c +++ b/src/screenshooter.c @@ -103,7 +103,7 @@ screenshooter_frame_notify

[PATCH RFC 0/4] Add pixman renderer to support pure software rendering

2013-01-06 Thread Vasily Khoruzhick
These patches add support for software rendering to weston by introducing new renderer and adding MIT-SHM support to x11 backend. 1st and 2nd patches aren't related to pixman renderer, but without them screenshoter will not work properly when pixman renderer is active. configure.ac | 2