Re: [PATCH 3/4] xwayland: Draw decoration on window manager side

2013-07-31 Thread Uli Schlachter
Hi, On 30.07.2013 18:13, Louis-Francis Ratté-Boulianne wrote: > Draw everything in a cairo image surface before copying it to the XCB > surface. That removes the flickering visible on rpi whenever the > decoration were redrawn. > --- > src/xwayland/window-manager.c | 22 -- >

Re: [PATCH weston 1/7] weston.pc: Add dependencies for pixman-1 and xkbcommon

2013-06-22 Thread Uli Schlachter
On 22.06.2013 14:44, Quentin Glidic wrote: > On 22/06/2013 01:20, Kristian Høgsberg wrote: >> On Fri, Jun 21, 2013 at 06:43:36AM +0200, Quentin Glidic wrote: >>> On 20/06/2013 21:05, Kristian Høgsberg wrote: On Tue, Jun 18, 2013 at 09:11:28AM +0200, Quentin Glidic wrote: > From: Quentin Gl

Re: Things that killed my motivation to play with wayland

2013-06-14 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, On 12.06.2013 02:49, dar...@chaosreigns.com wrote: [...] > 3) The state of cairo's build testing, particularly this bug: > https://bugs.freedesktop.org/show_bug.cgi?id=62375 Cairo has a huge and > glorious build test suite. But it looked very

Re: Proposal to change subsurface extension

2013-06-13 Thread Uli Schlachter
Hi, On 13.06.2013 16:06, John Kåre Alsaker wrote: > On Thu, Jun 13, 2013 at 2:42 PM, Pekka Paalanen wrote: >> Libwayland does not synchronize, it only protects the queues for the >> very short moment each time they are modified. It does not cause one >> application component to stall and wait for

Re: [PATCH] client: Add wl_display_prepare_read() API to thread model assumptions

2013-05-01 Thread Uli Schlachter
On 01.05.2013 17:52, Kristian Høgsberg wrote: > On Tue, Apr 30, 2013 at 11:45:15PM +0200, Uli Schlachter wrote: >> On 30.04.2013 22:06, Kristian Høgsberg wrote: >> [...] >>> diff --git a/src/connection.c b/src/connection.c >>> index dca134b..b26402f 100644 >>

Re: [PATCH] client: Add wl_display_prepare_read() API to thread model assumptions

2013-04-30 Thread Uli Schlachter
Evening, On 30.04.2013 22:06, Kristian Høgsberg wrote: [...] > diff --git a/src/connection.c b/src/connection.c > index dca134b..b26402f 100644 > --- a/src/connection.c > +++ b/src/connection.c > @@ -324,7 +324,7 @@ wl_connection_read(struct wl_connection *connection) > msg.msg_flags = 0; >

Re: [PATCH] client: Add acquire-fd API to avoid requiring a polling main thread

2013-04-13 Thread Uli Schlachter
Hi, On 12.04.2013 22:27, Kristian Høgsberg wrote: > On Thu, Apr 11, 2013 at 09:53:58AM +0200, Uli Schlachter wrote: >> On 10.04.2013 23:55, Kristian Høgsberg wrote: >> [...] >>> +WL_EXPORT int >>> +wl_display_acquire_fd(struct wl_display *d

Re: [PATCH] client: Add acquire-fd API to avoid requiring a polling main thread

2013-04-11 Thread Uli Schlachter
On 10.04.2013 23:55, Kristian Høgsberg wrote: [...] +WL_EXPORT int +wl_display_acquire_fd(struct wl_display *display) +{ + char c = 0; + + pthread_mutex_lock(&display->mutex); + + if (display->reader_state == LOCKED_READER && + !pthread_equal(display->reader, pthread_s

Re: [PATCH] client: Add acquire-fd API to avoid requiring a polling main thread

2013-04-10 Thread Uli Schlachter
;display->pipe_cond); > + > + if (ret == -1) { > + display_fatal_error(display, errno); > + return -1; > + } [...] This still has the "pending byte in the pipe"-problem from earlier, doesn't it? I mean

Re: [PATCH] client: Add acquire-fd API to avoid requiring a polling main thread

2013-03-25 Thread Uli Schlachter
On 25.03.2013 21:33, Thiago Macieira wrote: > On segunda-feira, 25 de março de 2013 19.49.32, Uli Schlachter wrote: >> So wl_display_acquire_fd() would do: >> >> if (old_state == VOLUNTEER_READER) { >> write(display->reader_pipe[1], &c, 1); >

Re: [PATCH] client: Add acquire-fd API to avoid requiring a polling main thread

2013-03-25 Thread Uli Schlachter
On 25.03.2013 18:42, Kristian Høgsberg wrote: [...] > @@ -847,45 +973,105 @@ dispatch_event(struct wl_display *display, struct > wl_event_queue *queue) > } > > static int > -dispatch_queue(struct wl_display *display, > -struct wl_event_queue *queue, int block) > +read_events(struct

Re: [PATCH] client: Add lock-fd API to avoid requiring a polling main thread

2013-03-24 Thread Uli Schlachter
Hi again, On 22.03.2013 02:29, Kristian Høgsberg wrote: > On Thu, Mar 21, 2013 at 05:13:47PM +0100, Uli Schlachter wrote: >> On 21.03.2013 15:20, Kristian Høgsberg wrote: [...] >>> + * Calling wl_display_lock_fd() ensures that no other thread will read >>> + * the disp

Re: [PATCH] client: Add lock-fd API to avoid requiring a polling main thread

2013-03-21 Thread Uli Schlachter
Hi, On 21.03.2013 15:20, Kristian Høgsberg wrote: > The current thread model assumes that the application or toolkit will have > a thread that either polls the display fd and dispatches events or just > dispatches in a loop. Only the main thread will read from the fd while > all other threads wil

Re: [RFC] add a shutdown event

2013-03-18 Thread Uli Schlachter
Hi, On 18.03.2013 00:30, Hardening wrote: > On 17/03/2013 23:59, Sylvain BERTRAND wrote: >> On Sun, Mar 17, 2013 at 11:32:21PM +0100, Hardening wrote: >>> This patch adds a shutdow event so that clients can be notified >>> when the compositor is about to exit (and potentially kill its >>> child pr

Re: Expected behaviour of eglSwapBuffers and the event queue

2013-03-01 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, On 01.03.2013 06:08, Sam Spilsbury wrote: [...] >>> 3. For roundtrip and SwapBuffers, we could make the server put some >>> data back into the fd indicating that the fd has been read and events >>> were put into the queue. That way, when main

Re: [PATCH RFC 4/4] x11 backend: add option to use pixman renderer

2013-01-06 Thread Uli Schlachter
Hi, On 06.01.2013 10:12, Vasily Khoruzhick wrote: > + /* Check if SHM is available */ > + version = xcb_shm_query_version_reply(c->conn, > xcb_shm_query_version(c->conn), 0); > + if (!version) > + /* SHM is missing */ > + return -ENOENT; > + weston_log("Fou

Re: [PATCH weston 1/2] compositor-x11: use _checked() with xkb_select_events to test for error

2012-10-31 Thread Uli Schlachter
On 31.10.2012 16:31, Kristian Høgsberg wrote: > On Wed, Oct 31, 2012 at 12:13:08AM +0200, Ran Benita wrote: >> In order to use xcb_request_check(), given a request without a reply, >> you need to use the _checked() variant of the request function. >> See xcb-requests(3). > > Applied. Did not know

Re: error when building cairo

2012-08-17 Thread Uli Schlachter
On 17.08.2012 12:11, Prigent, Christophe wrote: > /home/yann/dev/wayland/install/include/cairo/cairo-gl.h:142:3: error: #error > Cairo was not compiled with support for the GL backend I hear someone whisper "compile cairo with --enable-gl and the other needed --enable flags". [...] > This e-mail

Re: [PATCH v2 weston 1/6] xwm: fix render format look up

2012-07-16 Thread Uli Schlachter
On 16.07.2012 16:32, Tiago Vignatti wrote: we were using wrong iterator for xcb_render_pictforminfo_t type, the formats_reply->length; valgrind was shouting it loudly. Another issue this patch addresses is that now find_depth returns the first util and valid format that matches the desired depth;