Re: Question about cairo-gl

2014-05-14 Thread Stanislav Vorobiov
Hi, IMHO cairo gl isn't much tested/supported in weston since it has bad performance, you should probably just use sw cairo. Thanks. On 05/14/2014 11:56 PM, Bill Spitzak wrote: > The wayland build instructions also include the building of pixman and cairo > in order to enable the cairo gl back

[PATCH weston v3 0/5] improving support for systems without a pointer device

2014-05-13 Thread Stanislav Vorobiov
This is v2 patch rebased against master. I've tested it on my systems, seems ok. The only thing I find strange is exposay animation, it looks like zoom in/out is reversed, but that happens without this patch as well, also, this happened with weston 1.4 Stanislav Vorobiov (5): shell: su

[PATCH weston v3 5/5] shared/frame: fix frame buttons for touchscreen

2014-05-13 Thread Stanislav Vorobiov
support frame buttons hovering with touchscreen and cancel button press if a touch was not released over the button that was pressed --- clients/window.c| 14 ++ shared/cairo-util.h |3 +++ shared/frame.c | 44 ++-- 3 files chang

[PATCH weston v3 2/5] shell: support zooming without a pointer device

2014-05-13 Thread Stanislav Vorobiov
if the system doesn't have a pointer device do_zoom will crash on accessing seat->pointer->x. here we implement zoom support on systems with a touchscreen, touchscreen's last touch point is simply used instead of pointer's current position --- desktop-shell/shell.c | 22 -- s

[PATCH weston v3 4/5] exposay: support systems without a pointer device

2014-05-13 Thread Stanislav Vorobiov
if the system doesn't have a pointer device exposay_transition_active will crash in weston_pointer_start_grab(seat->pointer, ...). here we fix that and also implement exposay support on systems with a touchscreen --- desktop-shell/exposay.c | 95 --- d

[PATCH weston v3 3/5] data-device: fix crash on systems with no pointer device

2014-05-13 Thread Stanislav Vorobiov
--- src/data-device.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/src/data-device.c b/src/data-device.c index 6a81bc8..abab735 100644 --- a/src/data-device.c +++ b/src/data-device.c @@ -421,6 +421,7 @@ static void drag_grab_touch_down(struct weston_t

[PATCH weston v3 1/5] shell: support window resizing using touchscreen

2014-05-13 Thread Stanislav Vorobiov
if the system doesn't have a pointer device common_surface_resize will crash on accessing seat->pointer->button_count. if the system does have a pointer device, but attempts to resize a window using touchscreen - nothing happens. here we implement separate window resizing path for seat->touch as it

Re: [PATCH 1/2] cairo-util: Add frame_touch_motion support

2014-05-13 Thread Stanislav Vorobiov
Hi, Recently I've sent patches to ML that implement just that, see - http://lists.freedesktop.org/archives/wayland-devel/2014-May/014602.html I got no comments on them though... On 05/13/2014 02:14 PM, Boyan Ding wrote: > Hi Jason, > > In writing v2 of the patches I found out frame_touch_motion

[PATCH weston v2 3/5] data-device: fix crash on systems with no pointer device

2014-05-06 Thread Stanislav Vorobiov
--- src/data-device.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/src/data-device.c b/src/data-device.c index 6a81bc8..abab735 100644 --- a/src/data-device.c +++ b/src/data-device.c @@ -421,6 +421,7 @@ static void drag_grab_touch_down(struct weston_t

[PATCH weston v2 5/5] shared/frame: fix frame buttons for touchscreen

2014-05-06 Thread Stanislav Vorobiov
support frame buttons hovering with touchscreen and cancel button press if a touch was not released over the button that was pressed --- clients/window.c| 14 ++ shared/cairo-util.h |3 +++ shared/frame.c | 44 ++-- 3 files chang

[PATCH weston v2 1/5] shell: support window resizing using touchscreen

2014-05-06 Thread Stanislav Vorobiov
if the system doesn't have a pointer device common_surface_resize will crash on accessing seat->pointer->button_count. if the system does have a pointer device, but attempts to resize a window using touchscreen - nothing happens. here we implement separate window resizing path for seat->touch as it

[PATCH weston v2 2/5] shell: support zooming without a pointer device

2014-05-06 Thread Stanislav Vorobiov
if the system doesn't have a pointer device do_zoom will crash on accessing seat->pointer->x. here we implement zoom support on systems with a touchscreen, touchscreen's last touch point is simply used instead of pointer's current position --- desktop-shell/shell.c | 22 -- s

[PATCH weston v2 0/5] improving support for systems without a pointer device

2014-05-06 Thread Stanislav Vorobiov
upd: one more patch that fixes frame buttons reaction for touchscreens Stanislav Vorobiov (5): shell: support window resizing using touchscreen shell: support zooming without a pointer device data-device: fix crash on systems with no pointer device exposay: support systems without a

[PATCH weston v2 4/5] exposay: support systems without a pointer device

2014-05-06 Thread Stanislav Vorobiov
if the system doesn't have a pointer device exposay_transition_active will crash in weston_pointer_start_grab(seat->pointer, ...). here we fix that and also implement exposay support on systems with a touchscreen --- desktop-shell/exposay.c | 95 --- d

[PATCH weston 2/4] shell: support zooming without a pointer device

2014-05-06 Thread Stanislav Vorobiov
if the system doesn't have a pointer device do_zoom will crash on accessing seat->pointer->x. here we implement zoom support on systems with a touchscreen, touchscreen's last touch point is simply used instead of pointer's current position --- desktop-shell/shell.c | 22 -- s

[PATCH weston 4/4] exposay: support systems without a pointer device

2014-05-06 Thread Stanislav Vorobiov
if the system doesn't have a pointer device exposay_transition_active will crash in weston_pointer_start_grab(seat->pointer, ...). here we fix that and also implement exposay support on systems with a touchscreen --- desktop-shell/exposay.c | 95 --- d

[PATCH weston 1/4] shell: support window resizing using touchscreen

2014-05-06 Thread Stanislav Vorobiov
if the system doesn't have a pointer device common_surface_resize will crash on accessing seat->pointer->button_count. if the system does have a pointer device, but attempts to resize a window using touchscreen - nothing happens. here we implement separate window resizing path for seat->touch as it

[PATCH weston 0/4] improving support for systems without a pointer device

2014-05-06 Thread Stanislav Vorobiov
to exposay Stanislav Vorobiov (4): shell: support window resizing using touchscreen shell: support zooming without a pointer device data-device: fix crash on systems with no pointer device exposay: support systems without a pointer device clients/window.c|5 +- desktop-shell/exposa

[PATCH weston 3/4] data-device: fix crash on systems with no pointer device

2014-05-06 Thread Stanislav Vorobiov
--- src/data-device.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/src/data-device.c b/src/data-device.c index 6a81bc8..a80f271 100644 --- a/src/data-device.c +++ b/src/data-device.c @@ -650,11 +650,13 @@ data_device_start_drag(struct wl_client *client, s

[PATCH] shell: support zooming without a pointer device

2014-05-05 Thread Stanislav Vorobiov
ter device experience other crashes, e.g. when using "drag and drop" or exposay, IMHO it makes sense to fix those as well with separate patches... Stanislav Vorobiov (1): shell: support zooming without a pointer device desktop-shell/shell.c | 22 -- src/comp

[PATCH] shell: support zooming without a pointer device

2014-05-05 Thread Stanislav Vorobiov
if the system doesn't have a pointer device do_zoom will crash on accessing seat->pointer->x. here we implement zoom support on systems with a touchscreen, touchscreen's last touch point is simply used instead of pointer's current position --- desktop-shell/shell.c | 22 -- s

[PATCH v4] shell: support window resizing using touchscreen

2014-05-05 Thread Stanislav Vorobiov
= 0 to shell_touch_grab_end Stanislav Vorobiov (1): shell: support window resizing using touchscreen clients/window.c |5 +- desktop-shell/shell.c | 153 ++--- shared/cairo-util.h |2 +- shared/frame.c| 20 --- 4 files c

[PATCH v4] shell: support window resizing using touchscreen

2014-05-05 Thread Stanislav Vorobiov
if the system doesn't have a pointer device common_surface_resize will crash on accessing seat->pointer->button_count. if the system does have a pointer device, but attempts to resize a window using touchscreen - nothing happens. here we implement separate window resizing path for seat->touch as it

Re: [PATCH v3] shell: support window resizing using touchscreen

2014-04-25 Thread Stanislav Vorobiov
Ping On 04/23/2014 05:41 PM, Jason Ekstrand wrote: > > > > On Wed, Apr 23, 2014 at 1:02 AM, Stanislav Vorobiov <mailto:s.vorob...@samsung.com>> wrote: > > if the system doesn't have a pointer device > common_surface_resize will crash on > acc

[PATCH v3] shell: support window resizing using touchscreen

2014-04-22 Thread Stanislav Vorobiov
Right, didn't see that theme_get_location can also return THEME_LOCATION_TITLEBAR, fixed that Stanislav Vorobiov (1): shell: support window resizing using touchscreen clients/window.c |5 +- desktop-shell/shell.c | 153 ++--- shared/

[PATCH v3] shell: support window resizing using touchscreen

2014-04-22 Thread Stanislav Vorobiov
if the system doesn't have a pointer device common_surface_resize will crash on accessing seat->pointer->button_count. if the system does have a pointer device, but attempts to resize a window using touchscreen - nothing happens. here we implement separate window resizing path for seat->touch as it

[PATCH v2] shell: support window resizing using touchscreen

2014-04-22 Thread Stanislav Vorobiov
Jason, I've fixed that. Also, I've fixed 2 other issue reported via IRC: * the "top-left resize" problem * the "mouse + touchscreen can't resize with mouse" problem latter is not tested, I don't have the environment for it Stanislav Vorobiov (1)

[PATCH v2] shell: support window resizing using touchscreen

2014-04-22 Thread Stanislav Vorobiov
if the system doesn't have a pointer device common_surface_resize will crash on accessing seat->pointer->button_count. if the system does have a pointer device, but attempts to resize a window using touchscreen - nothing happens. here we implement separate window resizing path for seat->touch as it

[PATCH] shell: support window resizing using touchscreen

2014-04-22 Thread Stanislav Vorobiov
if the system doesn't have a pointer device common_surface_resize will crash on accessing seat->pointer->button_count. if the system does have a pointer device, but attempts to resize a window using touchscreen - nothing happens. here we implement separate window resizing path for seat->touch as it

[PATCH] egl: add EGL_WAYLAND_Y_INVERTED_WL attribute

2013-09-16 Thread Stanislav Vorobiov
This enables querying of wl_buffer's orientation --- docs/specs/WL_bind_wayland_display.spec | 17 + include/EGL/eglmesaext.h|2 ++ 2 files changed, 19 insertions(+) diff --git a/docs/specs/WL_bind_wayland_display.spec b/docs/specs/WL_bind_wayland_display.sp

[PATCH] egl: add EGL_WAYLAND_Y_INVERTED_WL attribute

2013-09-16 Thread Stanislav Vorobiov
This patch enables querying of wl_buffer's orientation, it's associated with weston commit bfbb8e59fadda112fcdb0bf0a0ed2c0b6c1e1923 gl_renderer: Use EGL_WAYLAND_Y_INVERTED_WL to query wl_buffer's orientation Stanislav Vorobiov (1): egl: add EGL_WAYLAND_Y_INVERTED_WL attribu

Re: [PATCH] Use EGL_WAYLAND_Y_INVERTED_WL to query wl_buffer's orientation

2013-08-29 Thread Stanislav Vorobiov
On 08/30/2013 08:15 AM, Kristian Høgsberg wrote: > On Thu, Aug 29, 2013 at 12:11 AM, Stanislav Vorobiov > wrote: >> On 08/29/2013 09:45 AM, Kristian Høgsberg wrote: >>> On Wed, Aug 28, 2013 at 09:53:19AM +0400, Stanislav Vorobiov wrote: >>>> Any comments on

[PATCH v2] gl_renderer: Use EGL_WAYLAND_Y_INVERTED_WL to query wl_buffer's orientation

2013-08-29 Thread Stanislav Vorobiov
--- src/compositor.c |1 + src/compositor.h |1 + src/gl-renderer.c| 14 +- src/weston-egl-ext.h |4 4 files changed, 19 insertions(+), 1 deletion(-) diff --git a/src/compositor.c b/src/compositor.c index 74f0aab..8c9e0fe 100644 --- a/src/compositor.c ++

Re: [PATCH] Use EGL_WAYLAND_Y_INVERTED_WL to query wl_buffer's orientation

2013-08-29 Thread Stanislav Vorobiov
On 08/29/2013 09:45 AM, Kristian Høgsberg wrote: > On Wed, Aug 28, 2013 at 09:53:19AM +0400, Stanislav Vorobiov wrote: >> Any comments on this one ? > > We already use 0x31D7... we could use 0x31DA I suppose. The other 0x31DA is also used, I guess it's 0x31DB Also, I n

[PATCH] subsurfaces: fix rendering problem with cairo-glesv2

2013-08-27 Thread Stanislav Vorobiov
when using cairo-glesv2 subsurface rendering code implicitly calls eglMakeCurrent(dpy, NULL, NULL, ctx) (since EGL_KHR_surfaceless_context is used), thus, triangle_frame_callback:eglSwapBuffers returns EGL_BAD_SURFACE error for all invocations other that the first one --- clients/subsurfaces.c |

Re: [PATCH] Use EGL_WAYLAND_Y_INVERTED_WL to query wl_buffer's orientation

2013-08-27 Thread Stanislav Vorobiov
Any comments on this one ? On 08/26/2013 01:37 PM, Stanislav Vorobiov wrote: > This patch provides an implementation for > https://bugs.freedesktop.org/show_bug.cgi?id=68041. > Support for EGL_WAYLAND_Y_INVERTED_WL will have to be > added to mesa as well and it'll be

[PATCH] gl_renderer: Use EGL_WAYLAND_Y_INVERTED_WL to query wl_buffer's orientation

2013-08-26 Thread Stanislav Vorobiov
--- src/compositor.c |1 + src/compositor.h |1 + src/gl-renderer.c| 13 - src/weston-egl-ext.h |4 4 files changed, 18 insertions(+), 1 deletion(-) diff --git a/src/compositor.c b/src/compositor.c index 78351eb..b6a4c59 100644 --- a/src/compositor.c +++

[PATCH] Use EGL_WAYLAND_Y_INVERTED_WL to query wl_buffer's orientation

2013-08-26 Thread Stanislav Vorobiov
This patch provides an implementation for https://bugs.freedesktop.org/show_bug.cgi?id=68041. Support for EGL_WAYLAND_Y_INVERTED_WL will have to be added to mesa as well and it'll be a separate patch Stanislav Vorobiov (1): gl_renderer: Use EGL_WAYLAND_Y_INVERTED_WL to query wl_buf