Re: [PATCH] xwm: Handle changing override redirect flag

2018-05-21 Thread Scott Moreau
viewing it soon. Thanks, Scott On Thu, Mar 29, 2018 at 5:17 AM, Pekka Paalanen wrote: > On Sun, 18 Mar 2018 12:22:15 -0600 > Scott Moreau wrote: > > > Xwayland windows might be created with a different override redirect > > flag than is given on map or configure notify. Thi

Re: [PATCH v4 2/2] xwm: Scale icon if size is not the target size

2018-03-23 Thread Scott Moreau
On Fri, Mar 23, 2018 at 2:15 PM, Derek Foreman wrote: > On 2018-03-23 02:47 PM, Scott Moreau wrote: > > This scales the icon cairo surface for the titlebar if it isn't the > > target size. > > > > shared/cairo-util: Add surface resizing function to be used for t

[PATCH v4 1/2] xwm: Choose icon closest to target size

2018-03-23 Thread Scott Moreau
Xwayland clients can offer multiple icon sizes in no particular order. Previously xwm was selecting the first one unconditionally. This patch selects the icon that matches the size closest to the target size. The target size is hard coded to 16 since there is only one theme and the data used to cre

[PATCH v4 2/2] xwm: Scale icon if size is not the target size

2018-03-23 Thread Scott Moreau
This scales the icon cairo surface for the titlebar if it isn't the target size. shared/cairo-util: Add surface resizing function to be used for this case and other potential cases. --- Changed in v2: - Rebase to [PATCH 1/1 v3] xwm: Choose icon closest to target size Changed in v3: - No change

[PATCH v3] xwm: Fix memory leak

2018-03-23 Thread Scott Moreau
A memory leak introduced by 6b58ea8c led to me finding a bigger leak, which is xwm was calling frame_create() without calling frame_destroy(). This meant that the associated icon_surface was not being destroyed, leaving the destroy handler for it broken. Here we fix this by calling frame_destroy()

Re: [PATCH v2] xwm: Fix memory leak

2018-03-23 Thread Scott Moreau
Hi Derek, On Fri, Mar 23, 2018 at 12:22 PM, Derek Foreman wrote: > On 2018-03-20 10:26 AM, Scott Moreau wrote: > > A memory leak introduced by 6b58ea8c led to me finding a bigger > > leak, which is xwm was calling frame_create() without calling > > frame_destroy()

Re: [PATCH v3] xwm: Choose icon closest to target size

2018-03-23 Thread Scott Moreau
gt; Thanks for reviewing this. > > This seems to be a good step towards repair, comments inline below. > > On 2018-03-22 12:47 AM, Scott Moreau wrote: > > Xwayland clients can offer multiple icon sizes in no particular order. > > Previously xwm was selecting the first one unco

Re: [PATCH 2/2 v2] xwm: Scale icon if size is not the target size

2018-03-23 Thread Scott Moreau
Hi Derek, On Fri, Mar 23, 2018 at 11:59 AM, Derek Foreman wrote: > On 2018-03-22 01:04 AM, Scott Moreau wrote: > > This scales the icon cairo surface for the titlebar if it isn't the > > target size. > > > > shared/cairo-util: Add surface resizing function to be

[PATCH 2/2 v2] xwm: Scale icon if size is not the target size

2018-03-21 Thread Scott Moreau
This scales the icon cairo surface for the titlebar if it isn't the target size. shared/cairo-util: Add surface resizing function to be used for this case and other potential cases. --- Changed in v2: - Rebase to [PATCH 1/1 v3] xwm: Choose icon closest to target size shared/cairo-util.c

[PATCH v3] xwm: Choose icon closest to target size

2018-03-21 Thread Scott Moreau
Xwayland clients can offer multiple icon sizes in no particular order. Previously xwm was selecting the first one unconditionally. This patch selects the icon that matches the size closest to the target size. The target size is hard coded to 16 since there is only one theme and the data used to cre

[PATCH v2] xwm: Choose icon closest to target size

2018-03-21 Thread Scott Moreau
Xwayland clients can offer multiple icon sizes in no particular order. Previously xwm was selecting the first one unconditionally. This patch selects the icon that matches the size closest to the target size. The target size is hard coded to 16 since there is only one theme and the data used to cre

[PATCH 1/2] xwm: Choose icon closest to target size

2018-03-21 Thread Scott Moreau
Xwayland clients can offer multiple icon sizes in no particular order. Previously xwm was selecting the first one unconditionally. This patch selects the icon that matches the size closest to the target size. The target size is hard coded to 16 since there is only one theme and the data used to cre

[PATCH 2/2] xwm: Scale icon if size is not the target size

2018-03-21 Thread Scott Moreau
This scales the icon cairo surface for the titlebar if it isn't the right size. shared/cairo-util: Add surface resizing function to be used for this case and other potential cases. --- shared/cairo-util.c | 61 +++ shared/cairo-util.h | 4 +

[PATCH v2] xwm: Fix memory leak

2018-03-20 Thread Scott Moreau
A memory leak introduced by 6b58ea8c led to me finding a bigger leak, which is xwm was calling frame_create() without calling frame_destroy(). This meant that the associated icon_surface was not being destroyed, leaving the destroy handler for it broken. Here we fix this by calling frame_destroy()

Re: [PATCH] xwm: Fix memory leak

2018-03-20 Thread Scott Moreau
Hi Pekka, On Tue, Mar 20, 2018 at 2:21 AM, Pekka Paalanen wrote: > On Mon, 19 Mar 2018 18:06:03 -0600 > Scott Moreau wrote: > > > Fix memory leak introduced by 6b58ea8c. weston_wm_handle_icon() was > > calling xcb_get_property_reply() without freeing the reply. > &g

[PATCH] xwm: Fix memory leak

2018-03-19 Thread Scott Moreau
Fix memory leak introduced by 6b58ea8c. weston_wm_handle_icon() was calling xcb_get_property_reply() without freeing the reply. --- xwayland/window-manager.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xwayland/window-manager.c b/xwayland/window-manager.c index c307e19..24e7213 100644 --

Re: [PATCH v2] xwm: Update input region on resize

2018-03-19 Thread Scott Moreau
On Mon, Mar 19, 2018 at 1:13 PM, Derek Foreman wrote: > On 2018-03-16 06:42 PM, Scott Moreau wrote: > >> Hi Pekka, >> >> On Fri, Mar 16, 2018 at 9:20 AM, Pekka Paalanen > <mailto:ppaala...@gmail.com>> wrote: >> >> On Tue, 13 Mar 2018 21:22:04 -

[PATCH] xwm: Send configure event when moving

2018-03-18 Thread Scott Moreau
Send a synthetic configure notify event to the reparented window to update the position in Xwayland. This fixes menu positioning in clients like VLC after moving the window. --- xwayland/window-manager.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/xwayland/wind

[PATCH] xwm: Fix wrong input offset for certain clients

2018-03-18 Thread Scott Moreau
Some windows might get a create_notify event without the override redirect flag set and then get a confiure_notify event before map_request is received. This means that when weston_wm_window_get_child_position is called in response to configure_notify, the wrong offsets are computed resulting in wr

[PATCH] xwm: Handle changing override redirect flag

2018-03-18 Thread Scott Moreau
Xwayland windows might be created with a different override redirect flag than is given on map or configure notify. This causes confusion about whether a window should be treated as override redirect or not. Here we handle the changing override redirect flag in relevant notify handlers so windows a

Re: [PATCH v2] xwm: Update input region on resize

2018-03-16 Thread Scott Moreau
Hi Pekka, On Fri, Mar 16, 2018 at 9:20 AM, Pekka Paalanen wrote: > On Tue, 13 Mar 2018 21:22:04 -0600 > Scott Moreau wrote: > > > Commit 332d1892 introduced a bug because the window was > > shaped only when the frame was created, leaving the input > > region unchang

[PATCH v2] xwm: Update input region on resize

2018-03-13 Thread Scott Moreau
Commit 332d1892 introduced a bug because the window was shaped only when the frame was created, leaving the input region unchanged regardless if the window was resized. This patch updates the input region shape on resize, fixing the problem. --- Changed in v2: - Bail in shape function if (window

[PATCH] xwm: Update input region on resize

2018-02-19 Thread Scott Moreau
Commit 332d1892 introduced a bug because the window was shaped only when the frame was created, leaving the input region unchanged regardless if the window was resized. This patch updates the input region shape on resize, fixing the problem. --- xwayland/window-manager.c | 46 +

Re: [PATCH 2/3] xwayland: Shape window region to clip shadow area from input

2017-12-22 Thread Scott Moreau
On Tue, Dec 5, 2017 at 7:31 AM, Daniel Stone wrote: > Hi Scott, > > On 24 June 2017 at 08:18, Scott Moreau wrote: > > Decorated windows were getting the size of the window including the > > shadow which is correct, but causing some confusion for motion input > > even

Re: [PATCH weston 1/1] xwayland - input size calculation correction

2017-12-22 Thread Scott Moreau
Hi Ian and Nandor, I tested the initial patch and verified it does not fix the scenario I'm trying, which is with two partially overlapping xcalc windows and hovering the mouse over the buttons of the one below. Ian: The patch you submitted fixes the problem. A couple topical things I noticed ar

Re: [PATCH 3/3] xwayland: Fix override redirect window positioning

2017-06-30 Thread Scott Moreau
On Sat, Jun 24, 2017 at 1:18 AM, Scott Moreau wrote: > When override redirect windows are created, the x/y offsets > provided at map time may be incorrect. The correct offsets are > sent in a configure event from the xserver some time later. > Here we fix the positions by delaying

[PATCH 2/3] xwayland: Shape window region to clip shadow area from input

2017-06-24 Thread Scott Moreau
Decorated windows were getting the size of the window including the shadow which is correct, but causing some confusion for motion input events. This was exhibited when one xwayland window overlaps another, hovering over the window beneath recieves no events if within the 32 pixel shadow border are

[PATCH 3/3] xwayland: Fix override redirect window positioning

2017-06-24 Thread Scott Moreau
When override redirect windows are created, the x/y offsets provided at map time may be incorrect. The correct offsets are sent in a configure event from the xserver some time later. Here we fix the positions by delaying the call to set_xwayland() from map time to the needed configure event in the

[PATCH 1/3] xwayland: Fix input coordinates of non-decorated windows

2017-06-24 Thread Scott Moreau
Windows without decorations drawn by the xwayland window manager had wrong input coordinates because weston_wm_window_get_child_position was giving wrong x/y offsets. Set the offsets to 0 for windows without system decorations. --- xwayland/window-manager.c | 2 +- 1 file changed, 1 insertion(+),

Re: [PATCH] xwayland: Fix input coordinates of shadowless CSD windows

2017-06-24 Thread Scott Moreau
On Thu, May 18, 2017 at 6:26 AM, Pekka Paalanen wrote: > On Tue, 2 May 2017 10:24:17 -0600 > Scott Moreau wrote: > > > This fixes wrong input coordinates when using clients like steam, > > that draw their own decorations and have no shadows. > > --- > >

[PATCH] xwayland: Fix input coordinates of shadowless CSD windows

2017-05-02 Thread Scott Moreau
This fixes wrong input coordinates when using clients like steam, that draw their own decorations and have no shadows. --- xwayland/window-manager.c | 30 +- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/xwayland/window-manager.c b/xwayland/window-mana

[PATCH 1/2] Restore zoom-follows-text-cursor functionality

2017-04-28 Thread Scott Moreau
This restores the functionality removed by a7af70436. It demonstrates text-cursor-position protocol that can be seen when typing in weston-terminal while zoomed in. --- desktop-shell/shell.c | 3 +- libweston/compositor.c | 2 +- libweston/compositor.h | 18 +++- libweston/zoom.c |

Re: Scott Moreau Banned From Official Wayland IRC Channel

2013-03-25 Thread Scott Moreau
On Mon, Mar 25, 2013 at 4:34 PM, Dave Airlie wrote: > On Tue, Mar 26, 2013 at 8:10 AM, Scott Moreau wrote: >> I wanted to make it public, that I have been officially banned from >> #wayland on irc.frenode.net by krh. I have never seen him ban anyone >> from his channel an

Scott Moreau Banned From Official Wayland IRC Channel

2013-03-25 Thread Scott Moreau
I wanted to make it public, that I have been officially banned from #wayland on irc.frenode.net by krh. I have never seen him ban anyone from his channel and I do not believe he has any intention of lifting the ban. This goes to show, that my efforts are in fact completely unwelcome by Kristian. I

Re: Compiz is Dead - Beryl Lives Again? Enter - Northfield/Norwood

2013-03-25 Thread Scott Moreau
On Mon, Mar 25, 2013 at 3:08 PM, Thiago Macieira wrote: > On segunda-feira, 25 de março de 2013 14.45.21, Scott Moreau wrote: >> Northfield stands on the shoulders of giants, years worth of work and >> history to get to the point where we are today. It has been some 8 >> y

Re: Compiz is Dead - Beryl Lives Again? Enter - Northfield/Norwood

2013-03-25 Thread Scott Moreau
Hi Casey, On Mon, Mar 25, 2013 at 2:28 PM, Casey Dahlin wrote: > On Mon, Mar 25, 2013 at 02:14:23PM -0600, Scott Moreau wrote: >> Sorry, I misspoke here. What I meant was, "This isn't about the >> wayland core protocol, the core wayland developers have this part >>

Re: Compiz is Dead - Beryl Lives Again? Enter - Northfield/Norwood

2013-03-25 Thread Scott Moreau
> > Casey: The point is, this isn't just a frivolous fork. This isn't > about wayland. Sorry, I misspoke here. What I meant was, "This isn't about the wayland core protocol, the core wayland developers have this part covered. This is about raising the bar on the effects users expect to see in a wa

Re: Compiz is Dead - Beryl Lives Again? Enter - Northfield/Norwood

2013-03-25 Thread Scott Moreau
On Mon, Mar 25, 2013 at 1:11 PM, Casey Dahlin wrote: > On Mon, Mar 25, 2013 at 12:59:22PM -0600, Scott Moreau wrote: >> Hi Casey, >> >> On Mon, Mar 25, 2013 at 12:53 PM, Casey Dahlin wrote: >> > On Mon, Mar 25, 2013 at 12:51:07PM -0600, Scott Moreau wrote: >>

Re: Compiz is Dead - Beryl Lives Again? Enter - Northfield/Norwood

2013-03-25 Thread Scott Moreau
Hi Casey, On Mon, Mar 25, 2013 at 12:53 PM, Casey Dahlin wrote: > On Mon, Mar 25, 2013 at 12:51:07PM -0600, Scott Moreau wrote: >> Yes, there is no reason to fork libwayland. And I don't feel this is a >> true fork, just a temporary rename to avoid the confusion it migh

Re: Compiz is Dead - Beryl Lives Again? Enter - Northfield/Norwood

2013-03-25 Thread Scott Moreau
Hey Casey, On Mon, Mar 25, 2013 at 12:46 PM, Casey Dahlin wrote: > On Mon, Mar 25, 2013 at 12:41:59PM -0600, Scott Moreau wrote: >> "The key point to understand is, that this is not a new protocol in its >> own right. It *is* the wayland protocol, with a few minor addit

Re: Compiz is Dead - Beryl Lives Again? Enter - Northfield/Norwood

2013-03-25 Thread Scott Moreau
Hi Casey, On Mon, Mar 25, 2013 at 12:00 PM, Casey Dahlin wrote: > On Mon, Mar 25, 2013 at 02:43:27AM -0600, Scott Moreau wrote: >> What Northfield *is not* >> - A fork that will change protocol in fundamental ways that diverts >> from the wayland EGL spec >> - A

Compiz is Dead - Beryl Lives Again? Enter - Northfield/Norwood

2013-03-25 Thread Scott Moreau
: Yes, I am a little crazy. But you need to be in order to be interested in compositing environments at the level I am. I would like to thank all the developers involved and the core community that represents the greater good force in the world, for making this possible. Sincerely, Scott Moreau ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: GH-Next Feature Update

2013-03-24 Thread Scott Moreau
Hi Daniels, > > OK, I guess it's no longer Wayland/Weston then (in which case the repo & IRC > channel names are pretty misleading - if you don't plan on submitting > anything, it's hard to see how it could be 'next'). Yes, I am not very content with this either. The very initial goal was simply

Re: GH-Next Feature Update

2013-03-24 Thread Scott Moreau
On Sun, Mar 24, 2013 at 9:00 AM, Jonas Kulla wrote: > 2013/3/24 Scott Moreau >> > > > Hi, > > the video you uploaded is blocked in Germany due to music related copyright > stuff. > Is there any way you could upload it without that music? I'd really like to >

Re: GH-Next Feature Update

2013-03-24 Thread Scott Moreau
On Sun, Mar 24, 2013 at 6:17 AM, Daniel Stone wrote: > Hi, > > On 24 March 2013 11:29, Scott Moreau wrote: >> >> On Sun, Mar 24, 2013 at 5:13 AM, Daniel Stone >> wrote: >> > On 24 March 2013 10:27, Scott Moreau wrote: >> >> - Working xwayland

Re: GH-Next Feature Update

2013-03-24 Thread Scott Moreau
Hi Daniels, On Sun, Mar 24, 2013 at 5:13 AM, Daniel Stone wrote: > On 24 March 2013 10:27, Scott Moreau wrote: >> >> - Working xwayland titlebar buttons > > > Did that patchset get submitted to the list for review? If not, will it be? No. These patches breaks many of t

GH-Next Feature Update

2013-03-24 Thread Scott Moreau
Hi all, I announced about a week ago that I was starting a series of branches on github labeled next, as a staging area for new features and patch sets. The response is continually surprising and we've got a lot done in just one week. I wanted to share an update with everyone and explain a little

Re: [PATCH wayland v3] protocol: Add minimize/maximize protocol

2013-03-23 Thread Scott Moreau
gt; meant). You need to stop ignoring him and writing off everything he > says as worthless. At the very least you need to act towards him in a > more professional manner. Don't care about Bill. He doesn't contribute, he wastes time. You are beginning to do the same thing by trolli

Re: [PATCH wayland v3] protocol: Add minimize/maximize protocol

2013-03-22 Thread Scott Moreau
On Fri, Mar 22, 2013 at 7:09 PM, Bill Spitzak wrote: > The underlying problem is that if a window is full-screen or maximized, and > you minimize it, then un-minimize should put it back to full-screen or > maximized. Thus un-minimize cannot be the "normal" state. > > The compositor could track the

Re: [PATCH wayland v3] protocol: Add minimize/maximize protocol

2013-03-22 Thread Scott Moreau
Hi Pekka, thanks for your comments here. > > Scott, > > do you mean that these unminimize, unmaximize, etc. requests would > actually work like undo? Unmaximize would undo what the last > maximization did, as opposed to just set_normal which might do > something slightly different since its aim is

[PATCH weston] shell: Shorten some of the longer lines

2013-03-21 Thread Scott Moreau
Function declarations that were spilling way over the 82 char limit are split up into multiple lines to better adhere to line length limit. --- src/shell.c | 27 ++- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/src/shell.c b/src/shell.c index 541cb76..6a

Re: [PATCH wayland v3] protocol: Add minimize/maximize protocol

2013-03-21 Thread Scott Moreau
Hi Jason, On Thu, Mar 21, 2013 at 9:39 AM, Jason Ekstrand wrote: > Hi Scott, > >> One important thing to note here is that client != surface. In fact, >> clients can have multiple surfaces. We might need to keep this in mind >> for things like closing single surfaces demonstrated here >> https://

Re: [PATCH wayland v3] protocol: Add minimize/maximize protocol

2013-03-20 Thread Scott Moreau
Hi Jason, On Wed, Mar 20, 2013 at 7:56 PM, Jason Ekstrand wrote: > Scott et. al, > I'm not going to try and answer everything because a lot has happened > on this topic and I think we're on the same page on most of the > technical details. > > >>> Here is how I think I would have such a protocol

Re: Auto key repeat in wayland.

2013-03-19 Thread Scott Moreau
Hi Brenden, On Tue, Mar 19, 2013 at 9:01 AM, Friar wrote: > Please also consider the case of video games that are running in > non-full-screen mode that don't WANT key auto-repeat. They should have a > way to turn off repeated notifications. Having to wade through a ton of > auto-repeated keybo

Re: [PATCH wayland v3] protocol: Add minimize/maximize protocol

2013-03-18 Thread Scott Moreau
On Mon, Mar 18, 2013 at 3:29 PM, Bill Spitzak wrote: > Scott Moreau wrote: > >> Note to Bill Spitzac: I find your posts to be often frivolous and >> incoherent. I don't mean to be rude here but I have tried to consider >> many of your points and you often go on long t

Re: [PATCH wayland v3] protocol: Add minimize/maximize protocol

2013-03-18 Thread Scott Moreau
description. if this is the case, we should add it to the protocol description and change the clients accordingly. As I understand, eglSwapBuffers() automatically blocks on each call to sync properly. So even if you called it at the 'wrong' time (i.e. outside of the frame event handler)

Re: Auto key repeat in wayland.

2013-03-17 Thread Scott Moreau
On Sun, Mar 17, 2013 at 7:47 PM, Yichao Yu wrote: > Hi Scott, > > On Sun, Mar 17, 2013 at 8:51 PM, Scott Moreau wrote: >> On Sun, Mar 17, 2013 at 5:36 PM, Yichao Yu wrote: >>> Hi, >>> >>> Seems that weston uses a client side keyboard auto-repeat

Re: [PATCH wayland v3] protocol: Add minimize/maximize protocol

2013-03-17 Thread Scott Moreau
Hi Jason, Thanks for your reply. On Sun, Mar 17, 2013 at 7:24 PM, Jason Ekstrand wrote: > On Fri, Mar 8, 2013 at 4:39 PM, Scott Moreau wrote: >> >> >> On Fri, Mar 8, 2013 at 3:28 PM, Bill Spitzak wrote: >>> >>> Scott Moreau wrote: >>> >>&

Re: Auto key repeat in wayland.

2013-03-17 Thread Scott Moreau
On Sun, Mar 17, 2013 at 5:36 PM, Yichao Yu wrote: > Hi, > > Seems that weston uses a client side keyboard auto-repeat that is > HARD-CODED in `window.c` and I haven't seen anywhere in wayland's > mentioning how this should be done in wayland. There doesn't seem to > be a place where the client can

Re: [PATCH] Eat scroll event if a key binding function is executed because of it.

2013-03-16 Thread Scott Moreau
he scroll event so the underlying window > doesn't receive it. > Thanks to Scott Moreau for helping me solve this. > --- > src/bindings.c |5 - > src/compositor.c |9 + > src/compositor.h |2 +- > 3 files changed, 10 insertions(+), 6 deletions(-)

Re: [PATCH wayland 0/6] Add wl_object based custom dispatchers support

2013-03-16 Thread Scott Moreau
wrote: > Kristian, > Working with Scott Moreau to get this applied to his "next" branch > demonstrated that this series is a bit tricky to apply. In order to > do everything correctly, it needs to be applied in three stages: > > First, apply the follo

Re: [PATCH weston 1/2] weston-launch: move function calls out of assert()

2013-03-16 Thread Scott Moreau
This looks better, applied to gh next. - Scott On Sat, Mar 9, 2013 at 11:38 AM, Philipp Brüschweiler wrote: > --- > src/weston-launch.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/src/weston-launch.c b/src/weston-launch.c > index bc7f8a2..98f0111 100644 >

Re: [PATCH 0/4] improve window maximize handling

2013-03-16 Thread Scott Moreau
Hi Rafal, These all look good, merged with gh next. Thanks for the fixes! - Scott On Mon, Mar 11, 2013 at 12:26 PM, Rafal Mielniczuk wrote: > Hi > > This series of patches improves a bit handling of maximized windows in desktop > shell. > > There were some inconsistencies like window could be m

Re: [PATCH] compositor-drm: Inspect result of gbm_create_device.

2013-03-16 Thread Scott Moreau
Hi John, Thanks, committed to gh next. - Scott On Sat, Mar 2, 2013 at 4:27 AM, John Kåre Alsaker wrote: > --- > src/compositor-drm.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/compositor-drm.c b/src/compositor-drm.c > index 3c44f7a..f60fce9 100644 > --- a/src/compositor-dr

Re: [PATCH weston 2/2] compositor-drm: Fix inconsistency in finish frame timestamps

2013-03-16 Thread Scott Moreau
I picked this one up for gh next, since a lot of people were having a problem with this. Animations stalling, especially. - Scott On Wed, Feb 13, 2013 at 7:06 AM, Ander Conselvan de Oliveira wrote: > The page flip event timestamps comes from the monotonic clock, while > idle_repaint() gets the t

Re: [PATCH wayland] client: Invoke new_id closure arguments as pointers instead of integers

2013-03-16 Thread Scott Moreau
Committed in gh next. - Scott On Fri, Mar 15, 2013 at 8:47 AM, Michael Hasselmann wrote: > Could we get this merged please? It fixes an annoying crasher bug for us > (see FDO#62367). > > Thanks, > Michael > > On Fri, 2013-03-08 at 18:44 +0100, Jonas Ådahl wrote: >> This commit adds a flags param

Re: [PATCH weston] Fix memory leaks

2013-03-16 Thread Scott Moreau
Pushed to gh next. On Thu, Mar 7, 2013 at 10:15 AM, Scott Moreau wrote: > Fix a couple leaks caught by valgrind. > --- > src/gl-renderer.c |2 ++ > src/shell.c |1 + > 2 files changed, 3 insertions(+) > > diff --git a/src/gl-renderer.c b/src/gl-renderer.c >

Re: Introduce panel window list and surface minimize protocol

2013-03-16 Thread Scott Moreau
This entire series committed to gh next. On Thu, Mar 7, 2013 at 9:47 PM, Scott Moreau wrote: > This series implements a window list for the panel. It introduces protocol for > minimize/maximize control of shell_surfaces. It also provides a basic > minimize implementation. > > Ad

Re: [PATCH] pixman-renderer: don't forget to initialize the debug fields

2013-03-16 Thread Scott Moreau
Pushed to gh next. - Scott On Fri, Mar 8, 2013 at 12:35 PM, Philipp Brüschweiler wrote: > Fixes https://bugs.freedesktop.org/show_bug.cgi?id=61930 > --- > src/pixman-renderer.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/pixman-renderer.c b/src/pixman-renderer.c > index 9571f

Re: [PATCH weston 1/2] compositor: remove unused field option_idle_time

2013-03-16 Thread Scott Moreau
Pushed to gh next. - Scott On Sun, Mar 10, 2013 at 7:37 AM, Philipp Brüschweiler wrote: > --- > src/compositor.c | 1 - > src/compositor.h | 3 +-- > 2 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/src/compositor.c b/src/compositor.c > index a2860fd..7df9658 100644 > --- a/src/

Re: [PATCH 2/3 v3] compositor: turn off the idle timer when sleeping

2013-03-16 Thread Scott Moreau
Hi Philipp, Thanks for your attention to this. Pushed to gh next. - Scott On Sun, Mar 10, 2013 at 9:08 AM, Philipp Brüschweiler wrote: > Also updates the drm, fbdev and rpi backend to use > weston_compositor_set_sleeping() and not set the state manually. > > Fixes https://bugs.freedesktop.org/s

Re: [PATCH] Revert "weston.ini: Use 'modeline' key for modeline example"

2013-03-16 Thread Scott Moreau
Pushed to gh next. On Sun, Mar 10, 2013 at 9:30 AM, Scott Moreau wrote: > This reverts commit 97a56145636316fdb431b91ec64adff217287cd9. > > The current code detects the mode key, not modeline. Reference: > http://cgit.freedesktop.org/wayland/weston/tree/src/compositor-drm.c#n2464 &

Re: [PATCH gtk+] wayland: Attach buffer before committing

2013-03-16 Thread Scott Moreau
Pushed to gh next. On Sun, Mar 10, 2013 at 10:55 AM, Scott Moreau wrote: > With recent changes in attach semantics, we always need to attach before > committing. This fixes the problem with wayland gtk clients not updating > surface contents correctly since latest changes regardi

Re: [PATCH gtk+] wayland: Remove unneeded semicolons.

2013-03-16 Thread Scott Moreau
Pushed to gh next. On Sun, Mar 10, 2013 at 12:17 PM, Scott Moreau wrote: > > > On Wed, Oct 24, 2012 at 9:38 PM, Scott Moreau wrote: >> >> --- >> gdk/wayland/gdkdevice-wayland.c | 2 +- >> gdk/wayland/gdkdisplay-wayland.c | 2 +- >> 2 files changed, 2 i

Re: [PATCH v3] shell: grab the parent popup when a sub popup window is deleted or hidden

2013-03-16 Thread Scott Moreau
Thanks for rebasing this to next, pushed. - Scott On Sat, Mar 16, 2013 at 4:59 AM, Giulio Camuffo wrote: > If the client opens a popup menu and submenu, when it closes or hides the > submenu the pointer grab should return to the parent menu. > Furthermore, when clicking outside the client area t

New wayland patch-staging repositories

2013-03-15 Thread Scott Moreau
Hi, I have noticed that there are a flood of patches for wayland and related projects that reach the wayland mailing list. Unfortunately, many of these patches become forgotten or incompatible over time. This can be very frustrating to everyone including contributers, users and developers. I have

Re: [PATCH] xRandr strikes back

2013-03-14 Thread Scott Moreau
On Mon, Mar 11, 2013 at 3:47 PM, Alex Deucher wrote: > On Mon, Mar 11, 2013 at 5:39 PM, Scott Moreau wrote: > > > > > > On Mon, Mar 11, 2013 at 12:59 PM, Pekka Paalanen > > wrote: > >> > >> On Sun, 10 Mar 2013 15:53:30 +0100 > >> H

Re: [PATCH] xRandr strikes back

2013-03-11 Thread Scott Moreau
On Mon, Mar 11, 2013 at 12:59 PM, Pekka Paalanen wrote: > On Sun, 10 Mar 2013 15:53:30 +0100 > Hardening wrote: > > > This patch adds a wlrandr extension. It is useful to test > > mode switching. The patch provides the weston-switch-mode > > utility that can be use quite the same way as xrandr to

Re: [PATCH gtk+] wayland: Remove unneeded semicolons.

2013-03-10 Thread Scott Moreau
On Wed, Oct 24, 2012 at 9:38 PM, Scott Moreau wrote: > --- > gdk/wayland/gdkdevice-wayland.c | 2 +- > gdk/wayland/gdkdisplay-wayland.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gdk/wayland/gdkdevice-wayland.c > b/gdk/wayland/gdkdev

[PATCH gtk+] wayland: Remove unused header

2013-03-10 Thread Scott Moreau
--- gdk/wayland/gdkwindow-wayland.c |1 - 1 file changed, 1 deletion(-) diff --git a/gdk/wayland/gdkwindow-wayland.c b/gdk/wayland/gdkwindow-wayland.c index 00b0c54..d4e8150 100644 --- a/gdk/wayland/gdkwindow-wayland.c +++ b/gdk/wayland/gdkwindow-wayland.c @@ -36,7 +36,6 @@ #include #inclu

[PATCH gtk+] wayland: Attach buffer before committing

2013-03-10 Thread Scott Moreau
With recent changes in attach semantics, we always need to attach before committing. This fixes the problem with wayland gtk clients not updating surface contents correctly since latest changes regarding attach. --- gdk/wayland/gdkwindow-wayland.c |7 --- 1 file changed, 7 deletions(-) di

Re: [PATCH] xRandr strikes back

2013-03-10 Thread Scott Moreau
On Sun, Mar 10, 2013 at 9:17 AM, Jonas Ådahl wrote: > On Sun, Mar 10, 2013 at 3:53 PM, Hardening wrote: > > This patch adds a wlrandr extension. It is useful to test > > mode switching. The patch provides the weston-switch-mode > > utility that can be use quite the same way as xrandr to > > chan

[PATCH] Revert "weston.ini: Use 'modeline' key for modeline example"

2013-03-10 Thread Scott Moreau
This reverts commit 97a56145636316fdb431b91ec64adff217287cd9. The current code detects the mode key, not modeline. Reference: http://cgit.freedesktop.org/wayland/weston/tree/src/compositor-drm.c#n2464 --- I'm not sure where the confusion is here. weston.ini |2 +- 1 file changed, 1 insertio

[PATCH weston v2] compositor-x11: Consider output position when computing relative motion

2013-03-10 Thread Scott Moreau
This fixes pointer movement for multiple x11 outputs. This was broken when switching to relative events. Fixes bug https://bugs.freedesktop.org/show_bug.cgi?id=61672 --- I do not currently have a multi-output setup to test drm but it's possible that evdev needs a similar fix. src/compositor-x11

Re: Clipboard and selection in wayland.

2013-03-09 Thread Scott Moreau
Hi Yichao, On Sat, Mar 9, 2013 at 9:47 PM, Yichao Yu wrote: > Hi, > > In X11 there are CLIPBOARD and PRIMARY selection each correspond to > the current clipboard and selected content and applications can > monitor the change of them using XFixes. In wayland, I have found > wl_data_device which I

[PATCH weston] weston.man: Document the way to disable idle timeout

2013-03-09 Thread Scott Moreau
--- man/weston.man |1 + 1 file changed, 1 insertion(+) diff --git a/man/weston.man b/man/weston.man index e7692c7..39d854b 100644 --- a/man/weston.man +++ b/man/weston.man @@ -117,6 +117,7 @@ seconds. The default timeout is 300 seconds. When there has not been any user input for the idle t

[PATCH xserver] xwayland: Attach buffer before committing

2013-03-09 Thread Scott Moreau
This fixes the wlshm path which was not updating the buffer correctly. --- hw/xfree86/xwayland/xwayland.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/xfree86/xwayland/xwayland.c b/hw/xfree86/xwayland/xwayland.c index d97f4ee..f59bfe4 100644 --- a/hw/xfree86/xwayland/xwayland.c +++

Re: [PATCH wayland v3] protocol: Add minimize/maximize protocol

2013-03-08 Thread Scott Moreau
On Fri, Mar 8, 2013 at 3:28 PM, Bill Spitzak wrote: > Scott Moreau wrote: > > "Further, the term minimize is relatively subjective and defined by the >> implementation. Clients should not expect that minimized means the surface >> will be invisable to the user. There a

Re: [PATCH] pixman-renderer: don't forget to initialize the debug fields

2013-03-08 Thread Scott Moreau
On Fri, Mar 8, 2013 at 1:05 PM, Philipp Brüschweiler wrote: > Sorry, forgot Reply All. > > > On Fri, Mar 8, 2013 at 9:04 PM, Philipp Brüschweiler wrote: > >> On Fri, Mar 8, 2013 at 8:44 PM, Scott Moreau wrote: >> >>> >>> >>> On Fri, Ma

Re: [PATCH wayland v3] protocol: Add minimize/maximize protocol

2013-03-08 Thread Scott Moreau
On Fri, Mar 8, 2013 at 12:50 PM, Bill Spitzak wrote: > Scott Moreau wrote: > > The client doesn't need to be involved >> in a minimize action, unlike (un)maximize, it only needs a way to track >> its >> minimize state and request to be minimized. >> >

Re: [PATCH] pixman-renderer: don't forget to initialize the debug fields

2013-03-08 Thread Scott Moreau
On Fri, Mar 8, 2013 at 12:35 PM, Philipp Brüschweiler wrote: > Fixes https://bugs.freedesktop.org/show_bug.cgi?id=61930 > --- > src/pixman-renderer.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/pixman-renderer.c b/src/pixman-renderer.c > index 9571f6f..9dbe9f0 100644 > --- a/sr

[PATCH weston] compositor-x11: Consider output position when computing relative motion

2013-03-07 Thread Scott Moreau
This fixes pointer movement for multiple x11 outputs. This was broken when switching to relative events. --- I do not currently have a multi-output setup to test drm but it's possible that evdev needs a similar fix. src/compositor-x11.c |8 1 file changed, 4 insertions(+), 4 deletio

[PATCH weston 9/9] shell: Implement maximize menu button functionality

2013-03-07 Thread Scott Moreau
Add maximize button for list item drop down menu. --- clients/desktop-shell.c | 44 +++- clients/window.c|6 ++ src/shell.c | 23 +++ 3 files changed, 68 insertions(+), 5 deletions(-) diff --git a/clients/

[PATCH weston 8/9] shell: Install protocol for maximize menu button

2013-03-07 Thread Scott Moreau
--- protocol/desktop-shell.xml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/protocol/desktop-shell.xml b/protocol/desktop-shell.xml index 51219d2..20e2eb9 100644 --- a/protocol/desktop-shell.xml +++ b/protocol/desktop-shell.xml @@ -87,6 +87,12 @@ The shell can use this

[PATCH weston 7/9] toytoolkit: Enable titlebar minimize button functionality

2013-03-07 Thread Scott Moreau
--- clients/window.c | 25 - clients/window.h |3 +++ src/shell.c |9 - 3 files changed, 35 insertions(+), 2 deletions(-) diff --git a/clients/window.c b/clients/window.c index d13a1ac..7093a38 100644 --- a/clients/window.c +++ b/clients/window.c @@

[PATCH weston 6/9] shell: Install listeners to reflect shell surface protocol changes

2013-03-07 Thread Scott Moreau
--- clients/simple-egl.c | 26 +- clients/simple-shm.c | 26 +- clients/simple-touch.c | 26 +- clients/window.c | 26 +- src/shell.c|9 - 5 files changed, 108

[PATCH weston 5/9] shell: Implement simple dnd for window list item reordering

2013-03-07 Thread Scott Moreau
This allows the user to rearrange the list items by drag-and-drop. There is no drag icon, only preliminary functionality. Eventually, this could be expanded to use the wayland dnd protocol. --- clients/desktop-shell.c | 85 +++ 1 file changed, 85 inser

[PATCH weston 4/9] shell: Implement menu for window list items

2013-03-07 Thread Scott Moreau
Right-click dropdown menu for window list items. This patch introduces a simple minimize feature. The surface is removed from the layer list on minimize and re-added on unminimize. The close item sends the client a SIGTERM signal. --- clients/desktop-shell.c | 154

[PATCH weston 3/9] shell: Install protocol for minimize, focus and close

2013-03-07 Thread Scott Moreau
--- protocol/desktop-shell.xml | 20 1 file changed, 20 insertions(+) diff --git a/protocol/desktop-shell.xml b/protocol/desktop-shell.xml index 2fed660..51219d2 100644 --- a/protocol/desktop-shell.xml +++ b/protocol/desktop-shell.xml @@ -87,6 +87,18 @@ The shell ca

[PATCH weston 2/9] shell: Implement panel window list

2013-03-07 Thread Scott Moreau
This patch uses the special surface_data interface to send information about the surface to the shell. The shell then uses this information to render a window list in the panel. --- clients/desktop-shell.c | 479 +-- data/Makefile.am|1 + da

  1   2   3   4   5   6   >