[PATCH] shell: Save the width and height known by the shell surface.

Instead of using the surface size, save the last known shell surface size, and use that one to emit on configure, when the surface is returning from maximized or fullscreen state. The surface size can't be saved because it will have already changed when the surface is transitioning to fullscreen o

[PATCH] shell: Don't try to switch to a NULL shell surface.

Fixes the crash from alt+tab when there's a fullscreen surface. --- desktop-shell/shell.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index 0b6a97c..18b88f4 100644 --- a/desktop-shell/shell.c +++ b/desktop-shell/shell.c @@ -5174,6 +5174,8 @@

[PATCH] shell: Set a surface as TOPLEVEL instead of the old surface types.

Since internally there's no more SHELL_SURFACE_FULLSCREEN and SHELL_SURFACE_MAXIMIZED, the surface must be set to SHELL_SURFACE_TOPLEVEL on the respective functions. This fixes the bug when clients start already in fullscreen mode. In that case, they aren't set first to toplevel, and then change t

[PATCH v2] shell: Add missing break to a case statement inside set_surface_type.

This should fix the surface not going back to its original position after unsetting fullscreen or maximized states. --- desktop-shell/shell.c | 1 + 1 file changed, 1 insertion(+) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index de54e37..1b63430 100644 --- a/desktop-shell/shell.c

[PATCH] shell: Add missing break to a case statement inside set_surface_type.

This should fix the surface not going back to its original position after unsetting fullscreen or maximized states. --- desktop-shell/shell.c | 3 +++ src/compositor.c | 1 + 2 files changed, 4 insertions(+) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index de54e37..d270c27 10

[PATCH] shell: Fix activate logic on surface map.

It should activate the newly mapped surface if not locked. --- desktop-shell/shell.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index de54e37..05d7814 100644 --- a/desktop-shell/shell.c +++ b/desktop-shell/shell.c @@ -4860,7 +4

Re: [PATCH 04/16] xdg-shell: Implement part of the interface.

On Fri, Nov 29, 2013 at 9:29 PM, Kristian Høgsberg wrote: > On Wed, Nov 27, 2013 at 03:50:20PM -0200, Rafael Antognolli wrote: >> Basic requests are implemented, enough to get a surface displayed. >> --- >> src/.gitignore | 2 + >> src/Makefile.am | 6 +

Re: [PATCH 03/16] shell: Change set_maximized to receive internal structures.

On Fri, Nov 29, 2013 at 9:02 PM, Kristian Høgsberg wrote: > On Wed, Nov 27, 2013 at 03:50:19PM -0200, Rafael Antognolli wrote: >> Change the parameters of set_maximized from wl_resource and wl_client to >> shell_surface and weston_output. This will allow it to be used with &

Re: [PATCH 02/16] shell: Remove SHELL_SURFACE_FULLSCREEN and SHELL_SURFACE_MAXIMIZED.

All done. On Fri, Nov 29, 2013 at 9:00 PM, Kristian Høgsberg wrote: > On Wed, Nov 27, 2013 at 03:50:18PM -0200, Rafael Antognolli wrote: >> These surface types don't exist anymore inside weston desktop shell >> implementation. They are just exposed as wl_shell surface type

Re: [PATCH 06/16] xdg-shell: Implement set_transient_for request.

On Fri, Nov 29, 2013 at 9:39 PM, Kristian Høgsberg wrote: > On Wed, Nov 27, 2013 at 03:50:22PM -0200, Rafael Antognolli wrote: >> The implementation just sets a parent/child relationship between the >> xdg_surface and its parent, passed as argument of this request. Stacking >&

Re: [PATCH 00/16] xdg-shell protocol, implementation and port of toytoolkit.

On Fri, Nov 29, 2013 at 9:54 PM, Kristian Høgsberg wrote: > On Fri, Nov 29, 2013 at 02:23:11PM -0800, Kristian Høgsberg wrote: >> On Wed, Nov 27, 2013 at 03:50:16PM -0200, Rafael Antognolli wrote: >> > As discussed previously, this patch series adds the xdg-shell protocol, its &

[PATCH 7/8] xdg-shell: xdg_surface_set_output should only affect fullscreen.

--- src/shell.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/shell.c b/src/shell.c index dedff68..5c0660e 100644 --- a/src/shell.c +++ b/src/shell.c @@ -346,6 +346,7 @@ struct shell_surface { struct weston_output *fullscreen_output; struct westo

[PATCH 4/8] shell: Move shell_surface_set_parent to wl_shell calls.

The parent update on set_maximized and set_fullscreen is a behavior of wl_shell. That does not happen on xdg-shell, so it can't be in the set_fullscreen and set_maximized common code, but rather in the wl_shell_surface interfaces. --- src/shell.c | 24 +--- 1 file changed, 13

[PATCH 1/8] xdg_shell: Adding a new shell protocol.

100644 index 000..4e5cff8 --- /dev/null +++ b/protocol/xdg-shell.xml @@ -0,0 +1,438 @@ + + + + +Copyright © 2008-2013 Kristian Høgsberg +Copyright © 2013 Rafael Antognolli +Copyright © 2013 Jasper St. Pierre +Copyright © 2010-2013 Intel Corporation + +Permission

[PATCH 2/8] shell: Remove SHELL_SURFACE_FULLSCREEN and SHELL_SURFACE_MAXIMIZED.

These surface types don't exist anymore inside weston desktop shell implementation. They are just exposed as wl_shell surface types, but internally the implementation is done with surface states. The previous behavior (setting a surface type unsets another one) still happens when using wl_shell. T

[PATCH 6/8] xdg-shell: Add surface size to configure.

Also emit configure on unset_maximized and unset_fullscreen. --- src/shell.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/src/shell.c b/src/shell.c index 2bff793..dedff68 100644 --- a/src/shell.c +++ b/src/shell.c @@ -310,7 +310,9 @@ struct shell_surf

[PATCH 8/8] xdg-shell: Add key bindings for setting maximized and fullscreen.

--- src/shell.c | 52 1 file changed, 52 insertions(+) diff --git a/src/shell.c b/src/shell.c index 5c0660e..c873c5a 100644 --- a/src/shell.c +++ b/src/shell.c @@ -3971,6 +3971,54 @@ move_binding(struct weston_seat *seat, uint32_t time, uint32

[PATCH 5/8] xdg-shell: Implement xdg-shell interface.

The whole xdg-shell interface is implement, except from the "focused_set" and "focused_unset" events. --- src/.gitignore | 2 + src/Makefile.am | 6 +- src/shell.c | 526 ++-- 3 files changed, 518 insertions(+), 16 deletions(-) diff --g

[PATCH 3/8] shell: Remove SHELL_SURFACE_TRANSIENT.

--- src/shell.c | 75 - 1 file changed, 40 insertions(+), 35 deletions(-) diff --git a/src/shell.c b/src/shell.c index 9071727..d346b4c 100644 --- a/src/shell.c +++ b/src/shell.c @@ -239,7 +239,6 @@ struct desktop_shell { enum shell_sur

[PATCH 09/16] xdg-shell: xdg_surface_set_output should only affect fullscreen.

--- src/shell.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/shell.c b/src/shell.c index 7040acc..db8e815 100644 --- a/src/shell.c +++ b/src/shell.c @@ -303,6 +303,7 @@ struct shell_surface { struct weston_output *fullscreen_output; struct westo

[PATCH 16/16] xdg-shell: Add key bindings for setting maximized and fullscreen.

--- clients/window.c | 34 ++ src/shell.c | 46 ++ 2 files changed, 80 insertions(+) diff --git a/clients/window.c b/clients/window.c index 5cac1e1..52f6678 100644 --- a/clients/window.c +++ b/clients/window.c @@ -37

[PATCH 08/16] xdg-shell: Add surface size to configure.

Also emit configure on unset_maximized and unset_fullscreen. --- src/shell.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/src/shell.c b/src/shell.c index 0daa136..7040acc 100644 --- a/src/shell.c +++ b/src/shell.c @@ -267,7 +267,9 @@ struct shell_surf

[PATCH 01/16] xdg_shell: Adding a new shell protocol.

100644 index 000..4e5cff8 --- /dev/null +++ b/protocol/xdg-shell.xml @@ -0,0 +1,438 @@ + + + + +Copyright © 2008-2013 Kristian Høgsberg +Copyright © 2013 Rafael Antognolli +Copyright © 2013 Jasper St. Pierre +Copyright © 2010-2013 Intel Corporation + +Permission

[PATCH 12/16] westoy: Remove fullscreen methods

From: "Jasper St. Pierre" These aren't supported under xdg_shell, at least not right now. If xdg_shell ever gets support for them, we can revert this commit and adapt it. --- clients/fullscreen.c | 19 +++ clients/transformed.c | 21 + clients/window.c |

[PATCH 15/16] xdg-shell: Use xdg-shell in simple-shm.

--- clients/Makefile.am | 4 +++- clients/simple-shm.c | 50 ++ 2 files changed, 33 insertions(+), 21 deletions(-) diff --git a/clients/Makefile.am b/clients/Makefile.am index 91174bf..10f0d2a 100644 --- a/clients/Makefile.am +++ b/clients/Makefil

[PATCH 07/16] xdg-shell: Implement xdg_popup.

--- src/shell.c | 159 ++-- 1 file changed, 155 insertions(+), 4 deletions(-) diff --git a/src/shell.c b/src/shell.c index 98fb0fe..0daa136 100644 --- a/src/shell.c +++ b/src/shell.c @@ -247,6 +247,12 @@ struct ping_timer { uint32_t

[PATCH 03/16] shell: Change set_maximized to receive internal structures.

Change the parameters of set_maximized from wl_resource and wl_client to shell_surface and weston_output. This will allow it to be used with xdg-shell too. --- src/shell.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/src/shell.c b/src/shell.c index cf89a

[PATCH 02/16] shell: Remove SHELL_SURFACE_FULLSCREEN and SHELL_SURFACE_MAXIMIZED.

These surface types don't exist anymore inside weston desktop shell implementation. They are just exposed as wl_shell surface types, but internally the implementation is done with surface states. The previous behavior (setting a surface type unsets another one) still happens when using wl_shell. T

[PATCH 13/16] westoy: Remove MAXIMIZED and FULLSCREEN as separate window types

From: "Jasper St. Pierre" xdg_shell changes this around so that they are flags on the remote object itself, not separate surface types. Move to a system where we calculate the state from the flags ourselves and set the appropriate wl_shell_surface type. When we port to xdg_shell, we'll drop thes

[PATCH 04/16] xdg-shell: Implement part of the interface.

Basic requests are implemented, enough to get a surface displayed. --- src/.gitignore | 2 + src/Makefile.am | 6 +- src/shell.c | 228 +--- 3 files changed, 223 insertions(+), 13 deletions(-) diff --git a/src/.gitignore b/src/.gitignor

[PATCH 10/16] westoy: Schedule a full resize when we add a subsurface

From: "Jasper St. Pierre" If a client adds a subsurface, we need to make sure it's allocated properly, so queue a resize and redraw on the parent window. --- clients/window.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/clients/window.c b/clients/window.c index a201ebb..5734db6 100644

[PATCH 05/16] xdg-shell: Implementing maximized and fullscreen states.

--- src/shell.c | 87 + 1 file changed, 82 insertions(+), 5 deletions(-) diff --git a/src/shell.c b/src/shell.c index f775899..6cbb4bd 100644 --- a/src/shell.c +++ b/src/shell.c @@ -2999,6 +2999,83 @@ xdg_surface_resize(struct wl_client

[PATCH 14/16] westoy: Port the toy toolkit over to xdg-shell

From: "Jasper St. Pierre" --- clients/.gitignore | 2 + clients/Makefile.am | 8 +- clients/window.c| 281 ++-- src/shell.c | 8 +- 4 files changed, 156 insertions(+), 143 deletions(-) diff --git a/clients/.gitignore b/clients/.

[PATCH 11/16] westoy: Use subsurfaces for tooltips instead of transient windows

From: "Jasper St. Pierre" Transient windows, at least not as they are today, don't exist in xdg_shell. Subsurfaces allow for specially placed surfaces relative to a window, so use these instead. --- clients/window.c | 46 -- 1 file changed, 8 insertion

[PATCH 06/16] xdg-shell: Implement set_transient_for request.

The implementation just sets a parent/child relationship between the xdg_surface and its parent, passed as argument of this request. Stacking might be affected (that's up to the compositor). This implementation does not affect the code that handles the previous transient surface type. It should st

[PATCH 00/16] xdg-shell protocol, implementation and port of toytoolkit.

westoy: Remove fullscreen methods westoy: Remove MAXIMIZED and FULLSCREEN as separate window types westoy: Port the toy toolkit over to xdg-shell Rafael Antognolli (11): xdg_shell: Adding a new shell protocol. shell: Remove SHELL_SURFACE_FULLSCREEN and SHELL_SURFACE_MAXIMIZED. shell

Re: [RFC v2] surface crop & scale protocol extension

On Fri, Nov 08, 2013 at 10:59:07AM -0800, Bill Spitzak wrote: > > > Pekka Paalanen wrote: > >Hi all, > > > >this is the v2 of the crop and scale extension, as RFC. > > I get the impression that the result of crop+scale is supposed to be exactly > the same as though the client made a second buffe

[PATCH] xdg_shell: Adding a new shell protocol.

/protocol/xdg-surface.xml b/protocol/xdg-surface.xml new file mode 100644 index 000..66b8d29 --- /dev/null +++ b/protocol/xdg-surface.xml @@ -0,0 +1,378 @@ + + + + +Copyright © 2008-2013 Kristian Høgsberg +Copyright © 2013 Rafael Antognolli +Copyright © 2013 Jasper St

[PATCH] xdg_shell: Adding a new shell protocol.

/protocol/xdg-surface.xml b/protocol/xdg-surface.xml new file mode 100644 index 000..66b8d29 --- /dev/null +++ b/protocol/xdg-surface.xml @@ -0,0 +1,378 @@ + + + + +Copyright © 2008-2013 Kristian Høgsberg +Copyright © 2013 Rafael Antognolli +Copyright © 2013 Jasper St

Re: [PATCH] xdg-shell - yet another proposal (this time for real).

d the protocol is totally unstable/experimental (would be called egg_shell for that, but we just left it as xdg_shell). I'll get back to the activation discussion in a bit. And thanks a lot so far fo the input. On Thu, Nov 07, 2013 at 10:42:33AM -0800, Bill Spitzak wrote: > Rafael Ant

Re: [PATCH] xdg-shell - yet another proposal (this time for real).

d the protocol is totally unstable/experimental (would be called egg_shell for that, but we just left it as xdg_shell). On Thu, Nov 7, 2013 at 4:42 PM, Bill Spitzak wrote: > Rafael Antognolli wrote: > >> So, I added "activated" and "deactivated" events, that the compo

[PATCH] xdg-shell - yet another proposal (this time for real).

ated version with what I understood from that tomorrow. Should be simple. Any feedback is appreciated, and thank you guys for the input so far and the patience. Rafael Antognolli (1): xdg_shell: Add a new shell protocol. protocol/Makefile.am | 2 +- protocol/xdg-surface.xml | 381

[PATCH] xdg_shell: Add a new shell protocol.

100644 index 000..8e29751 --- /dev/null +++ b/protocol/xdg-surface.xml @@ -0,0 +1,381 @@ + + + + +Copyright © 2008-2013 Kristian Høgsberg +Copyright © 2013 Rafael Antognolli +Copyright © 2010-2013 Intel Corporation + +Permission to use, copy, modify, distribute, and sell

Re: [PATCH] xdg-shell - yet another proposal.

Please, ignore this email, apparently I sent the wrong thing (too sleepy now). I'll send it again tomorrow. On Thu, Nov 7, 2013 at 12:45 AM, Rafael Antognolli wrote: > Hello all, > > I'm trying to summarize part of the discussion in this new patch, but it's not > the

[PATCH] xdg_shell: Add a new shell protocol.

100644 index 000..578c0d7 --- /dev/null +++ b/protocol/xdg-surface.xml @@ -0,0 +1,518 @@ + + + + +Copyright © 2008-2013 Kristian Høgsberg +Copyright © 2013 Rafael Antognolli +Copyright © 2010-2013 Intel Corporation + +Permission to use, copy, modify, distribute, and sell

[PATCH] xdg-shell - yet another proposal.

tates now. Correct me if I'm wrong. Otherwise I'm going to send an updated version with those changes tomorrow. I also talked to jekstrand (I think) about stacking, will send an updated version with what I understood from that tomorrow. Should be simple. Any feedback is appreciated,

Re: [PATCH 2/2] protocol: add state set functions for maximized and fullscreen.

On Thu, Oct 31, 2013 at 12:42 AM, Jason Ekstrand wrote: > Bill, > Because I want to respond to everything in one e-mail, I'm going to try and > address your comments here even though they may not show up. > > On Wed, Oct 30, 2013 at 3:19 PM, Rafael Antognolli > wrote: >

Re: [PATCH 2/2] protocol: add state set functions for maximized and fullscreen.

> "children" are sometimes called "transient windows", or "popup windows", > etc. This both communicates what window is the "parent" and makes map and > raise of the parents atomic with the children. > > If a client really has a reason to make the parenting different than the > raising it can temporarily rearrange the tree before doing a raise and then > put it back. > > ___ > wayland-devel mailing list > wayland-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/wayland-devel -- Rafael Antognolli ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: Should I always add wl_display_sync() before wl_display_dispatch_queue()?

On Mon, Oct 28, 2013 at 10:06:47PM -0500, Jason Ekstrand wrote: > On Mon, Oct 28, 2013 at 9:39 PM, Zhao, Halley wrote: > > > Video player use frame callback on an event queue, sometimes there is > > synchronization issue. > > > > After looked at other usage of event queue, I found: > > >

Re: [PATCH 2/2] protocol: add state set functions for maximized and fullscreen.

On Wed, Oct 16, 2013 at 2:53 AM, Kristian Høgsberg wrote: > On Tue, Oct 15, 2013 at 8:05 AM, wrote: >> From: Rafael Antognolli >> >> These functions only differ from the previous one because they request >> that the given state is set, without changing the surface

Re: [PATCH 1/2] xdg_shell: Add a new shell protocol.

, or if it's going to be built into the wayland library). Thanks for the reviews, Rafael On Tue, Oct 15, 2013 at 12:05 PM, wrote: > From: Rafael Antognolli > > xdg_shell is a protocol aimed to substitute wl_shell in the long term, > but will not be part of the wayland core protoco

Re: [PATCH 1/2] xdg_shell: Add a new shell protocol.

On Tue, Oct 15, 2013 at 8:28 AM, Pekka Paalanen wrote: > On Tue, 15 Oct 2013 07:30:54 -0300 > Rafael Antognolli wrote: > >> Hi, >> >> On Tue, Oct 8, 2013 at 4:07 AM, Pekka Paalanen wrote: >> > Hi, >> > >> > sorry for a late reply, I&

Re: [PATCH 1/2] xdg_shell: Add a new shell protocol.

Hi, On Tue, Oct 8, 2013 at 4:07 AM, Pekka Paalanen wrote: > Hi, > > sorry for a late reply, I'm still around 600 emails behind of > wayland-devel@... > > > On Fri, 19 Jul 2013 16:42:13 -0300 > antogno...@gmail.com wrote: > >> From: Rafael Antognolli

Re: [PATCH] xdg_shell: Add a new shell protocol.

Is this good? Ah, the new patch went to another thread, I guess that I should have used --chain-reply-to to avoid that. Regards, -- Rafael Antognolli ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH] xdg_shell: Add a new shell protocol.

ristian > > On Fri, Jul 5, 2013 at 3:39 PM, wrote: >> From: Rafael Antognolli >> >> xdg_shell is a protocol aimed to substitute wl_shell in the long term, >> but will not be part of the wayland core protocol. It starts as a >> non-stable API, aimed to be used as a

Re: minimized and stick windows

I want to know basically two things: 1) Will we have 2 new APIs for *each* surface states, so we can add the needed parameters to them, or a generic set/unset API with something like a void * parameter that will be used for any state? 2) Is fullscreen staying as another state, or as a surface t

Re: minimized and stick windows

On Wed, Jun 12, 2013 at 7:39 PM, Rafael Antognolli wrote: > On Wed, Jun 12, 2013 at 4:39 PM, Bill Spitzak wrote: >> >>>> Shell surface types, exclusive: >>>> - top-level >>>> - transient (umm, what was this for, again?) >>>> - popup (m

Re: minimized and stick windows

parenting. > > Popups are also transient windows (and thus normal windows) but they have > some effects on event delivery when they are first mapped. So this would be a different state, that has the "transient" state being set as a requirement, or would it be a flag passed to

Re: minimized and stick windows

vel; > transcient; popup; }; }. > > That would allow to extend the configure event in a nice fashion, that > tiling WM will love (e.g. for decorations). > Hmm... I'm still trying to understand this part, but are these calls used to create the shell surfaces? I also don't ge

Re: minimized and stick windows

oth easier and harder than keeping >>> wl_shell_surface around, as we have to maintain a compatibility struct >>> in the compositor, but that would be a simple struct { type; union { >>> toplevel; transcient; popup; }; }. >>> >>> That would allow

Re: minimized and stick windows

with panel removed (and the app will use the normal decoration > mechanism here, no fullscreen state), and plain fullscreen, which would be > another surface type. > I *think* most apps (games) already have heavy switching, so destroying and > creating a new surface should not be a problem here, imo. If I'm not wrong, in the previous discussion we also discussed about the possibility of leaving fullscreen as a shell surface type itself. Though I don't have strong opinion about this, just trying to leave another possibility open. -- Rafael Antognolli ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: minimized and stick windows

On Thu, Jun 6, 2013 at 3:50 PM, Kristian Høgsberg wrote: > On Tue, May 28, 2013 at 1:10 PM, Rafael Antognolli > wrote: >> On Thu, May 16, 2013 at 2:12 PM, Bill Spitzak wrote: >>> >>> >>> Pekka Paalanen wrote: >>> >>>>> For exa

Re: minimized and stick windows

ll of them. OK, so since what Khristian proposed was this: https://github.com/antognolli/wayland/commit/a94eb97fdf49c6e06b0b4e94f4b8c840602442db Can I start from it? It seems to me that it allows to cover the most important part mentioned here, which is the fact that weston wil

Re: minimized and stick windows

Hi Jason, On Wed, May 8, 2013 at 9:26 PM, Jason Ekstrand wrote: > Hi Rafael, > > > On Wed, May 8, 2013 at 6:04 PM, Rafael Antognolli > wrote: >> >> Hello, >> >> I've been looking the Weston code relative to maximized windows, and >> it se

minimized and stick windows

he "sticky" window feature (when a window is pinned, visible on every workspace). Is this a desired feature too? Regards, -- Rafael Antognolli ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Touch screen not working under weston drm

test the touchscreen, and he's going to be out of the office from tomorrow and during the entire next week. So there's no hurry to make this work. -- Rafael Antognolli http://antognolli.org/ ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel